Keyboard Shortcuts
File
u
:
up to issue
m
:
publish + mail comments
M
:
edit review message
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
<Enter>
:
respond to / edit current comment
d
:
mark current comment as done
Issue
u
:
up to list of issues
m
:
publish + mail comments
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
#
:
close issue
Comment/message editing
<Ctrl>
+
s
or
<Ctrl>
+
Enter
:
save comment
<Esc>
:
cancel edit
Rietveld
Code Review Tool
Help
|
Bug tracker
|
Discussion group
|
Source code
|
Sign in
(308)
Issues
Repositories
Search
Open Issues
|
Closed Issues
|
All Issues
|
Sign in
with your
Google Account
to create issues and add comments
Issue
319590043
: Make template classes use NS_LOG_* macros (v2)
Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years ago by
Stefano Avallone
Modified:
7 years ago
Reviewers:
Visibility:
Public.
More Reviews
Description
Make template classes use NS_LOG_* macros (v2)
Patch Set 1
#
Created:
7 years ago
Download
[raw]
[tar.bz2]
Unified diffs
Side-by-side diffs
Delta from patch set
Stats
(
+155 lines, -93 lines
)
Patch
M
src/core/model/log.h
View
5 chunks
+47 lines, -3 lines
0 comments
Download
M
src/core/model/log.cc
View
3 chunks
+41 lines, -0 lines
0 comments
Download
M
src/core/model/log-macros-enabled.h
View
7 chunks
+11 lines, -11 lines
0 comments
Download
M
src/network/utils/drop-tail-queue.h
View
5 chunks
+11 lines, -8 lines
0 comments
Download
M
src/network/utils/drop-tail-queue.cc
View
1 chunk
+3 lines, -0 lines
0 comments
Download
M
src/network/utils/net-device-queue-interface.h
View
6 chunks
+8 lines, -26 lines
0 comments
Download
M
src/network/utils/net-device-queue-interface.cc
View
2 chunks
+2 lines, -6 lines
0 comments
Download
M
src/network/utils/queue.h
View
13 chunks
+18 lines, -33 lines
0 comments
Download
M
src/network/utils/queue.cc
View
2 chunks
+4 lines, -6 lines
0 comments
Download
M
src/traffic-control/model/queue-disc.cc
View
1 chunk
+3 lines, -0 lines
0 comments
Download
M
src/wifi/model/wifi-mac-queue.h
View
1 chunk
+2 lines, -0 lines
0 comments
Download
M
src/wifi/model/wifi-mac-queue.cc
View
2 chunks
+5 lines, -0 lines
0 comments
Download
Messages
Total messages: 1
Expand All Messages
|
Collapse All Messages
Stefano Avallone
For a description, see: Bug 2668 - NS_LOG can not be used in templates
7 years ago (2017-03-27 15:58:44 UTC)
#1
For a description, see: Bug 2668 - NS_LOG can not be used in templates
Sign in
to reply to this message.
Expand All Messages
|
Collapse All Messages
Issue 319590043: Make template classes use NS_LOG_* macros (v2)
Created 7 years ago by Stefano Avallone
Modified 7 years ago
Reviewers:
Base URL:
Comments: 0
Recent Issues
|
This issue
This is Rietveld
f62528b