i#1547 Added secondary tables for 13 syscalls: resubmit

Commit log for first patchset:
---------------
i#1547 Added secondary tables for 13 syscalls: resubmit

Added secondary tables for 13 syscalls which are used
undocumented enumerations.
NtSetVolumeInformationFile;
NtAlpcQueryInformation;
NtAlpcQueryInformationMessage;
NtAlpcSetInformation;
NtQueryInformationEnlistment;
NtQueryInformationResourceManager;
NtQueryInformationTransaction;
NtQueryInformationTransactionManager;
NtSetInformationEnlistment;
NtSetInformationResourceManager;
NtSetInformationTransaction;
NtSetInformationTransactionManager;
NtSetTimerEx

Resubmitted issue: https://codereview.appspot.com/164290045/
---------------

[bruening, 2017-02-08 15:56:05]

FYI, Qin is out on leave and I'm traveling so it may take a few days to get to
this.  (Also note that if you prefer a github pull request we accept those now
that they have rebase support.)

[bruening, 2017-02-11 22:17:34]

LGTM w/ comment

https://codereview.appspot.com/318480043/diff/1/drsyscall/drsyscall_windows.c
File drsyscall/drsyscall_windows.c (right):

https://codereview.appspot.com/318480043/diff/1/drsyscall/drsyscall_windows.c...
drsyscall/drsyscall_windows.c:611: 
Not in prior diff https://codereview.appspot.com/164290045 -- so this isn't an
identical patch?  Trying to get the old raw patch and diff them is getting weird
results.  Manual scanning does make the rest look similar from a high level.

https://codereview.appspot.com/318480043/diff/1/drsyscall/table_windows_ntosk...
File drsyscall/table_windows_ntoskrnl_infoclass.c (right):

https://codereview.appspot.com/318480043/diff/1/drsyscall/table_windows_ntosk...
drsyscall/table_windows_ntoskrnl_infoclass.c:1004: {2, -3, R, 0, typename},\
These are all structs, right?  So DRSYS_TYPE_STRUCT instead of 0, right?

[Maxim Shudrak, 2017-02-12 17:50:39]

Committed as
https://github.com/DynamoRIO/drmemory/commit/e5b9c6726cd83e8f358211ffbffb8a85...

Final commit log: 
---------------
i#1547 Added secondary tables for 13 syscalls: resubmit

Added secondary tables for 13 syscalls which are used
undocumented enumerations.
NtSetVolumeInformationFile;
NtAlpcQueryInformation;
NtAlpcQueryInformationMessage;
NtAlpcSetInformation;
NtQueryInformationEnlistment;
NtQueryInformationResourceManager;
NtQueryInformationTransaction;
NtQueryInformationTransactionManager;
NtSetInformationEnlistment;
NtSetInformationResourceManager;
NtSetInformationTransaction;
NtSetInformationTransactionManager;
NtSetTimerEx

Resubmitted issue: https://codereview.appspot.com/164290045/

Review-URL: https://codereview.appspot.com/318480043
---------------

[Maxim Shudrak, 2017-02-12 17:51:22]

Answer on comments

https://codereview.appspot.com/318480043/diff/1/drsyscall/drsyscall_windows.c
File drsyscall/drsyscall_windows.c (right):

https://codereview.appspot.com/318480043/diff/1/drsyscall/drsyscall_windows.c...
drsyscall/drsyscall_windows.c:611: 
On 2017/02/11 22:17:34, bruening wrote:
> Not in prior diff https://codereview.appspot.com/164290045 -- so this isn't an
> identical patch?  Trying to get the old raw patch and diff them is getting
weird
> results.  Manual scanning does make the rest look similar from a high level.

Yes, 2 years left, I took old commit and merge it with the newest DrM code base.

https://codereview.appspot.com/318480043/diff/1/drsyscall/table_windows_ntosk...
File drsyscall/table_windows_ntoskrnl_infoclass.c (right):

https://codereview.appspot.com/318480043/diff/1/drsyscall/table_windows_ntosk...
drsyscall/table_windows_ntoskrnl_infoclass.c:1004: {2, -3, R, 0, typename},\
On 2017/02/11 22:17:34, bruening wrote:
> These are all structs, right?  So DRSYS_TYPE_STRUCT instead of 0, right?

Done.

[Maxim Shudrak, 2017-02-12 17:58:09]

On 2017/02/12 17:50:39, Maxim Shudrak wrote:
> Committed as
>
https://github.com/DynamoRIO/drmemory/commit/e5b9c6726cd83e8f358211ffbffb8a85...
> 
> Final commit log: 
> ---------------
> i#1547 Added secondary tables for 13 syscalls: resubmit
> 
> Added secondary tables for 13 syscalls which are used
> undocumented enumerations.
> NtSetVolumeInformationFile;
> NtAlpcQueryInformation;
> NtAlpcQueryInformationMessage;
> NtAlpcSetInformation;
> NtQueryInformationEnlistment;
> NtQueryInformationResourceManager;
> NtQueryInformationTransaction;
> NtQueryInformationTransactionManager;
> NtSetInformationEnlistment;
> NtSetInformationResourceManager;
> NtSetInformationTransaction;
> NtSetInformationTransactionManager;
> NtSetTimerEx
> 
> Resubmitted issue: https://codereview.appspot.com/164290045/
> 
> Review-URL: https://codereview.appspot.com/318480043
> ---------------

I don't see this commit in our branch at github. Why ?

[bruening, 2017-02-12 18:01:47]

On 2017/02/12 17:58:09, Maxim Shudrak wrote:
> On 2017/02/12 17:50:39, Maxim Shudrak wrote:
> > Committed as
> >
>
https://github.com/DynamoRIO/drmemory/commit/e5b9c6726cd83e8f358211ffbffb8a85...
> > 
> > Final commit log: 
> > ---------------
> > i#1547 Added secondary tables for 13 syscalls: resubmit
> > 
> > Added secondary tables for 13 syscalls which are used
> > undocumented enumerations.
> > NtSetVolumeInformationFile;
> > NtAlpcQueryInformation;
> > NtAlpcQueryInformationMessage;
> > NtAlpcSetInformation;
> > NtQueryInformationEnlistment;
> > NtQueryInformationResourceManager;
> > NtQueryInformationTransaction;
> > NtQueryInformationTransactionManager;
> > NtSetInformationEnlistment;
> > NtSetInformationResourceManager;
> > NtSetInformationTransaction;
> > NtSetInformationTransactionManager;
> > NtSetTimerEx
> > 
> > Resubmitted issue: https://codereview.appspot.com/164290045/
> > 
> > Review-URL: https://codereview.appspot.com/318480043
> > ---------------
> 
> I don't see this commit in our branch at github. Why ?

What git command did you run to do the commit and what was its output?  Did the
push part of dcommit fail?  What was the error message?

[Maxim Shudrak, 2017-02-12 18:04:11]

On 2017/02/12 18:01:47, bruening wrote:
> On 2017/02/12 17:58:09, Maxim Shudrak wrote:
> > On 2017/02/12 17:50:39, Maxim Shudrak wrote:
> > > Committed as
> > >
> >
>
https://github.com/DynamoRIO/drmemory/commit/e5b9c6726cd83e8f358211ffbffb8a85...
> > > 
> > > Final commit log: 
> > > ---------------
> > > i#1547 Added secondary tables for 13 syscalls: resubmit
> > > 
> > > Added secondary tables for 13 syscalls which are used
> > > undocumented enumerations.
> > > NtSetVolumeInformationFile;
> > > NtAlpcQueryInformation;
> > > NtAlpcQueryInformationMessage;
> > > NtAlpcSetInformation;
> > > NtQueryInformationEnlistment;
> > > NtQueryInformationResourceManager;
> > > NtQueryInformationTransaction;
> > > NtQueryInformationTransactionManager;
> > > NtSetInformationEnlistment;
> > > NtSetInformationResourceManager;
> > > NtSetInformationTransaction;
> > > NtSetInformationTransactionManager;
> > > NtSetTimerEx
> > > 
> > > Resubmitted issue: https://codereview.appspot.com/164290045/
> > > 
> > > Review-URL: https://codereview.appspot.com/318480043
> > > ---------------
> > 
> > I don't see this commit in our branch at github. Why ?
> 
> What git command did you run to do the commit and what was its output?  Did
the
> push part of dcommit fail?  What was the error message?

Ah, ok fixed. My mistake, forgot to enter login/password for github.