Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2366)

Issue 318210043: [plaso] Initial version of processing configuration #1118 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 2 months ago by Joachim Metz
Modified:
7 years, 2 months ago
Reviewers:
jberggren, romaing, onager
CC:
kiddi, log2timeline-dev_googlegroups.com
Visibility:
Public.

Description

[plaso] Initial version of processing configuration #1118

Patch Set 1 : Worked on processing configuration #

Total comments: 16

Patch Set 2 : Worked on processing configuration #

Patch Set 3 : Worked on processing configuration #

Unified diffs Side-by-side diffs Delta from patch set Stats (+621 lines, -674 lines) Patch
A plaso/engine/configurations.py View 1 1 chunk +154 lines, -0 lines 0 comments Download
M plaso/engine/engine.py View 1 1 chunk +2 lines, -28 lines 0 comments Download
M plaso/engine/extractors.py View 16 chunks +57 lines, -36 lines 0 comments Download
M plaso/engine/processing_status.py View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M plaso/engine/single_process.py View 1 2 9 chunks +46 lines, -92 lines 0 comments Download
M plaso/engine/worker.py View 11 chunks +57 lines, -48 lines 0 comments Download
M plaso/frontend/extraction_frontend.py View 1 2 6 chunks +21 lines, -90 lines 0 comments Download
M plaso/frontend/image_export.py View 2 chunks +5 lines, -2 lines 0 comments Download
M plaso/frontend/psort.py View 4 chunks +17 lines, -10 lines 0 comments Download
M plaso/multi_processing/engine.py View 1 2 5 chunks +30 lines, -30 lines 0 comments Download
M plaso/multi_processing/psort.py View 1 2 2 chunks +16 lines, -24 lines 0 comments Download
M plaso/multi_processing/task_engine.py View 1 2 12 chunks +39 lines, -112 lines 0 comments Download
M plaso/multi_processing/worker_process.py View 5 chunks +39 lines, -95 lines 0 comments Download
M plaso/parsers/mediator.py View 6 chunks +26 lines, -23 lines 0 comments Download
M plaso/storage/time_range.py View 2 chunks +6 lines, -6 lines 0 comments Download
M tests/engine/extractors.py View 5 chunks +12 lines, -9 lines 0 comments Download
M tests/engine/single_process.py View 2 chunks +5 lines, -2 lines 0 comments Download
M tests/engine/worker.py View 5 chunks +17 lines, -14 lines 0 comments Download
M tests/frontend/extraction_frontend.py View 1 2 4 chunks +7 lines, -21 lines 0 comments Download
M tests/multi_processing/task_engine.py View 2 chunks +5 lines, -2 lines 0 comments Download
M tests/multi_processing/worker_process.py View 2 chunks +3 lines, -3 lines 0 comments Download
M tests/parsers/mediator.py View 2 chunks +5 lines, -1 line 0 comments Download
M tools/log2timeline.py View 1 2 5 chunks +28 lines, -17 lines 0 comments Download
M tools/psort.py View 3 chunks +6 lines, -2 lines 0 comments Download
M tools/psteal.py View 1 3 chunks +15 lines, -4 lines 0 comments Download

Messages

Total messages: 9
Joachim Metz
7 years, 2 months ago (2017-01-05 07:32:36 UTC) #1
Joachim Metz
Code updated.
7 years, 2 months ago (2017-01-06 06:47:29 UTC) #2
Joachim Metz
Code updated.
7 years, 2 months ago (2017-01-07 14:23:26 UTC) #3
onager
First round. https://codereview.appspot.com/318210043/diff/40001/plaso/engine/configurations.py File plaso/engine/configurations.py (right): https://codereview.appspot.com/318210043/diff/40001/plaso/engine/configurations.py#newcode4 plaso/engine/configurations.py:4: # TODO: should these be attribute containers? ...
7 years, 2 months ago (2017-01-13 12:33:14 UTC) #4
Joachim Metz
https://codereview.appspot.com/318210043/diff/40001/plaso/engine/configurations.py File plaso/engine/configurations.py (right): https://codereview.appspot.com/318210043/diff/40001/plaso/engine/configurations.py#newcode4 plaso/engine/configurations.py:4: # TODO: should these be attribute containers? On 2017/01/13 ...
7 years, 2 months ago (2017-01-15 08:14:53 UTC) #5
Joachim Metz
Code updated.
7 years, 2 months ago (2017-01-15 08:17:59 UTC) #6
onager
LGTM
7 years, 2 months ago (2017-01-16 16:25:43 UTC) #7
Joachim Metz
Code updated.
7 years, 2 months ago (2017-01-16 18:54:42 UTC) #8
Joachim Metz
7 years, 2 months ago (2017-01-16 19:01:46 UTC) #9
Changes have been merged with master branch. To close the review and clean up
the feature branch you can run: python ./utils/review.py close processconfig
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b