Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(226)
Issues Repositories Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 318190043: [plaso] Migrated plaso timestamp to dfdatetime for Windows Registry plugins #910 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 3 months ago by Joachim Metz
Modified:
7 years ago
Reviewers:
jberggren, romaing, onager
CC:
kiddi, log2timeline-dev_googlegroups.com
Visibility:
Public.

Description

[plaso] Migrated plaso timestamp to dfdatetime for Windows Registry plugins #910

Patch Set 1 : Migrated plaso timestamp to dfdatetime for Windows Registry plugins #910 #

Patch Set 2 : Migrated plaso timestamp to dfdatetime for Windows Registry plugins #910 #

Total comments: 6

Patch Set 3 : Changes after review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1617 lines, -1506 lines) Patch
M plaso/containers/windows_events.py View 1 2 2 chunks +67 lines, -136 lines 0 comments Download
M plaso/formatters/appcompatcache.py View 1 chunk +1 line, -1 line 0 comments Download
M plaso/formatters/userassist.py View 2 chunks +7 lines, -32 lines 0 comments Download
M plaso/parsers/winreg_plugins/__init__.py View 1 chunk +1 line, -1 line 0 comments Download
M plaso/parsers/winreg_plugins/appcompatcache.py View 9 chunks +65 lines, -54 lines 0 comments Download
M plaso/parsers/winreg_plugins/bagmru.py View 7 chunks +60 lines, -44 lines 0 comments Download
M plaso/parsers/winreg_plugins/ccleaner.py View 3 chunks +19 lines, -13 lines 0 comments Download
M plaso/parsers/winreg_plugins/default.py View 3 chunks +14 lines, -9 lines 0 comments Download
M plaso/parsers/winreg_plugins/interface.py View 15 chunks +32 lines, -36 lines 0 comments Download
M plaso/parsers/winreg_plugins/lfu.py View 4 chunks +37 lines, -27 lines 0 comments Download
M plaso/parsers/winreg_plugins/mountpoints.py View 3 chunks +16 lines, -9 lines 0 comments Download
M plaso/parsers/winreg_plugins/mrulist.py View 10 chunks +74 lines, -62 lines 0 comments Download
M plaso/parsers/winreg_plugins/mrulistex.py View 17 chunks +117 lines, -99 lines 0 comments Download
M plaso/parsers/winreg_plugins/msie_zones.py View 5 chunks +31 lines, -18 lines 0 comments Download
M plaso/parsers/winreg_plugins/network_drives.py View 3 chunks +19 lines, -9 lines 0 comments Download
M plaso/parsers/winreg_plugins/networks.py View 4 chunks +123 lines, -34 lines 0 comments Download
M plaso/parsers/winreg_plugins/officemru.py View 4 chunks +45 lines, -37 lines 0 comments Download
M plaso/parsers/winreg_plugins/outlook.py View 3 chunks +16 lines, -9 lines 0 comments Download
M plaso/parsers/winreg_plugins/programscache.py View 7 chunks +30 lines, -25 lines 0 comments Download
M plaso/parsers/winreg_plugins/run.py View 3 chunks +21 lines, -11 lines 0 comments Download
M plaso/parsers/winreg_plugins/sam_users.py View 5 chunks +64 lines, -69 lines 0 comments Download
M plaso/parsers/winreg_plugins/services.py View 4 chunks +18 lines, -11 lines 0 comments Download
M plaso/parsers/winreg_plugins/shutdown.py View 3 chunks +40 lines, -37 lines 0 comments Download
M plaso/parsers/winreg_plugins/task_scheduler.py View 3 chunks +55 lines, -43 lines 0 comments Download
M plaso/parsers/winreg_plugins/terminal_server.py View 5 chunks +39 lines, -23 lines 0 comments Download
M plaso/parsers/winreg_plugins/timezone.py View 2 chunks +21 lines, -30 lines 0 comments Download
M plaso/parsers/winreg_plugins/typedurls.py View 3 chunks +16 lines, -9 lines 0 comments Download
M plaso/parsers/winreg_plugins/usb.py View 3 chunks +16 lines, -10 lines 0 comments Download
M plaso/parsers/winreg_plugins/usbstor.py View 3 chunks +31 lines, -28 lines 0 comments Download
M plaso/parsers/winreg_plugins/userassist.py View 7 chunks +84 lines, -66 lines 0 comments Download
A plaso/parsers/winreg_plugins/windows_version.py View 1 chunk +98 lines, -0 lines 0 comments Download
M plaso/parsers/winreg_plugins/winlogon.py View 3 chunks +55 lines, -38 lines 0 comments Download
M plaso/parsers/winreg_plugins/winrar.py View 3 chunks +16 lines, -9 lines 0 comments Download
D plaso/parsers/winreg_plugins/winver.py View 1 chunk +0 lines, -89 lines 0 comments Download
M tests/analysis/windows_services.py View 3 chunks +12 lines, -13 lines 0 comments Download
M tests/containers/test_lib.py View 3 chunks +67 lines, -41 lines 0 comments Download
M tests/formatters/appcompatcache.py View 1 chunk +1 line, -1 line 0 comments Download
M tests/formatters/manager.py View 2 chunks +5 lines, -4 lines 0 comments Download
M tests/formatters/userassist.py View 1 chunk +5 lines, -1 line 0 comments Download
M tests/parsers/winreg_plugins/appcompatcache.py View 7 chunks +7 lines, -7 lines 0 comments Download
M tests/parsers/winreg_plugins/bagmru.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/parsers/winreg_plugins/ccleaner.py View 1 chunk +1 line, -1 line 0 comments Download
M tests/parsers/winreg_plugins/default.py View 1 chunk +1 line, -1 line 0 comments Download
M tests/parsers/winreg_plugins/lfu.py View 3 chunks +3 lines, -3 lines 0 comments Download
M tests/parsers/winreg_plugins/mountpoints.py View 1 chunk +1 line, -1 line 0 comments Download
M tests/parsers/winreg_plugins/mrulist.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/parsers/winreg_plugins/mrulistex.py View 4 chunks +4 lines, -4 lines 0 comments Download
M tests/parsers/winreg_plugins/msie_zones.py View 4 chunks +4 lines, -4 lines 0 comments Download
M tests/parsers/winreg_plugins/network_drives.py View 1 chunk +1 line, -1 line 0 comments Download
M tests/parsers/winreg_plugins/networks.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/parsers/winreg_plugins/officemru.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/parsers/winreg_plugins/outlook.py View 1 chunk +1 line, -1 line 0 comments Download
M tests/parsers/winreg_plugins/programscache.py View 1 chunk +1 line, -1 line 0 comments Download
M tests/parsers/winreg_plugins/run.py View 5 chunks +12 lines, -10 lines 0 comments Download
M tests/parsers/winreg_plugins/sam_users.py View 1 chunk +1 line, -1 line 0 comments Download
M tests/parsers/winreg_plugins/services.py View 1 chunk +1 line, -1 line 0 comments Download
M tests/parsers/winreg_plugins/task_scheduler.py View 1 chunk +1 line, -1 line 0 comments Download
M tests/parsers/winreg_plugins/terminal_server.py View 3 chunks +3 lines, -3 lines 0 comments Download
M tests/parsers/winreg_plugins/test_lib.py View 4 chunks +20 lines, -23 lines 0 comments Download
M tests/parsers/winreg_plugins/timezone.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/parsers/winreg_plugins/typedurls.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/parsers/winreg_plugins/usb.py View 1 chunk +1 line, -1 line 0 comments Download
M tests/parsers/winreg_plugins/usbstor.py View 1 chunk +1 line, -1 line 0 comments Download
M tests/parsers/winreg_plugins/userassist.py View 2 chunks +41 lines, -38 lines 0 comments Download
A + tests/parsers/winreg_plugins/windows_version.py View 5 chunks +7 lines, -7 lines 0 comments Download
M tests/parsers/winreg_plugins/winlogon.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/parsers/winreg_plugins/winrar.py View 1 chunk +1 line, -1 line 0 comments Download
D tests/parsers/winreg_plugins/winver.py View 1 chunk +0 lines, -168 lines 0 comments Download
M tests/storage/test_lib.py View 4 chunks +45 lines, -17 lines 0 comments Download
M tests/storage/zip_file.py View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tools/preg_test.py View 1 2 2 chunks +6 lines, -7 lines 0 comments Download

Messages

Total messages: 8
Joachim Metz
7 years, 3 months ago (2016-12-30 15:31:23 UTC) #1
Joachim Metz
Code updated.
7 years, 3 months ago (2016-12-30 15:35:03 UTC) #2
Joachim Metz
Code updated.
7 years, 3 months ago (2017-01-03 07:39:30 UTC) #3
onager
https://codereview.appspot.com/318190043/diff/40001/plaso/containers/windows_events.py File plaso/containers/windows_events.py (right): https://codereview.appspot.com/318190043/diff/40001/plaso/containers/windows_events.py#newcode32 plaso/containers/windows_events.py:32: # TODO: replace origin my something machine readable. -my ...
7 years, 1 month ago (2017-02-28 11:39:24 UTC) #4
Joachim Metz
https://codereview.appspot.com/318190043/diff/40001/plaso/containers/windows_events.py File plaso/containers/windows_events.py (right): https://codereview.appspot.com/318190043/diff/40001/plaso/containers/windows_events.py#newcode32 plaso/containers/windows_events.py:32: # TODO: replace origin my something machine readable. On ...
7 years, 1 month ago (2017-03-11 09:52:42 UTC) #5
Joachim Metz
Code updated.
7 years, 1 month ago (2017-03-11 09:56:19 UTC) #6
onager
LGTM
7 years ago (2017-03-24 10:48:39 UTC) #7
Joachim Metz
7 years ago (2017-03-25 08:55:33 UTC) #8 
Changes have been merged with master branch. To close the review and clean up
the feature branch you can run: python ./utils/review.py close dfdatetime_winreg
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b