Issue 317840043: [plaso] Removed online check for new dependency versions #1069

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 317840043: [plaso] Removed online check for new dependency versions #1069 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
7 years, 6 months ago by Joachim Metz

Modified:
7 years, 5 months ago

Reviewers:
jberggren, romaing, onager

CC:
kiddi, log2timeline-dev_googlegroups.com

Visibility:
Public.

More Reviews

Description

[plaso] Removed online check for new dependency versions #1069

Patch Set 2 : Removed online check for new dependency versions #1069 #

Patch Set 3 : Removed online check for new dependency versions #1069 #

Total comments: 2

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+192 lines, -323 lines)			Patch
M	plaso/dependencies.py	View	1 2	17 chunks	+190 lines, -277 lines	2 comments	Download
M	setup.cfg	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/dependencies.py	View		3 chunks	+0 lines, -44 lines	0 comments	Download
M	utils/check_dependencies.py	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

onager

One comment, LGTM https://codereview.appspot.com/317840043/diff/40001/plaso/dependencies.py File plaso/dependencies.py (right): https://codereview.appspot.com/317840043/diff/40001/plaso/dependencies.py#newcode10 plaso/dependencies.py:10: # (version_attribute_name, minimum_version, maximum_version) Please fix ...

7 years, 5 months ago (2016-10-31 14:51:09 UTC) #4

Joachim Metz

https://codereview.appspot.com/317840043/diff/40001/plaso/dependencies.py File plaso/dependencies.py (right): https://codereview.appspot.com/317840043/diff/40001/plaso/dependencies.py#newcode10 plaso/dependencies.py:10: # (version_attribute_name, minimum_version, maximum_version) On 2016/10/31 14:51:08, onager wrote: ...

7 years, 5 months ago (2016-10-31 15:21:17 UTC) #5

Joachim Metz

7 years, 5 months ago (2016-10-31 15:24:45 UTC) #6

Changes have been merged with master branch. To close the review and clean up
the feature branch you can run: python ./utils/review.py close deps

Expand All Messages | Collapse All Messages