Issue 317660043: WIP: Implement elementsFromPoint

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 317660043: WIP: Implement elementsFromPoint

Can't Edit
Can't Publish+Mail
Start Review

Created:
6 years, 10 months ago by ajuma

Modified:
6 years, 9 months ago

Reviewers:

Visibility:
Public.

More Reviews

Description

WIP: Implement elementsFromPoint BUG=

Patch Set 1 #

Patch Set 2 : 2 tests still fail #

Patch Set 3 : . #

Patch Set 4 : Start addresssing comments #

Patch Set 5 : Fix patch #

Patch Set 6 : Tests seem ok #

Patch Set 7 : Runtime flag #

Patch Set 8 : undo coordinate space change #

Patch Set 9 : Update changelog #

Patch Set 10 : Patch #

Patch Set 11 : Add tests #

Patch Set 12 : Fix build and update test results #

Patch Set 13 : Finish addressing review comments #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1067 lines, -138 lines)			Patch
M	LayoutTests/ChangeLog	View	1 2 3 4 5 6 7 8 9 10 11 12	1 chunk	+9 lines, -0 lines	0 comments	Download
M	LayoutTests/TestExpectations	View	1 2 3 4 5 6 7 8 9 10 11 12	1 chunk	+0 lines, -1 line	0 comments	Download
M	LayoutTests/imported/w3c/ChangeLog	View		1 chunk	+31 lines, -0 lines	0 comments	Download
A	LayoutTests/imported/w3c/web-platform-tests/cssom-view/elementsFromPoint-expected.txt	View	1 2 3 4 5 6 7 8 9 10 11	1 chunk	+17 lines, -0 lines	0 comments	Download
A	LayoutTests/imported/w3c/web-platform-tests/cssom-view/elementsFromPoint-iframes.html	View	1 2 3 4 5 6	1 chunk	+83 lines, -0 lines	0 comments	Download
A	LayoutTests/imported/w3c/web-platform-tests/cssom-view/elementsFromPoint-iframes-expected.txt	View	1 2 3 4 5 6	1 chunk	+5 lines, -0 lines	0 comments	Download
A	LayoutTests/imported/w3c/web-platform-tests/cssom-view/elementsFromPoint-invalid-cases.html	View	1 2 3 4 5 6	1 chunk	+56 lines, -0 lines	0 comments	Download
A	LayoutTests/imported/w3c/web-platform-tests/cssom-view/elementsFromPoint-invalid-cases-expected.txt	View	1 2 3 4 5 6	1 chunk	+5 lines, -0 lines	0 comments	Download
A	LayoutTests/imported/w3c/web-platform-tests/cssom-view/elementsFromPoint-shadowroot.html	View	1 2 3 4 5 6 7 8 9 10	1 chunk	+87 lines, -0 lines	0 comments	Download
A	LayoutTests/imported/w3c/web-platform-tests/cssom-view/elementsFromPoint-shadowroot-expected.txt	View	1 2 3 4 5 6 7 8 9 10 11	1 chunk	+5 lines, -0 lines	0 comments	Download
A	LayoutTests/imported/w3c/web-platform-tests/cssom-view/elementsFromPoint-simple.html	View	1 2 3 4 5	1 chunk	+131 lines, -0 lines	0 comments	Download
A	LayoutTests/imported/w3c/web-platform-tests/cssom-view/elementsFromPoint-simple-expected.txt	View	1 2 3 4 5 6	1 chunk	+8 lines, -0 lines	0 comments	Download
A	LayoutTests/imported/w3c/web-platform-tests/cssom-view/elementsFromPoint-svg.html	View	1 2 3 4 5 6	1 chunk	+67 lines, -0 lines	0 comments	Download
A	LayoutTests/imported/w3c/web-platform-tests/cssom-view/elementsFromPoint-svg-expected.txt	View	1 2 3 4 5 6	1 chunk	+6 lines, -0 lines	0 comments	Download
A	LayoutTests/imported/w3c/web-platform-tests/cssom-view/elementsFromPoint-table.html	View	1 2 3 4 5	1 chunk	+99 lines, -0 lines	0 comments	Download
A	LayoutTests/imported/w3c/web-platform-tests/cssom-view/elementsFromPoint-table-expected.txt	View	1 2 3 4 5 6	1 chunk	+6 lines, -0 lines	0 comments	Download
M	LayoutTests/imported/w3c/web-platform-tests/cssom-view/negativeMargins-expected.txt	View	1 2 3 4 5 6	1 chunk	+1 line, -2 lines	0 comments	Download
A	LayoutTests/imported/w3c/web-platform-tests/cssom-view/resources/elementsFromPoint.js	View	1 2 3 4 5	1 chunk	+48 lines, -0 lines	0 comments	Download
A	LayoutTests/imported/w3c/web-platform-tests/cssom-view/resources/iframe1.html	View	1 2 3 4 5	1 chunk	+16 lines, -0 lines	0 comments	Download
A	LayoutTests/imported/w3c/web-platform-tests/cssom-view/resources/iframe2.html	View	1 2 3 4 5	1 chunk	+25 lines, -0 lines	0 comments	Download
M	Source/WebCore/ChangeLog	View		1 chunk	+91 lines, -0 lines	0 comments	Download
M	Source/WebCore/dom/DocumentOrShadowRoot.idl	View	7 8 9 10 11 12	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/WebCore/dom/TreeScope.h	View	1 2 3 4 5 6 7 8 9 10 11 12	2 chunks	+3 lines, -1 line	0 comments	Download
M	Source/WebCore/dom/TreeScope.cpp	View	1 2 3 4 5 6 7 8 9 10 11 12	4 chunks	+86 lines, -22 lines	0 comments	Download
M	Source/WebCore/page/EventHandler.cpp	View	1 2 3 4 5 6 7 8 9 10 11 12	1 chunk	+2 lines, -0 lines	0 comments	Download
M	Source/WebCore/rendering/EllipsisBox.cpp	View	1 2 3 4 5 6 7 8 9 10 11 12	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/WebCore/rendering/HitTestRequest.h	View	1 2 3 4 5 6 7 8 9 10 11 12	4 chunks	+10 lines, -1 line	0 comments	Download
M	Source/WebCore/rendering/HitTestResult.h	View	1 2 3 4 5 6 7 8 9 10 11 12	4 chunks	+13 lines, -10 lines	0 comments	Download
M	Source/WebCore/rendering/HitTestResult.cpp	View	1 2 3 4 5 6 7 8 9 10 11 12	4 chunks	+42 lines, -36 lines	0 comments	Download
M	Source/WebCore/rendering/InlineFlowBox.cpp	View	1 2 3 4 5 6 7 8 9 10 11 12	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/WebCore/rendering/InlineTextBox.cpp	View	1 2 3 4 5 6 7 8 9 10 11 12	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/WebCore/rendering/RenderBlock.cpp	View	1 2 3 4 5 6 7 8 9 10 11 12	2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/WebCore/rendering/RenderBox.cpp	View	1 2 3 4 5 6 7 8 9 10 11 12	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/WebCore/rendering/RenderImage.cpp	View	1 2 3 4 5 6 7 8 9 10 11 12	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/WebCore/rendering/RenderInline.cpp	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/WebCore/rendering/RenderLayer.cpp	View	1 2 3 4 5 6 7 8 9 10 11 12	6 chunks	+22 lines, -20 lines	0 comments	Download
M	Source/WebCore/rendering/RenderTable.cpp	View	1 2 3 4 5 6 7 8 9 10 11 12	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/WebCore/rendering/RenderTableSection.cpp	View	1 2 3 4 5 6 7 8 9 10 11 12	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/WebCore/rendering/RenderWidget.cpp	View	1 2 3 4 5 6 7 8 9 10 11 12	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/WebCore/rendering/SimpleLineLayoutFunctions.cpp	View	1 2 3 4 5 6 7 8 9 10 11 12	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/WebCore/rendering/svg/RenderSVGContainer.cpp	View	1 2 3 4 5 6 7 8 9 10 11 12	2 chunks	+9 lines, -4 lines	0 comments	Download
M	Source/WebCore/rendering/svg/RenderSVGImage.cpp	View	1 2 3 4 5 6 7 8 9 10 11 12	2 chunks	+5 lines, -2 lines	0 comments	Download
M	Source/WebCore/rendering/svg/RenderSVGRoot.cpp	View	1 2 3 4 5 6 7 8 9 10 11 12	2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/WebCore/rendering/svg/RenderSVGShape.cpp	View	1 2 3 4 5 6 7 8 9 10 11 12	2 chunks	+3 lines, -1 line	0 comments	Download
M	Source/WebCore/rendering/svg/SVGInlineTextBox.cpp	View	1 2 3 4 5 6 7 8 9 10 11 12	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/WebCore/testing/Internals.cpp	View	1 2 3 4 5 6 7 8 9 10 11 12	2 chunks	+7 lines, -18 lines	0 comments	Download
M	Source/WebKit/ChangeLog	View		1 chunk	+17 lines, -0 lines	0 comments	Download
M	Source/WebKitLegacy/mac/ChangeLog	View	1 2 3 4 5 6 7 8 9 10 11 12	1 chunk	+18 lines, -0 lines	0 comments	Download
M	Tools/ChangeLog	View	1 2 3 4 5 6 7 8 9 10 11 12	1 chunk	+14 lines, -0 lines	0 comments	Download