Issue 317630043: [plaso] Refactored psort front-end to tool #160

Issue 317630043: [plaso] Refactored psort front-end to tool #160 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
6 years, 11 months ago by Joachim Metz

Modified:
6 years, 10 months ago

Reviewers:
jberggren

CC:
romaing, onager, kiddi, log2timeline-dev_googlegroups.com, aaronp

Visibility:
Public.

More Reviews

Description

[plaso] Refactored psort front-end to tool #160

Patch Set 1 : Refactored psort front-end to tool #160 #

Total comments: 2

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+659 lines, -1103 lines)			Patch
M	plaso/cli/extract_analyze_tool.py	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	plaso/cli/log2timeline_tool.py	View	12 chunks	+45 lines, -80 lines	0 comments	Download
M	plaso/cli/pinfo_tool.py	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	plaso/cli/psort_tool.py	View	17 chunks	+205 lines, -230 lines	0 comments	Download
M	plaso/cli/psteal_tool.py	View	11 chunks	+203 lines, -102 lines	0 comments	Download
M	plaso/cli/status_view.py	View	5 chunks	+182 lines, -0 lines	2 comments	Download
M	plaso/engine/engine.py	View	1 chunk	+2 lines, -1 line	0 comments	Download
D	plaso/frontend/analysis_frontend.py	View	1 chunk	+0 lines, -22 lines	0 comments	Download
D	plaso/frontend/extraction_frontend.py	View	1 chunk	+0 lines, -224 lines	0 comments	Download
D	plaso/frontend/psort.py	View	1 chunk	+0 lines, -325 lines	0 comments	Download
M	tests/cli/psort_tool.py	View	2 chunks	+6 lines, -2 lines	0 comments	Download
M	tests/cli/psteal_tool.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/cli/status_view.py	View	3 chunks	+13 lines, -6 lines	0 comments	Download
D	tests/frontend/extraction_frontend.py	View	1 chunk	+0 lines, -91 lines	0 comments	Download
D	tests/frontend/psort.py	View	1 chunk	+0 lines, -17 lines	0 comments	Download

Messages

Total messages: 8

Expand All Messages | Collapse All Messages

jberggren

LGTM just a small nit https://codereview.appspot.com/317630043/diff/80001/plaso/cli/status_view.py File plaso/cli/status_view.py (right): https://codereview.appspot.com/317630043/diff/80001/plaso/cli/status_view.py#newcode57 plaso/cli/status_view.py:57: """ Add Returns

6 years, 10 months ago (2017-06-21 03:24:04 UTC) #6

Joachim Metz

https://codereview.appspot.com/317630043/diff/80001/plaso/cli/status_view.py File plaso/cli/status_view.py (right): https://codereview.appspot.com/317630043/diff/80001/plaso/cli/status_view.py#newcode57 plaso/cli/status_view.py:57: """ On 2017/06/21 03:24:04, jberggren wrote: > Add Returns ...

6 years, 10 months ago (2017-06-21 04:26:47 UTC) #7

Joachim Metz

6 years, 10 months ago (2017-06-21 04:30:48 UTC) #8

Changes have been merged with master branch. To close the review and clean up
the feature branch you can run: python ./utils/review.py close cleanup3

Expand All Messages | Collapse All Messages