Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(368)

Issue 317550043: Slashed Half-flat and add. scales for Arabic music

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 11 months ago by amir130
Modified:
6 years, 11 months ago
Reviewers:
dak, thomasmorley651
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Slashed Half-flat and add. scales for Arabic music -Introduced a glyph list so that the slashed half-flat is used (always) instead of the mirrored one (the latter is never used for Arabic sheet music) -Added two scales (Maqamat) of major importance for Arabic music For arabic music score writing: -Introduced new glyph list, so that by default the slashed half-flat is used instead of the mirrored half-flat, which isn't used in Arabic score writing. This makes the use of the cumbersome \dwn symbol needless and obsolete -Added Hijaz and Hijaz-Kar maqamat

Patch Set 1 #

Total comments: 5

Patch Set 2 : removed trailing white spaces #

Total comments: 12

Patch Set 3 : fixed format issues #

Patch Set 4 : removed unnecessary comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+126 lines, -43 lines) Patch
M ly/arabic.ly View 1 2 3 5 chunks +126 lines, -43 lines 0 comments Download

Messages

Total messages: 10
dak
https://codereview.appspot.com/317550043/diff/1/ly/arabic.ly File ly/arabic.ly (right): https://codereview.appspot.com/317550043/diff/1/ly/arabic.ly#newcode28 ly/arabic.ly:28: Whitespace error? https://codereview.appspot.com/317550043/diff/1/ly/arabic.ly#newcode86 ly/arabic.ly:86: Whitespace error? https://codereview.appspot.com/317550043/diff/1/ly/arabic.ly#newcode88 ly/arabic.ly:88: Whitespace ...
6 years, 11 months ago (2017-04-24 18:09:59 UTC) #1
amir130
https://codereview.appspot.com/317550043/diff/1/ly/arabic.ly File ly/arabic.ly (right): https://codereview.appspot.com/317550043/diff/1/ly/arabic.ly#newcode88 ly/arabic.ly:88: On 2017/04/24 18:09:59, dak wrote: > Whitespace error? > ...
6 years, 11 months ago (2017-04-25 10:51:47 UTC) #2
dak
https://codereview.appspot.com/317550043/diff/1/ly/arabic.ly File ly/arabic.ly (right): https://codereview.appspot.com/317550043/diff/1/ly/arabic.ly#newcode88 ly/arabic.ly:88: On 2017/04/25 10:51:47, amir130 wrote: > On 2017/04/24 18:09:59, ...
6 years, 11 months ago (2017-04-25 11:57:11 UTC) #3
amir130
removed trailing white spaces
6 years, 11 months ago (2017-04-25 19:23:19 UTC) #4
thomasmorley651
Hi Amir, thanks a lot for your patch. I don't know anything about arabic music. ...
6 years, 11 months ago (2017-04-25 20:32:19 UTC) #5
dak
https://codereview.appspot.com/317550043/diff/20001/ly/arabic.ly File ly/arabic.ly (right): https://codereview.appspot.com/317550043/diff/20001/ly/arabic.ly#newcode19 ly/arabic.ly:19: \version "2.18.2" On 2017/04/25 20:32:19, thomasmorley651 wrote: > The ...
6 years, 11 months ago (2017-04-25 20:39:10 UTC) #6
thomasmorley651
https://codereview.appspot.com/317550043/diff/20001/ly/arabic.ly File ly/arabic.ly (right): https://codereview.appspot.com/317550043/diff/20001/ly/arabic.ly#newcode19 ly/arabic.ly:19: \version "2.18.2" On 2017/04/25 20:39:10, dak wrote: > On ...
6 years, 11 months ago (2017-04-25 22:29:36 UTC) #7
amir130
fixed format issues
6 years, 11 months ago (2017-04-26 20:09:53 UTC) #8
amir130
removed unnecessary comments
6 years, 11 months ago (2017-04-26 20:12:08 UTC) #9
amir130
6 years, 11 months ago (2017-04-26 20:12:35 UTC) #10
https://codereview.appspot.com/317550043/diff/20001/ly/arabic.ly
File ly/arabic.ly (right):

https://codereview.appspot.com/317550043/diff/20001/ly/arabic.ly#newcode42
ly/arabic.ly:42: % Ajam family
On 2017/04/25 20:32:19, thomasmorley651 wrote:
> There seems to be no entry for 'Ajam family'. Or is the 'Bayati family' a
subset
> of the 'Ajam family'?
> In any case I'd insert a comment to clearify.

Well Ajam is the Arabic name for major. I first thought to do something like
"ajam = \major" but then decided against it. However, there are other scales in
this family, but they are used seldom. I did not want to include ~100 scales
now.
So basically I left it for completeness and future changes. However, I'll delete
the comment

https://codereview.appspot.com/317550043/diff/20001/ly/arabic.ly#newcode87
ly/arabic.ly:87: % Nahawand family
On 2017/04/25 20:32:19, thomasmorley651 wrote:
> Same as above.

Same as above but this time it is minor
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b