Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(174)

Issue 316980043: Carrier Aggregation Feature (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 3 months ago by Biljana Bojović
Modified:
7 years, 1 month ago
CC:
--cc=ns-3-reviews_googlegroups.com
Visibility:
Public.

Description

Carrier Aggregation Feature

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+8518 lines, -832 lines) Patch
M src/core/model/make-event.h View 4 chunks +133 lines, -0 lines 0 comments Download
M src/core/model/simulator.h View 17 chunks +204 lines, -0 lines 0 comments Download
M src/lte/doc/Makefile View 3 chunks +19 lines, -2 lines 0 comments Download
A src/lte/doc/source/figures/CarrierAggregationDownlinkDataPlane.png View Binary file 0 comments Download
A src/lte/doc/source/figures/CarrierAggregationUlTxOpportunity.png View Binary file 0 comments Download
A src/lte/doc/source/figures/ca-downlink-bsr.seqdiag View 1 chunk +18 lines, -0 lines 0 comments Download
A src/lte/doc/source/figures/ca-enb-ctrl-plane.dia View Binary file 0 comments Download
A src/lte/doc/source/figures/ca-enb-data-plane.dia View Binary file 0 comments Download
A src/lte/doc/source/figures/ca-lte-enb-net-device-changes.dia View Binary file 0 comments Download
A src/lte/doc/source/figures/ca-lte-ue-net-device-changes.dia View Binary file 0 comments Download
A src/lte/doc/source/figures/ca-rrc-messages.png View Binary file 0 comments Download
A src/lte/doc/source/figures/ca-rrc-reconf.dia View Binary file 0 comments Download
A src/lte/doc/source/figures/ca-setup-radio-bearer.seqdiag View 1 chunk +18 lines, -0 lines 0 comments Download
A src/lte/doc/source/figures/ca-some-diagram.seqdiag View 1 chunk +17 lines, -0 lines 0 comments Download
A src/lte/doc/source/figures/ca-test-example-dl.png View Binary file 0 comments Download
A src/lte/doc/source/figures/ca-test-example-ul.png View Binary file 0 comments Download
A src/lte/doc/source/figures/ca-ue-ctrl-plane.dia View Binary file 0 comments Download
A src/lte/doc/source/figures/ca-ue-data-plane.dia View Binary file 0 comments Download
A src/lte/doc/source/figures/ca-uplink-bsr.seqdiag View 1 chunk +28 lines, -0 lines 0 comments Download
A src/lte/doc/source/figures/carrier-aggregation-impact.jpg View Binary file 0 comments Download
A src/lte/doc/source/figures/carrier-aggregation-impact.png View Binary file 0 comments Download
A src/lte/doc/source/figures/carrier-aggregation-mac-impact.jpg View Binary file 0 comments Download
A src/lte/doc/source/figures/carrier-aggregation-mac-impact.png View Binary file 0 comments Download
A src/lte/doc/source/figures/convert_workaround.sh View 1 chunk +21 lines, -0 lines 0 comments Download
M src/lte/doc/source/figures/helpers.pdf View Binary file 0 comments Download
M src/lte/doc/source/figures/helpers.png View Binary file 0 comments Download
A src/lte/doc/source/figures/lte-arch-enb-ctrl-rrc-phy.dia View Binary file 0 comments Download
A src/lte/doc/source/figures/lte-ccs-arch.dia View Binary file 0 comments Download
A src/lte/doc/source/figures/lte-ccs-arch.png View Binary file 0 comments Download
A src/lte/doc/source/figures/lte-class-net-phy-relation.dia View Binary file 0 comments Download
A src/lte/doc/source/figures/lte-enb-cphy-sap.png View Binary file 0 comments Download
A src/lte/doc/source/figures/lte-net-phy-relation.png View Binary file 0 comments Download
M src/lte/doc/source/figures/mac-random-access-contention.pdf View Binary file 0 comments Download
A src/lte/doc/source/figures/setupRadioBearerCarrierAggregation.png View Binary file 0 comments Download
M src/lte/doc/source/lte-design.rst View 10 chunks +436 lines, -31 lines 0 comments Download
M src/lte/doc/source/lte-testing.rst View 14 chunks +28 lines, -15 lines 0 comments Download
M src/lte/doc/source/lte-user.rst View 5 chunks +91 lines, -20 lines 2 comments Download
R src/lte/doc/source/rlc_buffer_status_report_downlink.seqdiag View 1 chunk +0 lines, -15 lines 0 comments Download
R src/lte/doc/source/rlc_buffer_status_report_uplink.seqdiag View 1 chunk +0 lines, -17 lines 0 comments Download
A src/lte/examples/lena-cc-helper.cc View 1 chunk +77 lines, -0 lines 0 comments Download
M src/lte/examples/lena-dual-stripe.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/lte/examples/lena-profiling.cc View 1 chunk +18 lines, -0 lines 0 comments Download
M src/lte/examples/lena-simple.cc View 2 chunks +12 lines, -0 lines 0 comments Download
M src/lte/examples/lena-simple-epc.cc View 2 chunks +9 lines, -0 lines 0 comments Download
M src/lte/examples/wscript View 1 chunk +3 lines, -0 lines 0 comments Download
A src/lte/helper/cc-helper.h View 1 chunk +138 lines, -0 lines 0 comments Download
A src/lte/helper/cc-helper.cc View 1 chunk +224 lines, -0 lines 0 comments Download
M src/lte/helper/lte-helper.h View 9 chunks +114 lines, -6 lines 0 comments Download
M src/lte/helper/lte-helper.cc View 21 chunks +498 lines, -200 lines 0 comments Download
M src/lte/helper/mac-stats-calculator.h View 5 chunks +12 lines, -15 lines 0 comments Download
M src/lte/helper/mac-stats-calculator.cc View 6 chunks +62 lines, -56 lines 0 comments Download
M src/lte/helper/phy-rx-stats-calculator.cc View 6 chunks +11 lines, -7 lines 0 comments Download
M src/lte/helper/phy-stats-calculator.h View 5 chunks +8 lines, -4 lines 0 comments Download
M src/lte/helper/phy-stats-calculator.cc View 8 chunks +18 lines, -15 lines 0 comments Download
M src/lte/helper/phy-tx-stats-calculator.cc View 6 chunks +11 lines, -7 lines 0 comments Download
A src/lte/model/component-carrier.h View 1 chunk +169 lines, -0 lines 0 comments Download
A src/lte/model/component-carrier.cc View 1 chunk +237 lines, -0 lines 0 comments Download
A src/lte/model/component-carrier-enb.h View 1 chunk +118 lines, -0 lines 0 comments Download
A src/lte/model/component-carrier-enb.cc View 1 chunk +176 lines, -0 lines 0 comments Download
A src/lte/model/component-carrier-ue.h View 1 chunk +87 lines, -0 lines 0 comments Download
A src/lte/model/component-carrier-ue.cc View 1 chunk +119 lines, -0 lines 0 comments Download
M src/lte/model/epc-ue-nas.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/lte/model/epc-ue-nas.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/lte/model/lte-as-sap.h View 4 chunks +6 lines, -6 lines 0 comments Download
M src/lte/model/lte-asn1-header.h View 2 chunks +18 lines, -0 lines 0 comments Download
M src/lte/model/lte-asn1-header.cc View 2 chunks +10 lines, -0 lines 0 comments Download
A src/lte/model/lte-ccm-mac-sap.h View 1 chunk +176 lines, -0 lines 0 comments Download
A src/lte/model/lte-ccm-mac-sap.cc View 1 chunk +37 lines, -0 lines 0 comments Download
A src/lte/model/lte-ccm-rrc-sap.h View 1 chunk +329 lines, -0 lines 0 comments Download
A src/lte/model/lte-ccm-rrc-sap.cc View 1 chunk +37 lines, -0 lines 0 comments Download
M src/lte/model/lte-common.h View 3 chunks +14 lines, -0 lines 0 comments Download
A src/lte/model/lte-enb-component-carrier-manager.h View 1 chunk +199 lines, -0 lines 0 comments Download
A src/lte/model/lte-enb-component-carrier-manager.cc View 1 chunk +136 lines, -0 lines 0 comments Download
M src/lte/model/lte-enb-cphy-sap.h View 4 chunks +4 lines, -3 lines 0 comments Download
M src/lte/model/lte-enb-mac.h View 10 chunks +68 lines, -11 lines 0 comments Download
M src/lte/model/lte-enb-mac.cc View 15 chunks +82 lines, -33 lines 0 comments Download
M src/lte/model/lte-enb-net-device.h View 7 chunks +52 lines, -14 lines 0 comments Download
M src/lte/model/lte-enb-net-device.cc View 13 chunks +65 lines, -26 lines 0 comments Download
M src/lte/model/lte-enb-phy.h View 3 chunks +4 lines, -4 lines 0 comments Download
M src/lte/model/lte-enb-phy.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M src/lte/model/lte-enb-rrc.h View 27 chunks +92 lines, -31 lines 0 comments Download
M src/lte/model/lte-enb-rrc.cc View 44 chunks +397 lines, -69 lines 0 comments Download
M src/lte/model/lte-mac-sap.h View 3 chunks +3 lines, -2 lines 0 comments Download
M src/lte/model/lte-phy.h View 3 chunks +7 lines, -2 lines 0 comments Download
M src/lte/model/lte-phy.cc View 2 chunks +15 lines, -1 line 0 comments Download
M src/lte/model/lte-rlc.h View 2 chunks +4 lines, -4 lines 0 comments Download
M src/lte/model/lte-rlc.cc View 6 chunks +11 lines, -8 lines 0 comments Download
M src/lte/model/lte-rlc-am.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/lte/model/lte-rlc-am.cc View 5 chunks +5 lines, -2 lines 0 comments Download
M src/lte/model/lte-rlc-tm.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/lte/model/lte-rlc-tm.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M src/lte/model/lte-rlc-um.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/lte/model/lte-rlc-um.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M src/lte/model/lte-rrc-header.h View 6 chunks +26 lines, -0 lines 0 comments Download
M src/lte/model/lte-rrc-header.cc View 16 chunks +713 lines, -9 lines 0 comments Download
M src/lte/model/lte-rrc-sap.h View 9 chunks +148 lines, -6 lines 0 comments Download
M src/lte/model/lte-spectrum-phy.h View 2 chunks +6 lines, -0 lines 0 comments Download
M src/lte/model/lte-spectrum-phy.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M src/lte/model/lte-spectrum-value-helper.h View 7 chunks +7 lines, -7 lines 0 comments Download
M src/lte/model/lte-spectrum-value-helper.cc View 10 chunks +15 lines, -14 lines 0 comments Download
A src/lte/model/lte-ue-ccm-rrc-sap.h View 1 chunk +191 lines, -0 lines 0 comments Download
A src/lte/model/lte-ue-ccm-rrc-sap.cc View 1 chunk +37 lines, -0 lines 0 comments Download
M src/lte/model/lte-ue-cmac-sap.h View 1 chunk +6 lines, -0 lines 0 comments Download
A src/lte/model/lte-ue-component-carrier-manager.h View 1 chunk +108 lines, -0 lines 0 comments Download
A src/lte/model/lte-ue-component-carrier-manager.cc View 1 chunk +84 lines, -0 lines 0 comments Download
M src/lte/model/lte-ue-cphy-sap.h View 8 chunks +10 lines, -9 lines 0 comments Download
M src/lte/model/lte-ue-mac.h View 3 chunks +6 lines, -0 lines 0 comments Download
M src/lte/model/lte-ue-mac.cc View 11 chunks +33 lines, -6 lines 0 comments Download
M src/lte/model/lte-ue-net-device.h View 8 chunks +26 lines, -3 lines 0 comments Download
M src/lte/model/lte-ue-net-device.cc View 11 chunks +56 lines, -13 lines 0 comments Download
M src/lte/model/lte-ue-phy.h View 5 chunks +11 lines, -9 lines 0 comments Download
M src/lte/model/lte-ue-phy.cc View 12 chunks +15 lines, -11 lines 0 comments Download
M src/lte/model/lte-ue-rrc.h View 16 chunks +104 lines, -14 lines 0 comments Download
M src/lte/model/lte-ue-rrc.cc View 34 chunks +295 lines, -63 lines 0 comments Download
A src/lte/model/no-op-component-carrier-manager.h View 1 chunk +112 lines, -0 lines 0 comments Download
A src/lte/model/no-op-component-carrier-manager.cc View 1 chunk +514 lines, -0 lines 0 comments Download
M src/lte/model/rr-ff-mac-scheduler.h View 1 chunk +4 lines, -0 lines 0 comments Download
A src/lte/model/simple-ue-component-carrier-manager.h View 1 chunk +98 lines, -0 lines 0 comments Download
A src/lte/model/simple-ue-component-carrier-manager.cc View 1 chunk +341 lines, -0 lines 0 comments Download
A src/lte/test/lte-test-carrier-aggregation.h View 1 chunk +82 lines, -0 lines 0 comments Download
A src/lte/test/lte-test-carrier-aggregation.cc View 1 chunk +478 lines, -0 lines 0 comments Download
M src/lte/test/lte-test-deactivate-bearer.h View 1 chunk +3 lines, -4 lines 0 comments Download
M src/lte/test/lte-test-entities.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M src/lte/test/lte-test-interference-fr.h View 2 chunks +3 lines, -0 lines 0 comments Download
M src/lte/test/lte-test-interference-fr.cc View 2 chunks +4 lines, -1 line 0 comments Download
M src/lte/test/lte-test-ue-measurements.h View 1 chunk +1 line, -1 line 0 comments Download
M src/lte/test/lte-test-ue-measurements.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M src/lte/test/test-asn1-encoding.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M src/lte/wscript View 3 chunks +25 lines, -2 lines 0 comments Download
M src/test/traced/traced-callback-typedef-test-suite.cc View 2 chunks +12 lines, -6 lines 2 comments Download

Messages

Total messages: 4
Peter Barnes
This review comment applies to src/core/model/make-event.h and simulator.h only. These files are modified so MakeEvent() ...
7 years, 2 months ago (2017-01-13 19:16:54 UTC) #1
Tom Henderson
I did not review all of the patch but I suggest to proceed; I realize ...
7 years, 2 months ago (2017-01-15 23:54:41 UTC) #2
Biljana Bojović
On 2017/01/13 19:16:54, Peter Barnes wrote: > This review comment applies to src/core/model/make-event.h and simulator.h ...
7 years, 1 month ago (2017-02-02 14:32:35 UTC) #3
Biljana Bojović
7 years, 1 month ago (2017-02-02 14:34:06 UTC) #4
Thanks for reviews.

https://codereview.appspot.com/316980043/diff/1/src/lte/doc/source/lte-user.rst
File src/lte/doc/source/lte-user.rst (right):

https://codereview.appspot.com/316980043/diff/1/src/lte/doc/source/lte-user.r...
src/lte/doc/source/lte-user.rst:2433: establishment procedure, by enabling the
log components LteUeRrc and LteEnbRrc
On 2017/01/15 23:54:41, Tom Henderson wrote:
> see below, the word 'components' is misspelled also

Fixed.

https://codereview.appspot.com/316980043/diff/1/src/test/traced/traced-callba...
File src/test/traced/traced-callback-typedef-test-suite.cc (right):

https://codereview.appspot.com/316980043/diff/1/src/test/traced/traced-callba...
src/test/traced/traced-callback-typedef-test-suite.cc:475: /*  Too many args :(
On 2017/01/15 23:54:41, Tom Henderson wrote:
> Can you fix this, though?  You have already expanded Schedule() and
MakeEvent().

In some cases I could fix, but in other not. Because, now there is usually one
more input argument for carrier Id, so again in some cases there is too many
args.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b