Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1292)

Issue 316530043: [dfdatetime] Updated utility scripts (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 11 months ago by Joachim Metz
Modified:
6 years, 11 months ago
Reviewers:
onager
CC:
kiddi, log2timeline-dev_googlegroups.com
Visibility:
Public.

Description

[dfdatetime] Updated utility scripts

Patch Set 1 #

Total comments: 2

Patch Set 2 : Updated utility scripts #

Unified diffs Side-by-side diffs Delta from patch set Stats (+529 lines, -110 lines) Patch
M .travis.yml View 1 chunk +5 lines, -3 lines 0 comments Download
M appveyor.yml View 1 chunk +11 lines, -0 lines 0 comments Download
M config/dpkg/control View 2 chunks +2 lines, -3 lines 0 comments Download
M config/travis/install.sh View 1 1 chunk +23 lines, -2 lines 0 comments Download
M requirements.txt View 1 chunk +1 line, -0 lines 0 comments Download
M setup.cfg View 1 chunk +2 lines, -2 lines 0 comments Download
M utils/review.py View 44 chunks +198 lines, -100 lines 0 comments Download
A utils/update_dependencies.py View 1 1 chunk +287 lines, -0 lines 0 comments Download

Messages

Total messages: 7
Joachim Metz
6 years, 11 months ago (2017-04-19 20:37:32 UTC) #1
Joachim Metz
https://codereview.appspot.com/316530043/diff/1/config/travis/install.sh File config/travis/install.sh (right): https://codereview.appspot.com/316530043/diff/1/config/travis/install.sh#newcode25 config/travis/install.sh:25: PYTHONPATH=../l2tdevtools ../l2tdevtools/tools/update.py --download-directory=dependencies --preset=dfdatetime; switch from preset to individual ...
6 years, 11 months ago (2017-04-19 20:54:30 UTC) #2
Joachim Metz
Code updated.
6 years, 11 months ago (2017-04-21 03:43:15 UTC) #3
Joachim Metz
https://codereview.appspot.com/316530043/diff/1/config/travis/install.sh File config/travis/install.sh (right): https://codereview.appspot.com/316530043/diff/1/config/travis/install.sh#newcode25 config/travis/install.sh:25: PYTHONPATH=../l2tdevtools ../l2tdevtools/tools/update.py --download-directory=dependencies --preset=dfdatetime; On 2017/04/19 20:54:30, Joachim Metz ...
6 years, 11 months ago (2017-04-21 03:43:47 UTC) #4
Joachim Metz
Code updated.
6 years, 11 months ago (2017-04-21 03:56:48 UTC) #5
onager
On 2017/04/21 03:56:48, Joachim Metz wrote: > Code updated. LGTM
6 years, 11 months ago (2017-04-21 06:49:53 UTC) #6
Joachim Metz
6 years, 11 months ago (2017-04-22 09:55:33 UTC) #7
Changes have been merged with master branch. To close the review and clean up
the feature branch you can run: python ./utils/review.py close utils
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b