Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(39)

Issue 316460043: [plaso] Added database schema matching to sqlite plugins #1093

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 weeks ago by Joachim Metz
Modified:
5 days, 16 hours ago
CC:
kiddi, log2timeline-dev_googlegroups.com
Visibility:
Public.

Description

[plaso] Added database schema matching to sqlite plugins #1093

Patch Set 1 #

Total comments: 14

Patch Set 2 : Clean up of SQLite schema extract script #

Total comments: 4

Patch Set 3 : Changes after review #

Total comments: 34

Patch Set 4 : Changes after review #

Patch Set 5 : Changes to schema extractor script #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+1349 lines, -57 lines) Patch
M plaso/engine/worker.py View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M plaso/parsers/mediator.py View 1 2 3 2 chunks +20 lines, -6 lines 2 comments Download
M plaso/parsers/sqlite.py View 1 2 3 7 chunks +27 lines, -10 lines 0 comments Download
M plaso/parsers/sqlite_plugins/android_calls.py View 1 2 3 1 chunk +103 lines, -0 lines 1 comment Download
M plaso/parsers/sqlite_plugins/android_sms.py View 1 chunk +71 lines, -0 lines 0 comments Download
M plaso/parsers/sqlite_plugins/android_webview.py View 1 chunk +19 lines, -0 lines 0 comments Download
M plaso/parsers/sqlite_plugins/android_webviewcache.py View 1 chunk +10 lines, -0 lines 0 comments Download
M plaso/parsers/sqlite_plugins/appusage.py View 1 chunk +6 lines, -0 lines 0 comments Download
M plaso/parsers/sqlite_plugins/chrome.py View 1 chunk +36 lines, -0 lines 0 comments Download
M plaso/parsers/sqlite_plugins/chrome_cookies.py View 1 chunk +11 lines, -0 lines 0 comments Download
M plaso/parsers/sqlite_plugins/chrome_extension_activity.py View 1 chunk +12 lines, -0 lines 0 comments Download
M plaso/parsers/sqlite_plugins/firefox.py View 3 chunks +105 lines, -0 lines 0 comments Download
M plaso/parsers/sqlite_plugins/firefox_cookies.py View 1 chunk +9 lines, -0 lines 0 comments Download
M plaso/parsers/sqlite_plugins/gdrive.py View 1 chunk +31 lines, -0 lines 0 comments Download
M plaso/parsers/sqlite_plugins/imessage.py View 1 chunk +63 lines, -0 lines 0 comments Download
M plaso/parsers/sqlite_plugins/interface.py View 1 2 3 5 chunks +126 lines, -42 lines 0 comments Download
M plaso/parsers/sqlite_plugins/kik_ios.py View 1 chunk +59 lines, -0 lines 0 comments Download
M plaso/parsers/sqlite_plugins/ls_quarantine.py View 1 chunk +10 lines, -0 lines 0 comments Download
M plaso/parsers/sqlite_plugins/mac_document_versions.py View 1 chunk +19 lines, -0 lines 0 comments Download
M plaso/parsers/sqlite_plugins/mackeeper_cache.py View 1 chunk +16 lines, -0 lines 0 comments Download
M plaso/parsers/sqlite_plugins/skype.py View 1 chunk +271 lines, -0 lines 0 comments Download
M plaso/parsers/sqlite_plugins/twitter_ios.py View 1 chunk +78 lines, -0 lines 0 comments Download
M plaso/parsers/sqlite_plugins/zeitgeist.py View 1 chunk +56 lines, -0 lines 0 comments Download
M test_data/wal_database.db-wal View 0 chunks +-1 lines, --1 lines 0 comments Download
M tests/parsers/sqlite_plugins/interface.py View 4 chunks +66 lines, -0 lines 0 comments Download
A utils/schema_extractor.py View 1 2 3 4 1 chunk +124 lines, -0 lines 1 comment Download

Messages

Total messages: 15
Joachim Metz
3 weeks ago (2017-04-08 18:44:11 UTC) #1
Joachim Metz
for review this WIP to migrate https://codereview.appspot.com/319750043/
3 weeks ago (2017-04-08 18:45:40 UTC) #2
Joachim Metz
https://codereview.appspot.com/316460043/diff/1/plaso/parsers/mediator.py File plaso/parsers/mediator.py (right): https://codereview.appspot.com/316460043/diff/1/plaso/parsers/mediator.py#newcode501 plaso/parsers/mediator.py:501: def RemoveEventAttribute(self, attribute_name): note to self, what is the ...
3 weeks ago (2017-04-08 18:52:44 UTC) #3
Joachim Metz
Code updated.
2 weeks, 6 days ago (2017-04-09 12:54:47 UTC) #4
Joachim Metz
https://codereview.appspot.com/316460043/diff/1/plaso/parsers/mediator.py File plaso/parsers/mediator.py (right): https://codereview.appspot.com/316460043/diff/1/plaso/parsers/mediator.py#newcode501 plaso/parsers/mediator.py:501: def RemoveEventAttribute(self, attribute_name): Added reminder to https://github.com/log2timeline/plaso/issues/771 to see ...
2 weeks, 6 days ago (2017-04-09 12:59:04 UTC) #5
dc3.plaso
https://codereview.appspot.com/316460043/diff/1/plaso/parsers/sqlite.py File plaso/parsers/sqlite.py (right): https://codereview.appspot.com/316460043/diff/1/plaso/parsers/sqlite.py#newcode106 plaso/parsers/sqlite.py:106: self.schema = {} On 2017/04/08 18:52:44, Joachim Metz wrote: ...
2 weeks, 5 days ago (2017-04-10 17:32:55 UTC) #6
Joachim Metz
https://codereview.appspot.com/316460043/diff/1/plaso/parsers/sqlite.py File plaso/parsers/sqlite.py (right): https://codereview.appspot.com/316460043/diff/1/plaso/parsers/sqlite.py#newcode106 plaso/parsers/sqlite.py:106: self.schema = {} Thx, agree Python does not need ...
2 weeks, 5 days ago (2017-04-10 18:57:23 UTC) #7
Joachim Metz
Code updated.
2 weeks, 4 days ago (2017-04-11 04:56:53 UTC) #8
onager
https://codereview.appspot.com/316460043/diff/40001/plaso/parsers/mediator.py File plaso/parsers/mediator.py (left): https://codereview.appspot.com/316460043/diff/40001/plaso/parsers/mediator.py#oldcode207 plaso/parsers/mediator.py:207: KeyError: If an attribute with the given name is ...
2 weeks, 3 days ago (2017-04-12 19:42:02 UTC) #9
mrtegg
2 weeks, 2 days ago (2017-04-13 20:51:00 UTC) #10
Joachim Metz
https://codereview.appspot.com/316460043/diff/40001/plaso/parsers/mediator.py File plaso/parsers/mediator.py (left): https://codereview.appspot.com/316460043/diff/40001/plaso/parsers/mediator.py#oldcode207 plaso/parsers/mediator.py:207: KeyError: If an attribute with the given name is ...
1 week, 3 days ago (2017-04-19 19:18:25 UTC) #11
Joachim Metz
Code updated.
1 week, 3 days ago (2017-04-19 20:52:41 UTC) #12
Joachim Metz
Code updated.
1 week, 3 days ago (2017-04-19 21:16:29 UTC) #13
Joachim Metz
https://codereview.appspot.com/316460043/diff/80001/utils/schema_extractor.py File utils/schema_extractor.py (right): https://codereview.appspot.com/316460043/diff/80001/utils/schema_extractor.py#newcode121 utils/schema_extractor.py:121: #pyperclip.copy(database_schema) fix this in final touch up
1 week, 2 days ago (2017-04-20 05:36:25 UTC) #14
onager
5 days, 16 hours ago (2017-04-24 06:36:25 UTC) #15
https://codereview.appspot.com/316460043/diff/80001/plaso/parsers/mediator.py
File plaso/parsers/mediator.py (right):

https://codereview.appspot.com/316460043/diff/80001/plaso/parsers/mediator.py...
plaso/parsers/mediator.py:207: KeyError: if the event attribute with is already
set.
-with

https://codereview.appspot.com/316460043/diff/80001/plaso/parsers/mediator.py...
plaso/parsers/mediator.py:515: KeyError: if the event attribute with is not set.
-with

https://codereview.appspot.com/316460043/diff/80001/plaso/parsers/sqlite_plug...
File plaso/parsers/sqlite_plugins/android_calls.py (right):

https://codereview.appspot.com/316460043/diff/80001/plaso/parsers/sqlite_plug...
plaso/parsers/sqlite_plugins/android_calls.py:51: u'_sync_state': (
This is much more readable - please go ahead and apply it to the other parsers.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 80a51fa-tainted