Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(218)

Issue 316360043: Allow number as MarkEvent.label (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years ago by dak
Modified:
5 years, 8 months ago
Reviewers:
lemzwerg
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Allow number as MarkEvent.label This puts all Mark counter handling in the hand of the Mark_engraver . Interestingly, Mark_engraver itself already was perfectly equipped to dealing with that, but the `label' property did not yet accept numbers. Also contains commits: More \mark tests for \displayLilyMusic Let \displayLilyMusic accept numbered marks Let \mark warnings show input location

Patch Set 1 #

Patch Set 2 : Simplify \mark display, value->lily-string #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -24 lines) Patch
M input/regression/display-lily-tests.ly View 1 chunk +3 lines, -0 lines 0 comments Download
M lily/mark-engraver.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M ly/music-functions-init.ly View 1 chunk +5 lines, -14 lines 0 comments Download
M scm/define-music-display-methods.scm View 1 2 chunks +3 lines, -6 lines 0 comments Download
M scm/define-music-properties.scm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2
lemzwerg
LGTM
7 years ago (2017-03-24 04:53:32 UTC) #1
dak
7 years ago (2017-03-24 09:09:44 UTC) #2
Simplify \mark display, value->lily-string
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b