Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1375)
Issues Repositories Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 316120043: [dfvfs] Update docstrings to new style #76 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 3 months ago by Joachim Metz
Modified:
7 years, 3 months ago
Reviewers:
jberggren, romaing, onager
CC:
kiddi, log2timeline-dev_googlegroups.com
Visibility:
Public.

Description

[dfvfs] Update docstrings to new style #76

Patch Set 1 #

Total comments: 28

Patch Set 2 : Update docstrings to new style #76 #

Total comments: 6
Unified diffs Side-by-side diffs Delta from patch set Stats (+392 lines, -286 lines) Patch
M dfvfs/compression/bzip2_decompressor.py View 1 chunk +1 line, -1 line 0 comments Download
M dfvfs/compression/decompressor.py View 1 chunk +1 line, -1 line 0 comments Download
M dfvfs/compression/xz_decompressor.py View 1 chunk +1 line, -1 line 0 comments Download
M dfvfs/compression/zlib_decompressor.py View 1 chunk +1 line, -1 line 0 comments Download
M dfvfs/encoding/base16_decoder.py View 1 chunk +1 line, -1 line 0 comments Download
M dfvfs/encoding/base32_decoder.py View 1 chunk +1 line, -1 line 0 comments Download
M dfvfs/encoding/base64_decoder.py View 1 chunk +1 line, -1 line 0 comments Download
M dfvfs/encoding/decoder.py View 1 chunk +1 line, -1 line 0 comments Download
M dfvfs/file_io/bde_file_io.py View 1 chunk +1 line, -1 line 0 comments Download
M dfvfs/file_io/compressed_stream_io.py View 1 9 chunks +33 lines, -19 lines 0 comments Download
M dfvfs/file_io/cpio_file_io.py View 1 6 chunks +18 lines, -12 lines 0 comments Download
M dfvfs/file_io/data_range_io.py View 1 8 chunks +26 lines, -20 lines 0 comments Download
M dfvfs/file_io/encoded_stream_io.py View 1 10 chunks +34 lines, -20 lines 0 comments Download
M dfvfs/file_io/encrypted_stream_io.py View 1 3 chunks +3 lines, -3 lines 2 comments Download
M dfvfs/file_io/ewf_file_io.py View 1 3 chunks +8 lines, -5 lines 0 comments Download
M dfvfs/file_io/fake_file_io.py View 1 6 chunks +16 lines, -13 lines 0 comments Download
M dfvfs/file_io/file_io.py View 1 2 chunks +2 lines, -2 lines 0 comments Download
M dfvfs/file_io/file_object_io.py View 1 7 chunks +21 lines, -15 lines 2 comments Download
M dfvfs/file_io/fvde_file_io.py View 1 1 chunk +1 line, -1 line 0 comments Download
M dfvfs/file_io/gzip_file_io.py View 1 4 chunks +6 lines, -6 lines 0 comments Download
M dfvfs/file_io/lvm_file_io.py View 1 6 chunks +17 lines, -14 lines 2 comments Download
M dfvfs/file_io/ntfs_file_io.py View 1 6 chunks +18 lines, -12 lines 0 comments Download
M dfvfs/file_io/os_file_io.py View 1 6 chunks +18 lines, -12 lines 0 comments Download
M dfvfs/file_io/qcow_file_io.py View 1 2 chunks +6 lines, -3 lines 0 comments Download
M dfvfs/file_io/raw_file_io.py View 1 3 chunks +8 lines, -5 lines 0 comments Download
M dfvfs/file_io/sqlite_blob_file_io.py View 1 7 chunks +19 lines, -13 lines 0 comments Download
M dfvfs/file_io/tar_file_io.py View 1 6 chunks +18 lines, -12 lines 0 comments Download
M dfvfs/file_io/tsk_file_io.py View 1 6 chunks +18 lines, -12 lines 0 comments Download
M dfvfs/file_io/tsk_partition_file_io.py View 2 chunks +3 lines, -3 lines 0 comments Download
M dfvfs/file_io/vhdi_file_io.py View 1 4 chunks +10 lines, -8 lines 0 comments Download
M dfvfs/file_io/vmdk_file_io.py View 1 2 chunks +6 lines, -3 lines 0 comments Download
M dfvfs/file_io/vshadow_file_io.py View 1 6 chunks +18 lines, -12 lines 0 comments Download
M dfvfs/file_io/zip_file_io.py View 1 8 chunks +20 lines, -14 lines 0 comments Download
M dfvfs/helpers/text_file.py View 1 1 chunk +2 lines, -2 lines 0 comments Download
M dfvfs/resolver/context.py View 1 15 chunks +34 lines, -36 lines 0 comments Download

Messages

Total messages: 7
Joachim Metz
7 years, 3 months ago (2017-01-08 05:39:11 UTC) #1
onager
https://codereview.appspot.com/316120043/diff/1/dfvfs/file_io/compressed_stream_io.py File dfvfs/file_io/compressed_stream_io.py (right): https://codereview.appspot.com/316120043/diff/1/dfvfs/file_io/compressed_stream_io.py#newcode266 dfvfs/file_io/compressed_stream_io.py:266: """Seeks an offset within the file-like object. "Seeks to ...
7 years, 3 months ago (2017-01-13 12:01:39 UTC) #2
Joachim Metz
https://codereview.appspot.com/316120043/diff/1/dfvfs/file_io/compressed_stream_io.py File dfvfs/file_io/compressed_stream_io.py (right): https://codereview.appspot.com/316120043/diff/1/dfvfs/file_io/compressed_stream_io.py#newcode266 dfvfs/file_io/compressed_stream_io.py:266: """Seeks an offset within the file-like object. On 2017/01/13 ...
7 years, 3 months ago (2017-01-15 09:04:06 UTC) #3
Joachim Metz
Code updated.
7 years, 3 months ago (2017-01-15 09:05:07 UTC) #4
onager
A few suggestions, but LGTM as it's just docstring changes. https://codereview.appspot.com/316120043/diff/20001/dfvfs/file_io/encrypted_stream_io.py File dfvfs/file_io/encrypted_stream_io.py (right): https://codereview.appspot.com/316120043/diff/20001/dfvfs/file_io/encrypted_stream_io.py#newcode332 ...
7 years, 3 months ago (2017-01-16 14:51:28 UTC) #5
Joachim Metz
https://codereview.appspot.com/316120043/diff/20001/dfvfs/file_io/encrypted_stream_io.py File dfvfs/file_io/encrypted_stream_io.py (right): https://codereview.appspot.com/316120043/diff/20001/dfvfs/file_io/encrypted_stream_io.py#newcode332 dfvfs/file_io/encrypted_stream_io.py:332: """Retrieves the current offset into the file-like object. On ...
7 years, 3 months ago (2017-01-16 18:24:56 UTC) #6
Joachim Metz
7 years, 3 months ago (2017-01-16 18:27:03 UTC) #7 
Changes have been merged with master branch. To close the review and clean up
the feature branch you can run: python ./utils/review.py close docstring1
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b