[plaso] Add JSON output to pinfo

[plaso] Add JSON output to pinfo

[Joachim Metz, 2017-01-17 07:15:08]

https://codereview.appspot.com/315980043/diff/1/tools/pinfo.py
File tools/pinfo.py (right):

https://codereview.appspot.com/315980043/diff/1/tools/pinfo.py#newcode403
tools/pinfo.py:403: def _PrintStorageInformationText(self, storage):
Text => AsText

https://codereview.appspot.com/315980043/diff/1/tools/pinfo.py#newcode404
tools/pinfo.py:404: """Prints information about the storage in a human-readable
form.
in a human-readable form => as human-readable text

https://codereview.appspot.com/315980043/diff/1/tools/pinfo.py#newcode446
tools/pinfo.py:446: def _PrintStorageInformationJSON(self, storage):
JSON => AsJSON

https://codereview.appspot.com/315980043/diff/1/tools/pinfo.py#newcode447
tools/pinfo.py:447: """Writes a summary of sessions as JSON.
as JSON => as machine-readable JSON

https://codereview.appspot.com/315980043/diff/1/tools/pinfo.py#newcode457
tools/pinfo.py:457: session.identifier, json_string))
shouldn't there be a comma after every session?

https://codereview.appspot.com/315980043/diff/1/tools/pinfo.py#newcode542
tools/pinfo.py:542: u'--output', dest=u'output_mode', type=str,
--output => --output-format and --output_format 

I opt to rename to output format instead of output mode

https://codereview.appspot.com/315980043/diff/1/tools/pinfo.py#newcode543
tools/pinfo.py:543: choices=[u'text', u'json'], action=u'store',
default=u'text',
=> u'json', u'text'

https://codereview.appspot.com/315980043/diff/1/tools/pinfo.py#newcode611
tools/pinfo.py:611: if self._output_mode == u'json':
to keep this try concise consider having a single call to 

self._PrintStorageInformation(storage_file)

that contains the output format check and calls _PrintStorageInformationAsJSON
and _PrintStorageInformationAsText

https://codereview.appspot.com/315980043/diff/1/tools/pinfo.py#newcode617
tools/pinfo.py:617: 
+ white line

https://codereview.appspot.com/315980043/diff/1/tools/pinfo_test.py
File tools/pinfo_test.py (right):

https://codereview.appspot.com/315980043/diff/1/tools/pinfo_test.py#newcode29
tools/pinfo_test.py:29: # TODO: add test for _PrintSessionsOverview.
+ # TODO: add test for _PrintStorageInformationAsText.

https://codereview.appspot.com/315980043/diff/1/tools/pinfo_test.py#newcode214
tools/pinfo_test.py:214: def testWriteStorageInformationAsJSON(self):
testWriteStorageInformationAsJSON => testPrintStorageInformationAsJSON

https://codereview.appspot.com/315980043/diff/1/tools/pinfo_test.py#newcode215
tools/pinfo_test.py:215: """Tests the PrintStorageInformation function."""
PrintStorageInformation => PrintStorageInformationAsJSON

[onager, 2017-01-24 13:58:02]

Code updated.

[onager, 2017-01-24 13:58:11]

https://codereview.appspot.com/315980043/diff/1/tools/pinfo.py
File tools/pinfo.py (right):

https://codereview.appspot.com/315980043/diff/1/tools/pinfo.py#newcode403
tools/pinfo.py:403: def _PrintStorageInformationText(self, storage):
On 2017/01/17 07:15:08, Joachim Metz wrote:
> Text => AsText

Done.

https://codereview.appspot.com/315980043/diff/1/tools/pinfo.py#newcode404
tools/pinfo.py:404: """Prints information about the storage in a human-readable
form.
On 2017/01/17 07:15:08, Joachim Metz wrote:
> in a human-readable form => as human-readable text

Done.

https://codereview.appspot.com/315980043/diff/1/tools/pinfo.py#newcode446
tools/pinfo.py:446: def _PrintStorageInformationJSON(self, storage):
On 2017/01/17 07:15:08, Joachim Metz wrote:
> JSON => AsJSON

Done.

https://codereview.appspot.com/315980043/diff/1/tools/pinfo.py#newcode447
tools/pinfo.py:447: """Writes a summary of sessions as JSON.
On 2017/01/17 07:15:08, Joachim Metz wrote:
> as JSON => as machine-readable JSON

Done.

https://codereview.appspot.com/315980043/diff/1/tools/pinfo.py#newcode457
tools/pinfo.py:457: session.identifier, json_string))
On 2017/01/17 07:15:07, Joachim Metz wrote:
> shouldn't there be a comma after every session?

Done.

https://codereview.appspot.com/315980043/diff/1/tools/pinfo.py#newcode542
tools/pinfo.py:542: u'--output', dest=u'output_mode', type=str,
On 2017/01/17 07:15:07, Joachim Metz wrote:
> --output => --output-format and --output_format 
> 
> I opt to rename to output format instead of output mode

Done.

https://codereview.appspot.com/315980043/diff/1/tools/pinfo.py#newcode543
tools/pinfo.py:543: choices=[u'text', u'json'], action=u'store',
default=u'text',
On 2017/01/17 07:15:08, Joachim Metz wrote:
> => u'json', u'text'

Done.

https://codereview.appspot.com/315980043/diff/1/tools/pinfo.py#newcode611
tools/pinfo.py:611: if self._output_mode == u'json':
On 2017/01/17 07:15:07, Joachim Metz wrote:
> to keep this try concise consider having a single call to 
> 
> self._PrintStorageInformation(storage_file)
> 
> that contains the output format check and calls _PrintStorageInformationAsJSON
> and _PrintStorageInformationAsText

Acknowledged.

https://codereview.appspot.com/315980043/diff/1/tools/pinfo.py#newcode617
tools/pinfo.py:617: 
On 2017/01/17 07:15:08, Joachim Metz wrote:
> + white line

Done.

https://codereview.appspot.com/315980043/diff/1/tools/pinfo_test.py
File tools/pinfo_test.py (right):

https://codereview.appspot.com/315980043/diff/1/tools/pinfo_test.py#newcode29
tools/pinfo_test.py:29: # TODO: add test for _PrintSessionsOverview.
On 2017/01/17 07:15:08, Joachim Metz wrote:
> + # TODO: add test for _PrintStorageInformationAsText.

Done.

https://codereview.appspot.com/315980043/diff/1/tools/pinfo_test.py#newcode214
tools/pinfo_test.py:214: def testWriteStorageInformationAsJSON(self):
On 2017/01/17 07:15:08, Joachim Metz wrote:
> testWriteStorageInformationAsJSON => testPrintStorageInformationAsJSON

Done.

https://codereview.appspot.com/315980043/diff/1/tools/pinfo_test.py#newcode215
tools/pinfo_test.py:215: """Tests the PrintStorageInformation function."""
On 2017/01/17 07:15:08, Joachim Metz wrote:
> PrintStorageInformation => PrintStorageInformationAsJSON

Done.

[Joachim Metz, 2017-02-06 07:24:13]

LGTM, one small style comment

https://codereview.appspot.com/315980043/diff/20001/tools/pinfo.py
File tools/pinfo.py (right):

https://codereview.appspot.com/315980043/diff/20001/tools/pinfo.py#newcode456
tools/pinfo.py:456: for session in storage.GetSessions():
try the following:

for index, session in enumerate(storage.GetSessions()):

[onager, 2017-02-14 14:05:25]

Code updated.

[onager, 2017-02-14 14:09:10]

Changes have been merged with master branch. To close the review and clean up
the feature branch you can run: python ./utils/review.py close parse_pinfo