Issue 315530043: [plaso] Add possibility for Shield authentication with Elasticsearch output

Issue 315530043: [plaso] Add possibility for Shield authentication with Elasticsearch output (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
7 years, 2 months ago by benoit.sevens

Modified:
7 years, 2 months ago

Reviewers:
Joachim Metz, jberggren, romaing, onager

CC:
kiddi, log2timeline-dev_googlegroups.com

Visibility:
Public.

More Reviews

Description

[plaso] Add possibility for Shield authentication with Elasticsearch output

Patch Set 2 : Move Elasticsearch password request to CLI helper #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+55 lines, -5 lines)			Patch
M	plaso/cli/helpers/elastic_output.py	View	1	4 chunks	+16 lines, -0 lines	0 comments	Download
M	plaso/output/elastic.py	View	1	5 chunks	+32 lines, -3 lines	0 comments	Download
M	tests/cli/helpers/elastic_output.py	View		1 chunk	+5 lines, -1 line	0 comments	Download
M	tests/output/elastic.py	View	1	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 9

Expand All Messages | Collapse All Messages

Joachim Metz

https://codereview.appspot.com/315530043/diff/1/plaso/output/elastic.py File plaso/output/elastic.py (right): https://codereview.appspot.com/315530043/diff/1/plaso/output/elastic.py#newcode47 plaso/output/elastic.py:47: password = getpass.getpass("Enter your Elasticsearch password: ") IMO this ...

7 years, 2 months ago (2017-02-04 06:50:49 UTC) #2

Joachim Metz

Changes have been merged with master branch. To close the review and clean up the ...

7 years, 2 months ago (2017-02-05 16:21:59 UTC) #6

benoit.sevens

On 2017/02/05 16:21:59, Joachim Metz wrote: > Changes have been merged with master branch. To ...

7 years, 2 months ago (2017-02-05 19:07:20 UTC) #7

onager

On 2017/02/05 19:07:20, benoit.sevens wrote: > On 2017/02/05 16:21:59, Joachim Metz wrote: > > Changes ...

7 years, 2 months ago (2017-02-14 14:37:53 UTC) #8

benoit.sevens

7 years, 2 months ago (2017-02-21 17:00:46 UTC) #9

Message was sent while issue was closed.

https://codereview.appspot.com/315530043/diff/1/plaso/output/elastic.py
File plaso/output/elastic.py (right):

https://codereview.appspot.com/315530043/diff/1/plaso/output/elastic.py#newco...
plaso/output/elastic.py:47: password = getpass.getpass("Enter your Elasticsearch
password: ")
On 2017/02/04 06:50:49, Joachim Metz wrote:
> IMO this does not belong here, shouldn't the cli helper get the password?

Acknowledged.

https://codereview.appspot.com/315530043/diff/1/plaso/output/elastic.py#newco...
plaso/output/elastic.py:47: password = getpass.getpass("Enter your Elasticsearch
password: ")
On 2017/02/04 06:50:49, Joachim Metz wrote:
> IMO this does not belong here, shouldn't the cli helper get the password?

Done.

https://codereview.appspot.com/315530043/diff/1/plaso/output/elastic.py#newco...
plaso/output/elastic.py:258: elastic_user (str): The Elastic user to
authenticate with.
On 2017/02/04 06:50:49, Joachim Metz wrote:
> - The

Acknowledged.

https://codereview.appspot.com/315530043/diff/1/plaso/output/elastic.py#newco...
plaso/output/elastic.py:258: elastic_user (str): The Elastic user to
authenticate with.
On 2017/02/04 06:50:49, Joachim Metz wrote:
> - The

Done.

Expand All Messages | Collapse All Messages