Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(268)

Issue 315420043: DecimalFormat rewrite, Java

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 months ago by sffc
Modified:
5 months, 3 weeks ago
Base URL:
svn+icussh://source.icu-project.org/repos/icu/branches/shane/numberformat/
Visibility:
Public.

Description

DecimalFormat rewrite, Java

Patch Set 1 #

Total comments: 57

Patch Set 2 : Fixed most unit test failures. Overhauled parser to support custom affixes with currency. Added a f… #

Patch Set 3 : Additional regression fixes. Up-to-date as of Friday, February 24 #

Patch Set 4 : r39789: All tests are passing except for backwards-compatible serialization. #

Patch Set 5 : r39817: Documentation, name changes, technical previews, and more tests. #

Patch Set 6 : r39857: Last commit before merge to trunk. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25653 lines, -8906 lines) Patch
M icu4c/source/i18n/compactdecimalformat.cpp View 1 2 3 4 5 3 chunks +14 lines, -5 lines 0 comments Download
M icu4j/main/classes/core/src/com/ibm/icu/impl/TextTrieMap.java View 1 2 3 4 5 3 chunks +125 lines, -0 lines 0 comments Download
A icu4j/main/classes/core/src/com/ibm/icu/impl/number/AffixPatternUtils.java View 1 2 3 4 5 1 chunk +526 lines, -0 lines 0 comments Download
A icu4j/main/classes/core/src/com/ibm/icu/impl/number/Endpoint.java View 1 2 3 4 5 1 chunk +288 lines, -0 lines 0 comments Download
A icu4j/main/classes/core/src/com/ibm/icu/impl/number/Exportable.java View 1 2 3 4 5 1 chunk +17 lines, -0 lines 0 comments Download
A icu4j/main/classes/core/src/com/ibm/icu/impl/number/Format.java View 1 2 3 4 5 1 chunk +279 lines, -0 lines 0 comments Download
A icu4j/main/classes/core/src/com/ibm/icu/impl/number/FormatQuantity.java View 1 2 3 4 5 1 chunk +182 lines, -0 lines 0 comments Download
A icu4j/main/classes/core/src/com/ibm/icu/impl/number/FormatQuantity1.java View 1 2 3 4 5 1 chunk +862 lines, -0 lines 0 comments Download
A icu4j/main/classes/core/src/com/ibm/icu/impl/number/FormatQuantity2.java View 1 2 3 4 5 1 chunk +175 lines, -0 lines 0 comments Download
A icu4j/main/classes/core/src/com/ibm/icu/impl/number/FormatQuantity3.java View 1 2 3 4 5 1 chunk +224 lines, -0 lines 0 comments Download
A icu4j/main/classes/core/src/com/ibm/icu/impl/number/FormatQuantity4.java View 1 2 3 4 5 1 chunk +409 lines, -0 lines 0 comments Download
A icu4j/main/classes/core/src/com/ibm/icu/impl/number/FormatQuantityBCD.java View 1 2 3 4 5 1 chunk +902 lines, -0 lines 0 comments Download
A icu4j/main/classes/core/src/com/ibm/icu/impl/number/FormatQuantitySelector.java View 1 2 3 4 5 1 chunk +54 lines, -0 lines 0 comments Download
A icu4j/main/classes/core/src/com/ibm/icu/impl/number/Modifier.java View 1 2 3 4 5 1 chunk +130 lines, -0 lines 0 comments Download
A icu4j/main/classes/core/src/com/ibm/icu/impl/number/ModifierHolder.java View 1 2 3 4 5 1 chunk +108 lines, -0 lines 0 comments Download
A icu4j/main/classes/core/src/com/ibm/icu/impl/number/NumberStringBuilder.java View 1 2 3 4 5 1 chunk +413 lines, -0 lines 0 comments Download
A icu4j/main/classes/core/src/com/ibm/icu/impl/number/PNAffixGenerator.java View 1 2 3 4 5 1 chunk +298 lines, -0 lines 0 comments Download
A icu4j/main/classes/core/src/com/ibm/icu/impl/number/Parse.java View 1 2 3 4 5 1 chunk +2112 lines, -0 lines 0 comments Download
A icu4j/main/classes/core/src/com/ibm/icu/impl/number/PatternString.java View 1 2 3 4 5 1 chunk +857 lines, -0 lines 0 comments Download
A icu4j/main/classes/core/src/com/ibm/icu/impl/number/Properties.java View 1 2 3 4 5 1 chunk +996 lines, -0 lines 0 comments Download
A icu4j/main/classes/core/src/com/ibm/icu/impl/number/Rounder.java View 1 2 3 4 5 1 chunk +267 lines, -0 lines 0 comments Download
A icu4j/main/classes/core/src/com/ibm/icu/impl/number/RoundingUtils.java View 1 2 3 4 5 1 chunk +167 lines, -0 lines 0 comments Download
A icu4j/main/classes/core/src/com/ibm/icu/impl/number/demo.java View 1 2 3 4 5 1 chunk +125 lines, -0 lines 0 comments Download
A icu4j/main/classes/core/src/com/ibm/icu/impl/number/formatters/BigDecimalMultiplier.java View 1 2 3 4 5 1 chunk +59 lines, -0 lines 0 comments Download
A icu4j/main/classes/core/src/com/ibm/icu/impl/number/formatters/CompactDecimalFormat.java View 1 2 3 4 5 1 chunk +451 lines, -0 lines 0 comments Download
A icu4j/main/classes/core/src/com/ibm/icu/impl/number/formatters/CurrencyFormat.java View 1 2 3 4 5 1 chunk +301 lines, -0 lines 0 comments Download
A icu4j/main/classes/core/src/com/ibm/icu/impl/number/formatters/MagnitudeMultiplier.java View 1 2 3 4 5 1 chunk +61 lines, -0 lines 0 comments Download
A icu4j/main/classes/core/src/com/ibm/icu/impl/number/formatters/MeasureFormat.java View 1 2 3 4 5 1 chunk +75 lines, -0 lines 0 comments Download
A icu4j/main/classes/core/src/com/ibm/icu/impl/number/formatters/PaddingFormat.java View 1 2 3 4 5 1 chunk +175 lines, -0 lines 0 comments Download
A icu4j/main/classes/core/src/com/ibm/icu/impl/number/formatters/PositiveDecimalFormat.java View 1 2 3 4 5 1 chunk +229 lines, -0 lines 0 comments Download
A icu4j/main/classes/core/src/com/ibm/icu/impl/number/formatters/PositiveNegativeAffixFormat.java View 1 2 3 4 5 1 chunk +258 lines, -0 lines 0 comments Download
A icu4j/main/classes/core/src/com/ibm/icu/impl/number/formatters/RangeFormat.java View 1 2 3 4 5 1 chunk +60 lines, -0 lines 0 comments Download
A icu4j/main/classes/core/src/com/ibm/icu/impl/number/formatters/RoundingFormat.java View 1 2 3 4 5 1 chunk +43 lines, -0 lines 0 comments Download
A icu4j/main/classes/core/src/com/ibm/icu/impl/number/formatters/ScientificFormat.java View 1 2 3 4 5 1 chunk +235 lines, -0 lines 0 comments Download
A icu4j/main/classes/core/src/com/ibm/icu/impl/number/formatters/StrongAffixFormat.java View 1 2 3 4 5 1 chunk +50 lines, -0 lines 0 comments Download
A icu4j/main/classes/core/src/com/ibm/icu/impl/number/modifiers/ConstantAffixModifier.java View 1 2 3 4 5 1 chunk +107 lines, -0 lines 0 comments Download
A icu4j/main/classes/core/src/com/ibm/icu/impl/number/modifiers/ConstantMultiFieldModifier.java View 1 2 3 4 5 1 chunk +95 lines, -0 lines 0 comments Download
A icu4j/main/classes/core/src/com/ibm/icu/impl/number/modifiers/GeneralPluralModifier.java View 1 2 3 4 5 1 chunk +78 lines, -0 lines 0 comments Download
A icu4j/main/classes/core/src/com/ibm/icu/impl/number/modifiers/PositiveNegativeAffixModifier.java View 1 2 3 4 5 1 chunk +55 lines, -0 lines 0 comments Download
A icu4j/main/classes/core/src/com/ibm/icu/impl/number/modifiers/SimpleModifier.java View 1 2 3 4 5 1 chunk +132 lines, -0 lines 0 comments Download
A icu4j/main/classes/core/src/com/ibm/icu/impl/number/rounders/IncrementRounder.java View 1 2 3 4 5 1 chunk +69 lines, -0 lines 0 comments Download
A icu4j/main/classes/core/src/com/ibm/icu/impl/number/rounders/MagnitudeRounder.java View 1 2 3 4 5 1 chunk +32 lines, -0 lines 0 comments Download
A icu4j/main/classes/core/src/com/ibm/icu/impl/number/rounders/NoRounder.java View 1 2 3 4 5 1 chunk +26 lines, -0 lines 0 comments Download
A icu4j/main/classes/core/src/com/ibm/icu/impl/number/rounders/SignificantDigitsRounder.java View 1 2 3 4 5 1 chunk +225 lines, -0 lines 0 comments Download
D icu4j/main/classes/core/src/com/ibm/icu/text/CompactDecimalDataCache.java View 1 2 3 4 5 1 chunk +0 lines, -524 lines 0 comments Download
M icu4j/main/classes/core/src/com/ibm/icu/text/CompactDecimalFormat.java View 1 2 3 4 5 1 chunk +188 lines, -519 lines 0 comments Download
M icu4j/main/classes/core/src/com/ibm/icu/text/CurrencyPluralInfo.java View 1 2 3 4 5 7 chunks +16 lines, -8 lines 0 comments Download
M icu4j/main/classes/core/src/com/ibm/icu/text/DecimalFormat.java View 1 2 3 4 5 1 chunk +1907 lines, -6094 lines 0 comments Download
M icu4j/main/classes/core/src/com/ibm/icu/text/DecimalFormatSymbols.java View 1 2 3 4 5 4 chunks +10 lines, -7 lines 0 comments Download
A icu4j/main/classes/core/src/com/ibm/icu/text/DecimalFormat_ICU58.java View 1 2 3 4 5 1 chunk +6279 lines, -0 lines 0 comments Download
M icu4j/main/classes/core/src/com/ibm/icu/text/MeasureFormat.java View 1 2 3 4 5 25 chunks +45 lines, -37 lines 0 comments Download
M icu4j/main/classes/core/src/com/ibm/icu/text/MessageFormat.java View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M icu4j/main/classes/core/src/com/ibm/icu/text/NumberFormat.java View 1 2 3 4 5 6 chunks +22 lines, -7 lines 0 comments Download
M icu4j/main/classes/core/src/com/ibm/icu/text/PluralFormat.java View 1 2 3 4 5 3 chunks +5 lines, -3 lines 0 comments Download
M icu4j/main/classes/core/src/com/ibm/icu/text/PluralRules.java View 1 2 3 4 5 15 chunks +56 lines, -18 lines 0 comments Download
M icu4j/main/classes/core/src/com/ibm/icu/text/RuleBasedNumberFormat.java View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M icu4j/main/classes/core/src/com/ibm/icu/text/ScientificNumberFormatter.java View 1 2 3 4 5 3 chunks +3 lines, -2 lines 0 comments Download
M icu4j/main/classes/core/src/com/ibm/icu/util/Currency.java View 1 2 3 4 5 3 chunks +38 lines, -14 lines 0 comments Download
M icu4j/main/classes/core/src/com/ibm/icu/util/Measure.java View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M icu4j/main/tests/core/src/com/ibm/icu/dev/data/numberformattestspecification.txt View 1 2 3 4 5 35 chunks +467 lines, -150 lines 0 comments Download
M icu4j/main/tests/core/src/com/ibm/icu/dev/test/format/BigNumberFormatTest.java View 1 2 3 4 5 6 chunks +10 lines, -10 lines 0 comments Download
M icu4j/main/tests/core/src/com/ibm/icu/dev/test/format/CompactDecimalFormatTest.java View 1 2 3 4 5 16 chunks +152 lines, -88 lines 0 comments Download
A icu4j/main/tests/core/src/com/ibm/icu/dev/test/format/DataDrivenNumberFormatTestData.java View 1 2 3 4 5 1 chunk +535 lines, -0 lines 0 comments Download
M icu4j/main/tests/core/src/com/ibm/icu/dev/test/format/DataDrivenNumberFormatTestUtility.java View 1 2 3 4 5 19 chunks +73 lines, -43 lines 0 comments Download
M icu4j/main/tests/core/src/com/ibm/icu/dev/test/format/IntlTestDecimalFormatAPI.java View 1 2 3 4 5 10 chunks +34 lines, -34 lines 0 comments Download
M icu4j/main/tests/core/src/com/ibm/icu/dev/test/format/IntlTestDecimalFormatAPIC.java View 1 2 3 4 5 2 chunks +2 lines, -4 lines 0 comments Download
M icu4j/main/tests/core/src/com/ibm/icu/dev/test/format/IntlTestDecimalFormatSymbolsC.java View 1 2 3 4 5 6 chunks +24 lines, -24 lines 0 comments Download
M icu4j/main/tests/core/src/com/ibm/icu/dev/test/format/MeasureUnitTest.java View 1 2 3 4 5 4 chunks +11 lines, -2 lines 0 comments Download
A icu4j/main/tests/core/src/com/ibm/icu/dev/test/format/NumberFormatDataDrivenTest.java View 1 2 3 4 5 1 chunk +435 lines, -0 lines 0 comments Download
M icu4j/main/tests/core/src/com/ibm/icu/dev/test/format/NumberFormatRegressionTest.java View 1 2 3 4 5 17 chunks +49 lines, -43 lines 0 comments Download
M icu4j/main/tests/core/src/com/ibm/icu/dev/test/format/NumberFormatSerialTestData.java View 1 2 3 4 5 3 chunks +288 lines, -74 lines 0 comments Download
M icu4j/main/tests/core/src/com/ibm/icu/dev/test/format/NumberFormatTest.java View 1 2 3 4 5 40 chunks +677 lines, -484 lines 0 comments Download
M icu4j/main/tests/core/src/com/ibm/icu/dev/test/format/NumberFormatTestCases.txt View 1 2 3 4 5 2 chunks +5 lines, -4 lines 0 comments Download
D icu4j/main/tests/core/src/com/ibm/icu/dev/test/format/NumberFormatTestData.java View 1 2 3 4 5 1 chunk +0 lines, -527 lines 0 comments Download
M icu4j/main/tests/core/src/com/ibm/icu/dev/test/format/NumberRegressionTests.java View 1 2 3 4 5 32 chunks +89 lines, -161 lines 0 comments Download
A icu4j/main/tests/core/src/com/ibm/icu/dev/test/format/ShanesDataDrivenTester.java View 1 2 3 4 5 1 chunk +345 lines, -0 lines 0 comments Download
M icu4j/main/tests/core/src/com/ibm/icu/dev/test/format/TestMessageFormat.java View 1 2 3 4 5 1 chunk +3 lines, -2 lines 0 comments Download
A icu4j/main/tests/core/src/com/ibm/icu/dev/test/numbers/AffixPatternUtilsTest.java View 1 2 3 4 5 1 chunk +128 lines, -0 lines 0 comments Download
A icu4j/main/tests/core/src/com/ibm/icu/dev/test/numbers/FormatQuantityTest.java View 1 2 3 4 5 1 chunk +477 lines, -0 lines 0 comments Download
A icu4j/main/tests/core/src/com/ibm/icu/dev/test/numbers/NumberStringBuilderTest.java View 1 2 3 4 5 1 chunk +173 lines, -0 lines 0 comments Download
A icu4j/main/tests/core/src/com/ibm/icu/dev/test/numbers/PatternStringTest.java View 1 2 3 4 5 1 chunk +112 lines, -0 lines 0 comments Download
A icu4j/main/tests/core/src/com/ibm/icu/dev/test/numbers/PropertiesTest.java View 1 2 3 4 5 1 chunk +333 lines, -0 lines 0 comments Download
A icu4j/main/tests/core/src/com/ibm/icu/dev/test/numbers/RounderTest.java View 1 2 3 4 5 1 chunk +136 lines, -0 lines 0 comments Download
M icu4j/main/tests/core/src/com/ibm/icu/dev/test/serializable/FormatHandler.java View 1 2 3 4 5 2 chunks +19 lines, -2 lines 0 comments Download
M icu4j/main/tests/core/src/com/ibm/icu/dev/test/serializable/SerializableTestUtility.java View 1 2 3 4 5 3 chunks +7 lines, -0 lines 0 comments Download
M icu4j/main/tests/core/src/com/ibm/icu/dev/test/util/TextTrieMapTest.java View 1 2 3 4 5 11 chunks +150 lines, -12 lines 0 comments Download

Messages

Total messages: 7
sffc
See the email entitled "Initial DecimalFormat Code Review Ready" for instructions on how I recommend ...
8 months ago (2017-01-21 11:13:25 UTC) #1
andy.heninger
The code, so far, makes sense. I've been stepping through formatting ops in the debugger, ...
7 months, 3 weeks ago (2017-01-27 05:50:55 UTC) #2
andy.heninger
Comments pending from last week. https://codereview.appspot.com/315420043/diff/1/icu4j/main/classes/core/src/com/ibm/icu/impl/number/FormatQuantity2.java File icu4j/main/classes/core/src/com/ibm/icu/impl/number/FormatQuantity2.java (right): https://codereview.appspot.com/315420043/diff/1/icu4j/main/classes/core/src/com/ibm/icu/impl/number/FormatQuantity2.java#newcode34 icu4j/main/classes/core/src/com/ibm/icu/impl/number/FormatQuantity2.java:34: * digits after the ...
7 months, 2 weeks ago (2017-02-01 23:55:17 UTC) #3
sffc
Responding to Andy's initial feedback. https://codereview.appspot.com/315420043/diff/1/icu4j/main/classes/core/src/com/ibm/icu/impl/number/DoubleSidedStringBuilder.java File icu4j/main/classes/core/src/com/ibm/icu/impl/number/DoubleSidedStringBuilder.java (right): https://codereview.appspot.com/315420043/diff/1/icu4j/main/classes/core/src/com/ibm/icu/impl/number/DoubleSidedStringBuilder.java#newcode64 icu4j/main/classes/core/src/com/ibm/icu/impl/number/DoubleSidedStringBuilder.java:64: public int insert(int index, ...
7 months ago (2017-02-17 22:42:49 UTC) #4
sffc
r39789: All tests are passing except for backwards-compatible serialization.
6 months, 1 week ago (2017-03-14 02:19:40 UTC) #5
sffc
r39817: Documentation, name changes, technical previews, and more tests.
6 months, 1 week ago (2017-03-15 11:06:57 UTC) #6
sffc
6 months ago (2017-03-20 21:51:32 UTC) #7
r39857: Last commit before merge to trunk.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 80a51fa-tainted