Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1)

Issue 315400043: Nonlinear RED implementation in ns-3

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 months ago by Nichit Bodhak Goel
Modified:
2 months, 1 week ago
CC:
ns-3-reviews_googlegroups.com
Visibility:
Public.

Description

Nonlinear RED (NLRED) [1] is a variant of RED in which the linear packet dropping function of RED is replaced by a nonlinear quadratic function. This patch provides implementation of Nonlinear RED in ns-3 along with documentation, test-suite and example program. Your reviews are much appreciated. Thanks, Nichit Bodhak Goel [1] Zhou, K., Yeung, K. L., & Li, V. O. (2006). Nonlinear RED: A simple yet efficient active queue management scheme. Computer Networks, 50(18), 3784-3794.

Patch Set 1 #

Total comments: 4

Patch Set 2 : Modified Patch #

Patch Set 3 : Patch Set 3: Modified Patch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+289 lines, -0 lines) Patch
M src/traffic-control/doc/red.rst View 1 5 chunks +26 lines, -0 lines 0 comments Download
A src/traffic-control/examples/red-vs-nlred.cc View 1 2 1 chunk +192 lines, -0 lines 0 comments Download
M src/traffic-control/examples/wscript View 2 1 chunk +3 lines, -0 lines 0 comments Download
M src/traffic-control/model/red-queue-disc.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M src/traffic-control/model/red-queue-disc.cc View 1 2 2 chunks +12 lines, -0 lines 0 comments Download
M src/traffic-control/test/red-queue-disc-test-suite.cc View 1 2 2 chunks +55 lines, -0 lines 0 comments Download

Messages

Total messages: 4
Stefano Avallone
Inline are a couple of questions related to how p is computed. Also, I would ...
3 months, 3 weeks ago (2017-01-27 14:10:57 UTC) #1
PhaniKiran Somanchi
On 2017/01/27 14:10:57, Stefano Avallone wrote: > Inline are a couple of questions related to ...
3 months, 3 weeks ago (2017-01-29 19:45:08 UTC) #2
Nichit Bodhak Goel
Hi Stefano, Thanks a lot for reviewing the code and providing suggestions. I have uploaded ...
3 months, 3 weeks ago (2017-01-31 11:05:35 UTC) #3
Nichit Bodhak Goel
2 months, 1 week ago (2017-03-16 09:00:52 UTC) #4
On 2017/01/31 11:05:35, Nichit Bodhak Goel wrote:
> Hi Stefano,
> 
> Thanks a lot for reviewing the code and providing suggestions. I have uploaded
a
> new patch with the suggested changes.
> 
> Please let me know whether the new patch looks fine.
> 
> Thanks,
> Nichit Bodhak Goel
> 
>
https://codereview.appspot.com/315400043/diff/1/src/traffic-control/model/red...
> File src/traffic-control/model/red-queue-disc.cc (right):
> 
>
https://codereview.appspot.com/315400043/diff/1/src/traffic-control/model/red...
> src/traffic-control/model/red-queue-disc.cc:712: 
> On 2017/01/27 14:10:56, Stefano Avallone wrote:
> > I can't find in the reference that maxP is set to 1.5 times its old value.
> Could
> > you please point me to the place where it is stated?
> 
> In the paragraph just before Section 3.2, authors have explained the reason of
> using 1.5 * maxP. Please let me know if any more information is required.
> 
>
https://codereview.appspot.com/315400043/diff/1/src/traffic-control/model/red...
> src/traffic-control/model/red-queue-disc.cc:726: }
> On 2017/01/27 14:10:56, Stefano Avallone wrote:
> > I think this can be further simplified:
> > 
> >   else
> >     {
> >       /*
> >        * p ranges from 0 to max_p as the average queue size ranges from
> >        * th_min to th_max
> >        */
> >       p = vA * qAvg + vB;
> >       if (m_isNonlinear)
> >         {
> >           p *= p; (or p *= p * 1.5);
> >         }
> >       p *= maxP;
> >     }
> 
> Done.
> 
> However, I have slightly modified the code which you suggested so that a new
> reader can relate it easily with the paper.
> 
> Please let me know if these changes are fine.

Hi Stefano,

I have uploaded the new patch (Patch 3) according to the updated version of
ns-3-dev.

Thanks,
Nichit Bodhak Goel
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 80a51fa-tainted