Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(147)

Issue 315400043: Nonlinear RED implementation in ns-3 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 months, 1 week ago by Nichit Bodhak Goel
Modified:
4 months, 3 weeks ago
CC:
ns-3-reviews_googlegroups.com
Visibility:
Public.

Description

Nonlinear RED (NLRED) [1] is a variant of RED in which the linear packet dropping function of RED is replaced by a nonlinear quadratic function. This patch provides implementation of Nonlinear RED in ns-3 along with documentation, test-suite and example program. Your reviews are much appreciated. Thanks, Nichit Bodhak Goel [1] Zhou, K., Yeung, K. L., & Li, V. O. (2006). Nonlinear RED: A simple yet efficient active queue management scheme. Computer Networks, 50(18), 3784-3794.

Patch Set 1 #

Total comments: 4

Patch Set 2 : Modified Patch #

Patch Set 3 : Patch Set 3: Modified Patch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+289 lines, -0 lines) Patch
M src/traffic-control/doc/red.rst View 1 5 chunks +26 lines, -0 lines 0 comments Download
A src/traffic-control/examples/red-vs-nlred.cc View 1 2 1 chunk +192 lines, -0 lines 0 comments Download
M src/traffic-control/examples/wscript View 2 1 chunk +3 lines, -0 lines 0 comments Download
M src/traffic-control/model/red-queue-disc.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M src/traffic-control/model/red-queue-disc.cc View 1 2 2 chunks +12 lines, -0 lines 0 comments Download
M src/traffic-control/test/red-queue-disc-test-suite.cc View 1 2 2 chunks +55 lines, -0 lines 0 comments Download

Messages

Total messages: 5
Stefano Avallone
Inline are a couple of questions related to how p is computed. Also, I would ...
8 months, 4 weeks ago (2017-01-27 14:10:57 UTC) #1
PhaniKiran Somanchi
On 2017/01/27 14:10:57, Stefano Avallone wrote: > Inline are a couple of questions related to ...
8 months, 3 weeks ago (2017-01-29 19:45:08 UTC) #2
Nichit Bodhak Goel
Hi Stefano, Thanks a lot for reviewing the code and providing suggestions. I have uploaded ...
8 months, 3 weeks ago (2017-01-31 11:05:35 UTC) #3
Nichit Bodhak Goel
On 2017/01/31 11:05:35, Nichit Bodhak Goel wrote: > Hi Stefano, > > Thanks a lot ...
7 months, 1 week ago (2017-03-16 09:00:52 UTC) #4
Stefano Avallone
4 months, 4 weeks ago (2017-05-28 11:12:38 UTC) #5
Pushed to ns-3-dev with changeset 12891:3b239b1c038c.

Thanks|

PS Could you please close this code review?
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 80a51fa-tainted