Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(14146)
Issues Repositories Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 315120043: Dropdown menu for toolbar (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 4 months ago by jiaxi
Modified:
7 years, 4 months ago
Reviewers:
tsergeant, calamity
CC:
angelayang
Visibility:
Public.

Description

Dropdown menu for toolbar This cl contains the dropdown menu for toolbar with custom strings. Still needs more information about the font/hr color. BUG= R=calamity@chromium.org, tsergeant@chromium.org Committed: fddc0549232022be92a35b42f3571c8270703a8d

Patch Set 1 #

Total comments: 6

Patch Set 2 : changed hr css and some mouse events #

Total comments: 12

Patch Set 3 : css modification #

Total comments: 6

Patch Set 4 : css fix again #

Total comments: 6

Patch Set 5 : css fix #

Total comments: 4

Patch Set 6 : css fix #

Patch Set 7 : fix for renaming #

Unified diffs Side-by-side diffs Delta from patch set Stats (+149 lines, -14 lines) Patch
M chrome/app/bookmarks_strings.grdp View 2 chunks +18 lines, -0 lines 0 comments Download
M chrome/browser/resources/md_bookmarks/compiled_resources2.gyp View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/resources/md_bookmarks/list.html View 1 2 3 4 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/resources/md_bookmarks/list.js View 1 2 3 4 5 6 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser/resources/md_bookmarks/shared_style.html View 1 2 3 1 chunk +8 lines, -1 line 0 comments Download
M chrome/browser/resources/md_bookmarks/shared_vars.html View 1 2 3 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/resources/md_bookmarks/toolbar.html View 1 2 3 4 5 1 chunk +56 lines, -1 line 0 comments Download
M chrome/browser/resources/md_bookmarks/toolbar.js View 1 2 3 4 5 6 1 chunk +42 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/md_bookmarks/md_bookmarks_ui.cc View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 16
jiaxi
7 years, 4 months ago (2016-12-05 04:25:31 UTC) #1
tsergeant
https://codereview.appspot.com/315120043/diff/1/chrome/browser/resources/md_bookmarks/toolbar.html File chrome/browser/resources/md_bookmarks/toolbar.html (right): https://codereview.appspot.com/315120043/diff/1/chrome/browser/resources/md_bookmarks/toolbar.html#newcode23 chrome/browser/resources/md_bookmarks/toolbar.html:23: } You might have noticed that the button you've ...
7 years, 4 months ago (2016-12-06 02:54:59 UTC) #2
jiaxi
https://codereview.appspot.com/315120043/diff/1/chrome/browser/resources/md_bookmarks/toolbar.html File chrome/browser/resources/md_bookmarks/toolbar.html (right): https://codereview.appspot.com/315120043/diff/1/chrome/browser/resources/md_bookmarks/toolbar.html#newcode23 chrome/browser/resources/md_bookmarks/toolbar.html:23: } On 2016/12/06 02:54:59, tsergeant wrote: > You might ...
7 years, 4 months ago (2016-12-06 22:38:14 UTC) #3
tsergeant
https://codereview.appspot.com/315120043/diff/20001/chrome/browser/resources/md_bookmarks/list.html File chrome/browser/resources/md_bookmarks/list.html (right): https://codereview.appspot.com/315120043/diff/20001/chrome/browser/resources/md_bookmarks/list.html#newcode50 chrome/browser/resources/md_bookmarks/list.html:50: on-tap="onMenuButtonOpenTap_"> Should be indented another 2 spaces, so that ...
7 years, 4 months ago (2016-12-07 00:05:42 UTC) #4
tsergeant
https://codereview.appspot.com/315120043/diff/20001/chrome/browser/resources/md_bookmarks/shared_style.html File chrome/browser/resources/md_bookmarks/shared_style.html (right): https://codereview.appspot.com/315120043/diff/20001/chrome/browser/resources/md_bookmarks/shared_style.html#newcode31 chrome/browser/resources/md_bookmarks/shared_style.html:31: color: rgba(0,0,0,0.11); On 2016/12/07 00:05:42, tsergeant wrote: > Add ...
7 years, 4 months ago (2016-12-07 00:12:09 UTC) #5
jiaxi
https://codereview.appspot.com/315120043/diff/20001/chrome/browser/resources/md_bookmarks/list.html File chrome/browser/resources/md_bookmarks/list.html (right): https://codereview.appspot.com/315120043/diff/20001/chrome/browser/resources/md_bookmarks/list.html#newcode50 chrome/browser/resources/md_bookmarks/list.html:50: on-tap="onMenuButtonOpenTap_"> On 2016/12/07 00:05:42, tsergeant wrote: > Should be ...
7 years, 4 months ago (2016-12-07 02:01:32 UTC) #6
tsergeant
https://codereview.appspot.com/315120043/diff/40001/chrome/browser/resources/md_bookmarks/shared_style.html File chrome/browser/resources/md_bookmarks/shared_style.html (right): https://codereview.appspot.com/315120043/diff/40001/chrome/browser/resources/md_bookmarks/shared_style.html#newcode31 chrome/browser/resources/md_bookmarks/shared_style.html:31: background: #000; Can you just do background: rgba(0, 0, ...
7 years, 4 months ago (2016-12-07 03:32:26 UTC) #7
jiaxi
https://codereview.appspot.com/315120043/diff/40001/chrome/browser/resources/md_bookmarks/shared_style.html File chrome/browser/resources/md_bookmarks/shared_style.html (right): https://codereview.appspot.com/315120043/diff/40001/chrome/browser/resources/md_bookmarks/shared_style.html#newcode31 chrome/browser/resources/md_bookmarks/shared_style.html:31: background: #000; On 2016/12/07 03:32:26, tsergeant wrote: > Can ...
7 years, 4 months ago (2016-12-07 03:46:00 UTC) #8
tsergeant
lgtm, passing to Chris.
7 years, 4 months ago (2016-12-07 03:48:59 UTC) #9
calamity
7 years, 4 months ago (2016-12-08 02:32:17 UTC) #10
calamity
https://codereview.appspot.com/315120043/diff/60001/chrome/browser/resources/md_bookmarks/toolbar.html File chrome/browser/resources/md_bookmarks/toolbar.html (right): https://codereview.appspot.com/315120043/diff/60001/chrome/browser/resources/md_bookmarks/toolbar.html#newcode20 chrome/browser/resources/md_bookmarks/toolbar.html:20: border: 2px solid white; Can you change this to ...
7 years, 4 months ago (2016-12-08 03:39:23 UTC) #11
jiaxi
https://codereview.appspot.com/315120043/diff/60001/chrome/browser/resources/md_bookmarks/toolbar.html File chrome/browser/resources/md_bookmarks/toolbar.html (right): https://codereview.appspot.com/315120043/diff/60001/chrome/browser/resources/md_bookmarks/toolbar.html#newcode20 chrome/browser/resources/md_bookmarks/toolbar.html:20: border: 2px solid white; On 2016/12/08 03:39:23, calamity wrote: ...
7 years, 4 months ago (2016-12-08 03:47:52 UTC) #12
calamity
https://codereview.appspot.com/315120043/diff/80001/chrome/browser/resources/md_bookmarks/list.js File chrome/browser/resources/md_bookmarks/list.js (right): https://codereview.appspot.com/315120043/diff/80001/chrome/browser/resources/md_bookmarks/list.js#newcode47 chrome/browser/resources/md_bookmarks/list.js:47: this.$.dialog); Kersplode. https://codereview.appspot.com/315120043/diff/80001/chrome/browser/resources/md_bookmarks/toolbar.js File chrome/browser/resources/md_bookmarks/toolbar.js (right): https://codereview.appspot.com/315120043/diff/80001/chrome/browser/resources/md_bookmarks/toolbar.js#newcode48 chrome/browser/resources/md_bookmarks/toolbar.js:48: this.$.dialog); ...
7 years, 4 months ago (2016-12-08 03:52:18 UTC) #13
jiaxi
_(:3_ https://codereview.appspot.com/315120043/diff/80001/chrome/browser/resources/md_bookmarks/list.js File chrome/browser/resources/md_bookmarks/list.js (right): https://codereview.appspot.com/315120043/diff/80001/chrome/browser/resources/md_bookmarks/list.js#newcode47 chrome/browser/resources/md_bookmarks/list.js:47: this.$.dialog); On 2016/12/08 03:52:18, calamity wrote: > Kersplode. ...
7 years, 4 months ago (2016-12-08 03:55:26 UTC) #14
calamity
lgtm
7 years, 4 months ago (2016-12-08 03:56:57 UTC) #15
jiaxi
7 years, 4 months ago (2016-12-08 03:57:39 UTC) #16
Message was sent while issue was closed. 
Committed patchset #7 (id:120001) manually as
fddc0549232022be92a35b42f3571c8270703a8d (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b