Issue 314670043: Addition of cwnd_event to TcpCongestionOps

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 314670043: Addition of cwnd_event to TcpCongestionOps

Can't Edit
Can't Publish+Mail
Start Review

Created:
7 years, 1 month ago by adadeepak8

Modified:
6 years, 11 months ago

Reviewers:
Tom Henderson

CC:
ns-3-reviews_googlegroups.com

Visibility:
Public.

More Reviews

Description

Addition of cwnd_event to TcpCongestionOps

Patch Set 2 : Updated patch based on latest Linux version #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+38 lines, -6 lines)			Patch
M	src/internet/doc/tcp.rst	View		2 chunks	+4 lines, -0 lines	0 comments	Download
M	src/internet/model/tcp-congestion-ops.h	View	1	1 chunk	+13 lines, -3 lines	0 comments	Download
M	src/internet/model/tcp-socket-base.h	View	1	1 chunk	+12 lines, -0 lines	0 comments	Download
M	src/internet/model/tcp-socket-base.cc	View	1	6 chunks	+9 lines, -3 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Tom Henderson

https://codereview.appspot.com/314670043/diff/1/src/internet/model/tcp-congestion-ops.h File src/internet/model/tcp-congestion-ops.h (right): https://codereview.appspot.com/314670043/diff/1/src/internet/model/tcp-congestion-ops.h#newcode140 src/internet/model/tcp-congestion-ops.h:140: * \brief Trigger events/calculations on occurance cwnd event s/occurance ...

7 years ago (2017-03-28 17:55:08 UTC) #1

adadeepak8

6 years, 11 months ago (2017-05-10 14:26:30 UTC) #2

Sir,

I had made the previous patch based on an older Linux, I have modified the same.
The two event based on ECN can be added right after ECN phase 2. Also, the event
based on congestion window restart is not added, as I was unable to locate any
associated event (timer based on idle time) in ns-3 currently.

Thanks,
Ankit

https://codereview.appspot.com/314670043/diff/1/src/internet/model/tcp-conges...
File src/internet/model/tcp-congestion-ops.h (right):

https://codereview.appspot.com/314670043/diff/1/src/internet/model/tcp-conges...
src/internet/model/tcp-congestion-ops.h:140: * \brief Trigger
events/calculations on occurance cwnd event
On 2017/03/28 17:55:08, Tom Henderson wrote:
> s/occurance cwnd event/occurrence of a congestion window event

Done.

https://codereview.appspot.com/314670043/diff/1/src/internet/model/tcp-socket...
File src/internet/model/tcp-socket-base.cc (right):

https://codereview.appspot.com/314670043/diff/1/src/internet/model/tcp-socket...
src/internet/model/tcp-socket-base.cc:1564: m_congestionControl->CwndEvent
(m_tcb, TcpSocketState::CA_EVENT_LOSS);
The Linux codebase has cong state changes associated with some of the congestion
event

https://codereview.appspot.com/314670043/diff/1/src/internet/model/tcp-socket...
File src/internet/model/tcp-socket-base.h (right):

https://codereview.appspot.com/314670043/diff/1/src/internet/model/tcp-socket...
src/internet/model/tcp-socket-base.h:143: CA_EVENT_FRTO,          /* fast
recovery timeout (not used currently)*/
Removed based on Linux 4.11

Expand All Messages | Collapse All Messages