Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(21)

Issue 314660043: ticket:12766 Escaping source code

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 days, 22 hours ago by andy.heninger
Modified:
4 days, 23 hours ago
Reviewers:
andy.heninger, srl295, srl, markus.icu
CC:
yoshito
Base URL:
svn+ssh://source.icu-project.org/repos/icu/trunk/icu4c/
Visibility:
Public.

Description

ticket:12766 Escaping source code

Patch Set 1 #

Total comments: 16
Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -57 lines) Patch
M . View 0 chunks +0 lines, -0 lines 0 comments Download
M source View 0 chunks +0 lines, -0 lines 0 comments Download
M source/Doxyfile.in View 1 chunk +1 line, -1 line 2 comments Download
M source/Makefile.in View 1 chunk +4 lines, -0 lines 0 comments Download
M source/common/unicode/char16ptr.h View 9 chunks +13 lines, -0 lines 0 comments Download
M source/common/unicode/platform.h View 1 chunk +7 lines, -0 lines 2 comments Download
M source/common/unicode/umachine.h View 1 chunk +7 lines, -1 line 2 comments Download
M source/common/unicode/unistr.h View 7 chunks +11 lines, -1 line 5 comments Download
M source/config/dist.mk View 1 chunk +1 line, -1 line 0 comments Download
M source/config/mh-aix-va View 1 chunk +22 lines, -2 lines 0 comments Download
M source/config/mh-solaris View 2 chunks +19 lines, -2 lines 0 comments Download
M source/configure View 5 chunks +3 lines, -34 lines 2 comments Download
M source/extra/uconv/Makefile.in View 1 chunk +1 line, -1 line 0 comments Download
M source/io/Makefile.in View 1 chunk +1 line, -1 line 0 comments Download
M source/test/intltest/Makefile.in View 1 chunk +1 line, -1 line 0 comments Download
M source/test/intltest/rbbitst.cpp View 2 chunks +9 lines, -5 lines 3 comments Download
M source/test/iotest/Makefile.in View 1 chunk +1 line, -1 line 0 comments Download
M source/tools/Makefile.in View 1 chunk +1 line, -1 line 0 comments Download
M source/tools/gennorm2/Makefile.in View 1 chunk +1 line, -1 line 0 comments Download
M source/tools/genrb/Makefile.in View 1 chunk +1 line, -1 line 0 comments Download
M source/tools/makeconv/Makefile.in View 1 chunk +1 line, -1 line 0 comments Download
M source/tools/pkgdata/Makefile.in View 1 chunk +1 line, -1 line 0 comments Download
M source/tools/toolutil/Makefile.in View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6
andy.heninger
https://codereview.appspot.com/314660043/diff/1/source/common/unicode/platform.h File source/common/unicode/platform.h (right): https://codereview.appspot.com/314660043/diff/1/source/common/unicode/platform.h#newcode489 source/common/unicode/platform.h:489: #if (U_PLATFORM == U_PF_AIX) && defined(__cplusplus) &&(U_CPLUSPLUS_VERSION < 11) ...
6 days, 20 hours ago (2017-03-20 20:17:56 UTC) #1
srl295
thanks for the reviews https://codereview.appspot.com/314660043/diff/1/source/common/unicode/platform.h File source/common/unicode/platform.h (right): https://codereview.appspot.com/314660043/diff/1/source/common/unicode/platform.h#newcode489 source/common/unicode/platform.h:489: #if (U_PLATFORM == U_PF_AIX) && ...
6 days, 19 hours ago (2017-03-20 20:30:34 UTC) #2
andy.heninger
https://codereview.appspot.com/314660043/diff/1/source/common/unicode/unistr.h File source/common/unicode/unistr.h (right): https://codereview.appspot.com/314660043/diff/1/source/common/unicode/unistr.h#newcode125 source/common/unicode/unistr.h:125: # define UNICODE_STRING(cs, _length) icu::UnicodeString(TRUE, (const char16_t*)u ## cs, ...
6 days, 19 hours ago (2017-03-20 21:03:55 UTC) #3
srl295
https://codereview.appspot.com/314660043/diff/1/source/common/unicode/unistr.h File source/common/unicode/unistr.h (right): https://codereview.appspot.com/314660043/diff/1/source/common/unicode/unistr.h#newcode125 source/common/unicode/unistr.h:125: # define UNICODE_STRING(cs, _length) icu::UnicodeString(TRUE, (const char16_t*)u ## cs, ...
6 days, 18 hours ago (2017-03-20 21:43:43 UTC) #4
markus.icu
https://codereview.appspot.com/314660043/diff/1/source/Doxyfile.in File source/Doxyfile.in (right): https://codereview.appspot.com/314660043/diff/1/source/Doxyfile.in#newcode197 source/Doxyfile.in:197: PREDEFINED = U_EXPORT2= U_STABLE= U_DRAFT= U_INTERNAL= U_SYSTEM= U_DEPRECATED= U_OBSOLETE= ...
4 days, 23 hours ago (2017-03-22 16:43:49 UTC) #5
srl295
4 days, 23 hours ago (2017-03-22 16:55:03 UTC) #6
https://codereview.appspot.com/314660043/diff/1/source/Doxyfile.in
File source/Doxyfile.in (right):

https://codereview.appspot.com/314660043/diff/1/source/Doxyfile.in#newcode197
source/Doxyfile.in:197: PREDEFINED             = U_EXPORT2= U_STABLE= U_DRAFT=
U_INTERNAL= U_SYSTEM= U_DEPRECATED= U_OBSOLETE= U_CALLCONV= U_CDECL_BEGIN=
U_CDECL_END=  U_NO_THROW=\ "U_NAMESPACE_BEGIN=namespace icu{"
"U_NAMESPACE_END=}" U_SHOW_CPLUSPLUS_API=1 U_DEFINE_LOCAL_OPEN_POINTER()=
U_IN_DOXYGEN=1 U_OVERRIDE= U_FINAL= UCONFIG_ENABLE_PLUGINS=1
U_CHAR16_IS_TYPEDEF=0 U_CPLUSPLUS_VERSION=11
On 2017/03/22 16:43:49, markus.icu wrote:
> We should not hardcode the C++ version. We will want to support some C++14/17
> features at some point.

I'd think we would bump the number here then.  This controls what doxygen's view
of the source is.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 80a51fa-tainted