ICU support for UWP

ICU support for UWP

[jefgen.msft, 2017-03-18 01:18:32]

Testing out adding a comment on Rietveld.

https://codereview.appspot.com/314650043/diff/1/source/common/unicode/uloc.h
File source/common/unicode/uloc.h (right):

https://codereview.appspot.com/314650043/diff/1/source/common/unicode/uloc.h#...
source/common/unicode/uloc.h:544: *
I wonder if we could add a link to Shawn's blog, or some other public facing
documentation that talks about not using LCIDs?

[yoshito, 2017-03-21 21:07:13]

Reviewed all changes. I think you may use int32_t instead of int for a few
places for consistency. Otherwise, looks fine to me.

In the past, we have been patching locmap.cpp when a new release of Windows came
out.. Now it looks we don't need to keep it updated for ICU running on Windows
(but we may still need the data updated for someone who wants to convert
locale-LCID on other platforms).

Thanks!

https://codereview.appspot.com/314650043/diff/1/source/common/locmap.cpp
File source/common/locmap.cpp (right):

https://codereview.appspot.com/314650043/diff/1/source/common/locmap.cpp#newc...
source/common/locmap.cpp:1119: int i = 0;
int32_t for consistency

[Shawn.Steele_microsoft.com, 2017-03-21 21:28:12]

Thanks!  

I believe I entered a ticket to update locmap to our latest LCID mappings. 
Hopefully we won't need it for Windows, but it would still be necessary for
compatibility on other platforms - the catch is that we're trying not to add
LCIDs for new locales, so the behavior is probably pretty stuck at this point. 
People that really want full support should figure out how to move away from
LCIDs.  (Something we can probably all agree on).

Thanks for taking a look,

Shawn

-----Original Message-----
From: y.umaoka@gmail.com [mailto:y.umaoka@gmail.com] 
Sent: Tuesday, March 21, 2017 2:07 PM
To: jefgen.msft@gmail.com; Shawn Steele <Shawn.Steele@microsoft.com>;
yoshito_umaoka@us.ibm.com
Cc: Axel Andrejs <aandrejs@microsoft.com>; reply@codereview-hr.appspotmail.com
Subject: Re: ICU support for UWP (issue 314650043 by jefgen.msft@gmail.com)

Reviewed all changes. I think you may use int32_t instead of int for a few
places for consistency. Otherwise, looks fine to me.

In the past, we have been patching locmap.cpp when a new release of Windows came
out.. Now it looks we don't need to keep it updated for ICU running on Windows
(but we may still need the data updated for someone who wants to convert
locale-LCID on other platforms).

Thanks!


https://codereview.appspot.com/314650043/diff/1/source/common/locmap.cpp
File source/common/locmap.cpp (right):

https://codereview.appspot.com/314650043/diff/1/source/common/locmap.cpp#newc...
source/common/locmap.cpp:1119: int i = 0; int32_t for consistency

https://codereview.appspot.com/314650043/

[jefgen.msft, 2017-03-21 21:50:30]

Indeed -- Thank you Yoshito for taking a look!

Aside, this is the ticket for updating the LCIDs:
http://bugs.icu-project.org/trac/ticket/12709
And there is also this ticket for removing/limiting any internal (to ICU)
usage of LCIDs: http://bugs.icu-project.org/trac/ticket/12712

Thanks again Yoshito! :)


On Tue, Mar 21, 2017 at 2:28 PM, Shawn Steele <Shawn.Steele@microsoft.com>
wrote:

> Thanks!
>
> I believe I entered a ticket to update locmap to our latest LCID
> mappings.  Hopefully we won't need it for Windows, but it would still be
> necessary for compatibility on other platforms - the catch is that we're
> trying not to add LCIDs for new locales, so the behavior is probably pretty
> stuck at this point.  People that really want full support should figure
> out how to move away from LCIDs.  (Something we can probably all agree on).
>
> Thanks for taking a look,
>
> Shawn
>
> -----Original Message-----
> From: y.umaoka@gmail.com [mailto:y.umaoka@gmail.com]
> Sent: Tuesday, March 21, 2017 2:07 PM
> To: jefgen.msft@gmail.com; Shawn Steele <Shawn.Steele@microsoft.com>;
> yoshito_umaoka@us.ibm.com
> Cc: Axel Andrejs <aandrejs@microsoft.com>; reply@codereview-hr.
> appspotmail.com
> Subject: Re: ICU support for UWP (issue 314650043 by jefgen.msft@gmail.com
> )
>
> Reviewed all changes. I think you may use int32_t instead of int for a few
> places for consistency. Otherwise, looks fine to me.
>
> In the past, we have been patching locmap.cpp when a new release of
> Windows came out.. Now it looks we don't need to keep it updated for ICU
> running on Windows (but we may still need the data updated for someone who
> wants to convert locale-LCID on other platforms).
>
> Thanks!
>
>
> https://codereview.appspot.com/314650043/diff/1/source/common/locmap.cpp
> File source/common/locmap.cpp (right):
>
> https://codereview.appspot.com/314650043/diff/1/source/
> common/locmap.cpp#newcode1119
> source/common/locmap.cpp:1119: int i = 0; int32_t for consistency
>
> https://codereview.appspot.com/314650043/
>