Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1656)

Issue 314590043: Let \afterGrace start a Bottom context (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 1 month ago by dak
Modified:
5 years, 9 months ago
Reviewers:
lemzwerg
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Let \afterGrace start a Bottom context Previously, an \afterGrace as the first expression of music outside of an existing Bottom context caused quite weird results. Also contains commits: with-music-match: lists should match completely Previously music properties that were matched to a list of wildcards could contain fewer elements than the list they were matched to, leading to an error when the wildcard variable was being assigned to. Now the list lengths have to be matched exactly: a shorter pattern than the actual list length of the matched property cannot match any more. Fix \displayLilyMusic \partcombine... Strictly speaking this oversight in issue 4356 did not actually manifest itself as a bug because of another bug masking it.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -46 lines) Patch
M ly/music-functions-init.ly View 1 chunk +14 lines, -13 lines 0 comments Download
M scm/define-music-display-methods.scm View 3 chunks +22 lines, -15 lines 0 comments Download
M scm/display-lily.scm View 2 chunks +15 lines, -18 lines 0 comments Download

Messages

Total messages: 1
lemzwerg
7 years, 1 month ago (2017-03-01 05:17:17 UTC) #1
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b