Issue 314150044: TBR: i#2080 sigreturn: provide alternative to sigreturn for setcontext

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 314150044: TBR: i#2080 sigreturn: provide alternative to sigreturn for setcontext

Can't Edit
Can't Publish+Mail
Start Review

Created:
7 years, 4 months ago by bruening

Modified:
7 years, 4 months ago

Reviewers:
zhaoqin

CC:
dynamorio-devs_googlegroups.com

Visibility:
Public.

More Reviews

Description

Commit log for first patchset: --------------- i#2080 sigreturn: provide alternative to sigreturn for setcontext Adds an on-by-default option -use_sigreturn_setcontext. When turned off, setting a thread's context will instead use dr_longjmp. This is not fully transparent: it assumes the target stack is valid and that we can clobber the slot beyond TOS. Using this instead of sigreturn is meant mainly as a diagnostic to help debug future issues with sigreturn. ---------------

Patch Set 1 #

Patch Set 2 : Committed #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+39 lines, -0 lines)			Patch
	M	core/optionsx.h	View		1 chunk	+8 lines, -0 lines	0 comments	Download
	M	core/unix/signal.c	View		1 chunk	+31 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

bruening

7 years, 4 months ago (2016-12-07 20:48:53 UTC) #2

Committed as
https://github.com/DynamoRIO/dynamorio/commit/fc95a5c760e45b858d65ca33aaf9d6d...

Final commit log: 
---------------
i#2080 sigreturn: provide alternative to sigreturn for setcontext

Adds an on-by-default option -use_sigreturn_setcontext.  When turned off,
setting a thread's context will instead use dr_longjmp.  This is not fully
transparent: it assumes the target stack is valid and that we can clobber
the slot beyond TOS.  Using this instead of sigreturn is meant mainly as a
diagnostic to help debug future issues with sigreturn.

Review-URL: https://codereview.appspot.com/314150044
---------------

Expand All Messages | Collapse All Messages