Issue 313950043: i#2006 generalize drcachesim: use placement new

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 313950043: i#2006 generalize drcachesim: use placement new

Can't Edit
Can't Publish+Mail
Start Review

Created:
7 years, 5 months ago by zhaoqin

Modified:
7 years, 5 months ago

Reviewers:
bruening

CC:
dynamorio-devs_googlegroups.com

Visibility:
Public.

More Reviews

Description

Commit log for first patchset: --------------- i#2006 generalize drcachesim: use placement new Uses placement new on {online/offline}_instru creation for better isolation. ---------------

Patch Set 3 : Committed #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -3 lines)			Patch
	M	clients/drcachesim/tracer/tracer.cpp	View	1	3 chunks	+15 lines, -3 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

bruening

LGTM w/ suggestion https://codereview.appspot.com/313950043/diff/1/clients/drcachesim/tracer/tracer.cpp File clients/drcachesim/tracer/tracer.cpp (right): https://codereview.appspot.com/313950043/diff/1/clients/drcachesim/tracer/tracer.cpp#newcode679 clients/drcachesim/tracer/tracer.cpp:679: reinterpret_cast<offline_instru_t *>(instru)->~offline_instru_t(); suggest: I think you ...

7 years, 5 months ago (2016-10-27 22:44:19 UTC) #2

zhaoqin

Commit log for latest patchset: --------------- i#2006 generalize drcachesim: use placement new Uses placement new ...

7 years, 5 months ago (2016-10-28 17:30:35 UTC) #3

zhaoqin

https://codereview.appspot.com/313950043/diff/1/clients/drcachesim/tracer/tracer.cpp File clients/drcachesim/tracer/tracer.cpp (right): https://codereview.appspot.com/313950043/diff/1/clients/drcachesim/tracer/tracer.cpp#newcode679 clients/drcachesim/tracer/tracer.cpp:679: reinterpret_cast<offline_instru_t *>(instru)->~offline_instru_t(); On 2016/10/27 22:44:19, bruening wrote: > suggest: ...

7 years, 5 months ago (2016-10-28 17:31:07 UTC) #4

zhaoqin

7 years, 5 months ago (2016-10-31 19:35:02 UTC) #5

Committed as
https://github.com/DynamoRIO/dynamorio/commit/a72591c6ab1119c9b3594d251c3c629...

Final commit log: 
---------------
i#2006 generalize drcachesim: use placement new

Uses placement new on {online/offline}_instru creation for better isolation.

Review-URL: https://codereview.appspot.com/313950043
---------------

Expand All Messages | Collapse All Messages