Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(754)

Issue 313940043: [dfwinreg] Removed online check for new dependency versions #40 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 5 months ago by Joachim Metz
Modified:
7 years, 5 months ago
Reviewers:
jberggren, romaing, onager
CC:
kiddi, log2timeline-dev_googlegroups.com
Visibility:
Public.

Description

[dfwinreg] Removed online check for new dependency versions #40

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -262 lines) Patch
M dfwinreg/dependencies.py View 11 chunks +116 lines, -216 lines 2 comments Download
M requirements.txt View 1 chunk +1 line, -1 line 0 comments Download
M tests/dependencies.py View 4 chunks +2 lines, -44 lines 0 comments Download
M utils/check_dependencies.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4
Joachim Metz
7 years, 5 months ago (2016-10-27 06:18:08 UTC) #1
onager
One comment, LGTM https://codereview.appspot.com/313940043/diff/1/dfwinreg/dependencies.py File dfwinreg/dependencies.py (right): https://codereview.appspot.com/313940043/diff/1/dfwinreg/dependencies.py#newcode10 dfwinreg/dependencies.py:10: # (version_attribute_name, minimum_version, maximum_version) Please fix ...
7 years, 5 months ago (2016-10-31 14:49:40 UTC) #2
Joachim Metz
https://codereview.appspot.com/313940043/diff/1/dfwinreg/dependencies.py File dfwinreg/dependencies.py (right): https://codereview.appspot.com/313940043/diff/1/dfwinreg/dependencies.py#newcode10 dfwinreg/dependencies.py:10: # (version_attribute_name, minimum_version, maximum_version) On 2016/10/31 14:49:40, onager wrote: ...
7 years, 5 months ago (2016-10-31 15:23:40 UTC) #3
Joachim Metz
7 years, 5 months ago (2016-10-31 15:26:04 UTC) #4
Changes have been merged with master branch. To close the review and clean up
the feature branch you can run: python ./utils/review.py close deps
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b