Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(9155)
Issues Repositories Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 313390043: [plaso] Removed event tags from analysis report #1048 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 3 months ago by Joachim Metz
Modified:
7 years, 2 months ago
Reviewers:
jberggren, romaing, onager
CC:
kiddi, log2timeline-dev_googlegroups.com
Visibility:
Public.

Description

[plaso] Removed event tags from analysis report #1048

Patch Set 1 #

Total comments: 4

Patch Set 2 : Changes after review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -69 lines) Patch
M plaso/analysis/interface.py View 1 chunk +4 lines, -3 lines 0 comments Download
M plaso/containers/reports.py View 3 chunks +0 lines, -24 lines 0 comments Download
M plaso/storage/zip_file.py View 1 1 chunk +0 lines, -3 lines 0 comments Download
M tests/analysis/nsrlsvr.py View 1 1 chunk +12 lines, -13 lines 0 comments Download
M tests/analysis/viper.py View 1 1 chunk +18 lines, -9 lines 0 comments Download
M tests/analysis/virustotal.py View 1 chunk +14 lines, -6 lines 0 comments Download
M tests/containers/reports.py View 1 chunk +0 lines, -1 line 0 comments Download
M tests/serializer/json_serializer.py View 3 chunks +0 lines, -10 lines 0 comments Download

Messages

Total messages: 7
Joachim Metz
7 years, 3 months ago (2017-01-22 08:45:07 UTC) #1
onager
https://codereview.appspot.com/313390043/diff/1/tests/analysis/nsrlsvr.py File tests/analysis/nsrlsvr.py (right): https://codereview.appspot.com/313390043/diff/1/tests/analysis/nsrlsvr.py#newcode123 tests/analysis/nsrlsvr.py:123: # expected_labels = [u'nsrl_not_present'] Remove this https://codereview.appspot.com/313390043/diff/1/tests/analysis/viper.py File tests/analysis/viper.py ...
7 years, 2 months ago (2017-01-31 10:56:58 UTC) #2
Joachim Metz
https://codereview.appspot.com/313390043/diff/1/tests/analysis/nsrlsvr.py File tests/analysis/nsrlsvr.py (right): https://codereview.appspot.com/313390043/diff/1/tests/analysis/nsrlsvr.py#newcode123 tests/analysis/nsrlsvr.py:123: # expected_labels = [u'nsrl_not_present'] On 2017/01/31 10:56:58, onager wrote: ...
7 years, 2 months ago (2017-02-04 07:20:04 UTC) #3
Joachim Metz
Code updated.
7 years, 2 months ago (2017-02-04 07:22:32 UTC) #4
Joachim Metz
Code updated.
7 years, 2 months ago (2017-02-08 21:58:09 UTC) #5
onager
On 2017/02/08 21:58:09, Joachim Metz wrote: > Code updated. LGTM
7 years, 2 months ago (2017-02-14 15:56:14 UTC) #6
Joachim Metz
7 years, 2 months ago (2017-02-14 20:19:49 UTC) #7 
Changes have been merged with master branch. To close the review and clean up
the feature branch you can run: python ./utils/review.py close tags
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b