Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(562)

Issue 313110043: 3GPP NRTV traffic model

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 4 months ago by jani.puttonen
Modified:
7 years ago
Reviewers:
Tommaso Pecorella
CC:
ns-3-reviews_googlegroups.com
Visibility:
Public.

Description

Added a new Near-Real Time Video (NRTV) traffic model for ns-3. NRTV is specified in several standardization bodies, e.g. - 3GPP TR 25.892 "Feasibility Study for OFDM for UTRAN enhancement" - IEEE 802.16 Broadband Wireless Access Working Group, IEEE 802.16m Evaluation Methodology Document (EMD) The model includes a test suite (nrtv-test.cc), an example (nrtv-p2p-example.cc) and Sphinx documentation.

Patch Set 1 #

Total comments: 15

Patch Set 2 : Modifications related to T. Pecorella's review. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+518 lines, -469 lines) Patch
M src/applications/examples/nrtv-p2p-example.cc View 1 4 chunks +65 lines, -65 lines 0 comments Download
M src/applications/examples/nrtv-variables-plot.cc View 1 1 chunk +1 line, -1 line 0 comments Download
A src/applications/helper/client-rx-trace-plot.h View 1 1 chunk +133 lines, -0 lines 0 comments Download
A src/applications/helper/client-rx-trace-plot.cc View 1 1 chunk +137 lines, -0 lines 0 comments Download
R src/applications/helper/nrtv-client-trace-plot.h View 1 1 chunk +0 lines, -145 lines 0 comments Download
R src/applications/helper/nrtv-client-trace-plot.cc View 1 1 chunk +0 lines, -181 lines 0 comments Download
M src/applications/helper/nrtv-helper.h View 1 3 chunks +3 lines, -3 lines 0 comments Download
M src/applications/model/nrtv-header.h View 1 4 chunks +3 lines, -8 lines 0 comments Download
M src/applications/model/nrtv-header.cc View 1 4 chunks +5 lines, -12 lines 0 comments Download
M src/applications/model/nrtv-tcp-client.h View 1 2 chunks +92 lines, -12 lines 0 comments Download
M src/applications/model/nrtv-tcp-client.cc View 1 10 chunks +20 lines, -12 lines 0 comments Download
M src/applications/model/nrtv-tcp-server.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/applications/model/nrtv-tcp-server.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download
M src/applications/model/nrtv-udp-server.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/applications/model/nrtv-udp-server.cc View 1 1 chunk +8 lines, -1 line 1 comment Download
M src/applications/model/nrtv-variables.h View 1 3 chunks +10 lines, -3 lines 0 comments Download
M src/applications/model/nrtv-variables.cc View 1 5 chunks +28 lines, -12 lines 0 comments Download
M src/applications/model/nrtv-video-worker.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/applications/model/nrtv-video-worker.cc View 1 3 chunks +7 lines, -6 lines 0 comments Download
M src/applications/test/nrtv-test.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/applications/wscript View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3
Tommaso Pecorella
Hi, I gave a fast check to the code. Not line by line because I ...
7 years, 2 months ago (2017-01-08 17:33:39 UTC) #1
Tommaso Pecorella
Just one stale attribute name, missing .rst, and a missing \defgroup: /** * \ingroup applications ...
7 years ago (2017-03-02 00:14:25 UTC) #2
Tommaso Pecorella
7 years ago (2017-03-02 00:16:35 UTC) #3
On 2017/03/02 00:14:25, Tommaso Pecorella wrote:
> Just one stale attribute name, missing .rst, and a missing \defgroup:


Forget the note about the missing documentation, it "just" disappeared from the
2nd patch.
Just make sure it's in the final one.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b