Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(413)

Issue 312990043: xen_three_flows

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 4 months ago by pandan0315
Modified:
6 years, 7 months ago
Visibility:
Public.

Description

add three flows in vm environment modify the scripts according to the group member's suggestion

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+349 lines, -0 lines) Patch
A xen_three_flows/rtt_rto_cwnd.gp View 1 chunk +73 lines, -0 lines 2 comments Download
A xen_three_flows/rtt_rto_cwnd_zoomed.gp View 1 chunk +73 lines, -0 lines 1 comment Download
A xen_three_flows/throughput_zoomed.gp View 1 chunk +16 lines, -0 lines 0 comments Download
A xen_three_flows/througput.gp View 1 chunk +20 lines, -0 lines 0 comments Download
A xen_three_flows/vm1.sh View 1 chunk +42 lines, -0 lines 0 comments Download
A xen_three_flows/vm2.sh View 1 chunk +33 lines, -0 lines 0 comments Download
A xen_three_flows/vm3.sh View 1 chunk +33 lines, -0 lines 0 comments Download
A xen_three_flows/wait_till_certain_time.sh View 1 chunk +18 lines, -0 lines 0 comments Download
A xen_three_flows/xen_three_flows.sh View 1 chunk +41 lines, -0 lines 0 comments Download

Messages

Total messages: 4
pandan0315
7 years, 4 months ago (2016-11-01 20:14:28 UTC) #1
khalidomer88
Small typos, but aside from that, LGTM https://codereview.appspot.com/312990043/diff/1/xen_three_flows/rtt_rto_cwnd.gp File xen_three_flows/rtt_rto_cwnd.gp (right): https://codereview.appspot.com/312990043/diff/1/xen_three_flows/rtt_rto_cwnd.gp#newcode59 xen_three_flows/rtt_rto_cwnd.gp:59: set xlabe ...
7 years, 4 months ago (2016-11-02 17:13:51 UTC) #2
Xiaodong Zhang
https://codereview.appspot.com/312990043/diff/1/xen_three_flows/rtt_rto_cwnd.gp File xen_three_flows/rtt_rto_cwnd.gp (right): https://codereview.appspot.com/312990043/diff/1/xen_three_flows/rtt_rto_cwnd.gp#newcode73 xen_three_flows/rtt_rto_cwnd.gp:73: unset multiplot It looks good to me.
7 years, 4 months ago (2016-11-06 12:30:38 UTC) #3
kirill.sc
6 years, 7 months ago (2017-08-17 07:10:59 UTC) #4

          
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b