Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(85)

Issue 31290043: Fully integrate AuthenticationTokenHandler

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 4 months ago by gary.poster
Modified:
6 years, 4 months ago
Reviewers:
frankban, mp+196414
Visibility:
Public.

Description

Fully integrate AuthenticationTokenHandler This might be the last of the charm branches for the authtoken feature. It hooks up the handler and tests the integration. https://code.launchpad.net/~gary/charms/precise/juju-gui/authtoken3/+merge/196414 Requires: https://code.launchpad.net/~gary/charms/precise/juju-gui/authtoken2/+merge/196351 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Fully integrate AuthenticationTokenHandler #

Patch Set 3 : Fully integrate AuthenticationTokenHandler #

Total comments: 15

Patch Set 4 : Fully integrate AuthenticationTokenHandler #

Patch Set 5 : Fully integrate AuthenticationTokenHandler #

Unified diffs Side-by-side diffs Delta from patch set Stats (+317 lines, -45 lines) Patch
A [revision details] View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M server/guiserver/auth.py View 1 2 3 10 chunks +103 lines, -29 lines 0 comments Download
M server/guiserver/handlers.py View 1 2 3 3 chunks +20 lines, -4 lines 0 comments Download
M server/guiserver/tests/helpers.py View 1 chunk +10 lines, -0 lines 0 comments Download
M server/guiserver/tests/test_auth.py View 1 2 3 10 chunks +91 lines, -12 lines 0 comments Download
M server/guiserver/tests/test_handlers.py View 1 2 3 2 chunks +91 lines, -0 lines 0 comments Download

Messages

Total messages: 8
gary.poster
Please take a look.
6 years, 4 months ago (2013-11-23 02:22:17 UTC) #1
gary.poster
Please take a look.
6 years, 4 months ago (2013-11-23 02:57:58 UTC) #2
gary.poster
Please take a look.
6 years, 4 months ago (2013-11-23 03:16:40 UTC) #3
frankban
Very nice branch Gary, thank you! LGTM (with some comments below), and QA ok! To ...
6 years, 4 months ago (2013-11-25 11:59:34 UTC) #4
gary.poster
Please take a look. https://codereview.appspot.com/31290043/diff/30001/server/guiserver/auth.py File server/guiserver/auth.py (right): https://codereview.appspot.com/31290043/diff/30001/server/guiserver/auth.py#newcode27 server/guiserver/auth.py:27: - login_succeeded(data) -> bool. On ...
6 years, 4 months ago (2013-11-25 14:03:20 UTC) #5
frankban
Changes LGTM, thank you!
6 years, 4 months ago (2013-11-25 14:14:22 UTC) #6
gary.poster
*** Submitted: Fully integrate AuthenticationTokenHandler This might be the last of the charm branches for ...
6 years, 4 months ago (2013-11-25 14:18:25 UTC) #7
gary.poster
6 years, 4 months ago (2013-11-25 14:20:03 UTC) #8
Thanks for the fantastic review(s), and for going above and beyond with the QA,
Francesco.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b