Issue 312640043: ticket:13177 Moving CompactType to public CompactDecimalFormat.java

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 312640043: ticket:13177 Moving CompactType to public CompactDecimalFormat.java (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
6 years, 11 months ago by sffc

Modified:
6 years, 10 months ago

Reviewers:
andy.heninger

Base URL:
svn+icussh://source.icu-project.org/repos/icu/branches/shane/numberformat2/

Visibility:
Public.

More Reviews

Description

ticket:13177 Moving CompactType to public CompactDecimalFormat.java

Patch Set 1 #

Total comments: 2

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -6 lines)			Patch
	M	icu4j/main/classes/core/src/com/ibm/icu/impl/number/formatters/CompactDecimalFormat.java	View		2 chunks	+1 line, -6 lines	0 comments	Download
	M	icu4j/main/classes/core/src/com/ibm/icu/text/CompactDecimalFormat.java	View		1 chunk	+20 lines, -0 lines	2 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

andy.heninger

It would be good for the ticket #13177 to be a bit more specific about ...

6 years, 11 months ago (2017-05-02 21:35:51 UTC) #2

sffc

On 2017/05/02 21:35:51, andy.heninger wrote: > It would be good for the ticket #13177 to ...

6 years, 11 months ago (2017-05-02 21:38:35 UTC) #3

sffc

https://codereview.appspot.com/312640043/diff/1/icu4j/main/classes/core/src/com/ibm/icu/text/CompactDecimalFormat.java File icu4j/main/classes/core/src/com/ibm/icu/text/CompactDecimalFormat.java (right): https://codereview.appspot.com/312640043/diff/1/icu4j/main/classes/core/src/com/ibm/icu/text/CompactDecimalFormat.java#newcode75 icu4j/main/classes/core/src/com/ibm/icu/text/CompactDecimalFormat.java:75: * On 2017/05/02 21:35:51, andy.heninger wrote: > Is there ...

6 years, 11 months ago (2017-05-02 21:38:41 UTC) #4

This was originally submitted as r40088.

Expand All Messages | Collapse All Messages