Issue 312500043: TBR: i#1795 drreg: fix pattern repstr and aflags issues

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 312500043: TBR: i#1795 drreg: fix pattern repstr and aflags issues

Can't Edit
Can't Publish+Mail
Start Review

Created:
7 years, 1 month ago by bruening

Modified:
7 years, 1 month ago

Reviewers:
zhaoqin

CC:
drmemory-devs_googlegroups.com

Visibility:
Public.

More Reviews

Description

Commit log for first patchset: --------------- i#1795 drreg: fix pattern repstr and aflags issues Updates DR to efaf3e1 for fixes in drreg aflags-in-xax optimizations. Fixes some drreg usage issues for pattern mode: + Add a drreg_restore_app_values() barrier to the pattern instrumentation. + Manually restore xax for repstr opts, which are during instru2instru and thus have no automated app restore support. ---------------

Patch Set 1 #

Patch Set 2 : Committed #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+59 lines, -50 lines)			Patch
M	drmemory/pattern.c	View	5 chunks	+17 lines, -8 lines	0 comments	Download
M	tests/addronly-reg.res	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	tests/bitfield.strict.res	View	1 chunk	+12 lines, -12 lines	0 comments	Download
M	tests/registers.res	View	3 chunks	+21 lines, -21 lines	0 comments	Download
M	tests/registers.blacklist.res	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	tests/registers.pattern.res	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

bruening

7 years, 1 month ago (2017-02-21 16:25:07 UTC) #2

Committed as
https://github.com/DynamoRIO/drmemory/commit/936b9300335b3ad0f53bc4f4184db8b4...

Final commit log: 
---------------
i#1795 drreg: fix pattern repstr and aflags issues

Updates DR to efaf3e1 for fixes in drreg aflags-in-xax optimizations.

Fixes some drreg usage issues for pattern mode:

+ Add a drreg_restore_app_values() barrier to the pattern instrumentation.

+ Manually restore xax for repstr opts, which are during instru2instru and
  thus have no automated app restore support.

Review-URL: https://codereview.appspot.com/312500043
---------------

Expand All Messages | Collapse All Messages