Issue 312030043: [dfvfs] Removed online check for new dependency versions #174

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 312030043: [dfvfs] Removed online check for new dependency versions #174 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
7 years, 6 months ago by Joachim Metz

Modified:
7 years, 5 months ago

Reviewers:
jberggren, romaing, onager

CC:
kiddi, log2timeline-dev_googlegroups.com

Visibility:
Public.

More Reviews

Description

[dfvfs] Removed online check for new dependency versions #174

Patch Set 1 #

Total comments: 2

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+163 lines, -292 lines)			Patch
M	config/dpkg/control	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	dfvfs/dependencies.py	View	13 chunks	+146 lines, -233 lines	2 comments	Download
M	requirements.txt	View	1 chunk	+6 lines, -6 lines	0 comments	Download
M	setup.cfg	View	1 chunk	+5 lines, -5 lines	0 comments	Download
M	tests/dependencies.py	View	4 chunks	+3 lines, -45 lines	0 comments	Download
M	utils/check_dependencies.py	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

onager

LGTM https://codereview.appspot.com/312030043/diff/1/dfvfs/dependencies.py File dfvfs/dependencies.py (right): https://codereview.appspot.com/312030043/diff/1/dfvfs/dependencies.py#newcode10 dfvfs/dependencies.py:10: # (version_attribute_name, minimum_version, maximum_version) Can now be a ...

7 years, 5 months ago (2016-10-31 14:52:42 UTC) #2

Joachim Metz

https://codereview.appspot.com/312030043/diff/1/dfvfs/dependencies.py File dfvfs/dependencies.py (right): https://codereview.appspot.com/312030043/diff/1/dfvfs/dependencies.py#newcode10 dfvfs/dependencies.py:10: # (version_attribute_name, minimum_version, maximum_version) On 2016/10/31 14:52:42, onager wrote: ...

7 years, 5 months ago (2016-10-31 15:20:04 UTC) #3

Joachim Metz

7 years, 5 months ago (2016-10-31 15:20:51 UTC) #4

Changes have been merged with master branch. To close the review and clean up
the feature branch you can run: python ./utils/review.py close deps

Expand All Messages | Collapse All Messages