Issue 311760043: i#1680 large pages: Replace VMM_BLOCK_SIZE with an option.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 311760043: i#1680 large pages: Replace VMM_BLOCK_SIZE with an option. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
7 years, 6 months ago by Edmund.Grimley.Evans

Modified:
7 years, 6 months ago

Reviewers:
bruening

CC:
dynamorio-devs_googlegroups.com

Visibility:
Public.

More Reviews

Description

Commit log for first patchset: --------------- i#1680 large pages: Replace VMM_BLOCK_SIZE with an option. VMM_BLOCK_SIZE is replaced with dynamo_options.vmm_block_size. This will make it possible to have it depend on the page size. ---------------

Patch Set 1 #

Total comments: 1

Patch Set 2 : Committed #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+69 lines, -55 lines)			Patch
M	core/heap.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	core/heap.c	View	1	21 chunks	+46 lines, -55 lines	0 comments	Download
M	core/options.c	View		1 chunk	+6 lines, -0 lines	0 comments	Download
M	core/optionsx.h	View		1 chunk	+15 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

bruening

Should be INTERNAL_OPTION. This adds overhead but on alloc paths and there's perhaps no clean ...

7 years, 6 months ago (2016-09-28 04:50:32 UTC) #2

Edmund.Grimley.Evans

7 years, 6 months ago (2016-10-10 13:16:18 UTC) #3

Committed as
https://github.com/DynamoRIO/dynamorio/commit/4fd7afe7e72a941c4027400f64fa131...

Final commit log: 
---------------
i#1680 large pages: Replace VMM_BLOCK_SIZE with an option.

VMM_BLOCK_SIZE is replaced with INTERNAL_OPTION(vmm_block_size).
This will make it possible to have it depend on the page size.

Review-URL: https://codereview.appspot.com/311760043
---------------

Expand All Messages | Collapse All Messages