Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(657)

Issue 311540043: i#2121: Reimplement convert_millis_to_date and convert_date_to_millis. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 2 months ago by Edmund.Grimley.Evans
Modified:
7 years, 2 months ago
Reviewers:
zhaoqin, bruening
CC:
dynamorio-devs_googlegroups.com
Visibility:
Public.

Description

Commit log for first patchset: --------------- i#2121: Reimplement convert_millis_to_date and convert_date_to_millis. Also add a unit test to check that these two functions are consistent. Fixes #2121 ---------------

Patch Set 1 #

Total comments: 4

Patch Set 2 : comments #

Total comments: 4

Patch Set 3 : Committed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+130 lines, -84 lines) Patch
M core/utils.c View 1 2 7 chunks +130 lines, -84 lines 0 comments Download

Messages

Total messages: 11
Edmund.Grimley.Evans
7 years, 2 months ago (2017-01-16 12:40:58 UTC) #1
bruening
The original code is straightforward and readable. Let's make the new code have those properties ...
7 years, 2 months ago (2017-01-16 17:04:36 UTC) #2
Edmund.Grimley.Evans
On 2017/01/16 17:04:36, bruening wrote: > The original code is straightforward and readable. Let's make ...
7 years, 2 months ago (2017-01-17 11:46:24 UTC) #3
bruening
On 2017/01/17 11:46:24, Edmund.Grimley.Evans wrote: > On 2017/01/16 17:04:36, bruening wrote: > > The original ...
7 years, 2 months ago (2017-01-17 15:09:18 UTC) #4
Edmund.Grimley.Evans
> At a higher level as well, I don't understand the general approach: why go ...
7 years, 2 months ago (2017-01-18 10:20:46 UTC) #5
Edmund.Grimley.Evans
Commit log for latest patchset: --------------- i#2121: Reimplement convert_millis_to_date and convert_date_to_millis. Also add a unit ...
7 years, 2 months ago (2017-01-18 10:21:39 UTC) #6
bruening
I am not a fan of cryptic formulas, but if you are sure this is ...
7 years, 2 months ago (2017-01-20 20:08:51 UTC) #7
Edmund.Grimley.Evans
Committed as https://github.com/DynamoRIO/dynamorio/commit/f708cccf22ff7fbf14b5129d5cf16fd70635bf85 Final commit log: --------------- i#2121: Reimplement convert_millis_to_date and convert_date_to_millis. Also add a ...
7 years, 2 months ago (2017-01-23 10:52:38 UTC) #8
bruening
On 2017/01/23 10:52:38, Edmund.Grimley.Evans wrote: > Committed as > https://github.com/DynamoRIO/dynamorio/commit/f708cccf22ff7fbf14b5129d5cf16fd70635bf85 > > Final commit log: ...
7 years, 2 months ago (2017-01-23 15:48:16 UTC) #9
Edmund.Grimley.Evans
> This is blocking me trying to get AppVeyor added so I will go ahead ...
7 years, 2 months ago (2017-01-23 16:15:39 UTC) #10
Edmund.Grimley.Evans
7 years, 2 months ago (2017-01-23 16:17:13 UTC) #11
By the way, I've just noticed that the comment in front of that function,
unit_test_utils, is now out of date.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b