Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(5272)

Issue 311510043: src: Avoid emoji typing during Unicode typing (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 3 months ago by fujiwara
Modified:
7 years, 3 months ago
Reviewers:
shawn.p.huang, Peng
CC:
shawn.p.huang_gmail.com
Base URL:
git@github.com:ibus/ibus.git@master
Visibility:
Public.

Description

src: Avoid emoji typing during Unicode typing If 'sk' layout is used, digit keys need Shift key and Unicode typing of U+1AE requires Shift key after Ctrl-Shift-u. This patch does not enable the emoji typing with Ctrl-Shift-e during Unicode typing. BUG=rhbz#1403985 Committed: f80dcc978fdc9a3d7853434e86f4ee02c2a92b33

Patch Set 1 #

Patch Set 2 : Updated copyright #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M src/ibusenginesimple.c View 1 3 chunks +6 lines, -4 lines 0 comments Download

Messages

Total messages: 3
fujiwara
7 years, 3 months ago (2017-01-10 07:57:42 UTC) #1
Peng
lgtm
7 years, 3 months ago (2017-01-10 14:18:05 UTC) #2
fujiwara
7 years, 3 months ago (2017-01-11 03:11:34 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
f80dcc978fdc9a3d7853434e86f4ee02c2a92b33 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b