Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(4545)

Issue 311500043: TBR: i#1923, DRi#2127, DRi#1374: eliminate UNIX symlink library versioning

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 3 months ago by bruening
Modified:
7 years, 3 months ago
Reviewers:
zhaoqin
CC:
drmemory-devs_googlegroups.com
Visibility:
Public.

Description

Commit log for first patchset: --------------- i#1923, DRi#2127, DRi#1374: eliminate UNIX symlink library versioning Eliminates libdynamorio.so versioning on UNIX platforms to avoid numerous problems (DRi#2127: hardcoded DT_NEEDED, DRi#1374: similar issues on Mac, Android symlink limitations). These versions were not providing much benefit, as we weren't using the system loader. DR's loader and the DRMF init code provide their own client version compatibility checks. Updates DR to 549ce61 for the same sorts of changes in the DR code as well as a fix for DRi#2128. Updates test asm line numbers for asm define changes. ---------------

Patch Set 1 #

Patch Set 2 : Committed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -56 lines) Patch
M CMakeLists.txt View 2 chunks +13 lines, -3 lines 0 comments Download
M drfuzz/CMakeLists.txt View 2 chunks +2 lines, -2 lines 0 comments Download
M drstrace/CMakeLists.txt View 3 chunks +3 lines, -3 lines 0 comments Download
M drsymcache/CMakeLists.txt View 2 chunks +2 lines, -2 lines 0 comments Download
M drsyscall/CMakeLists.txt View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/addronly-reg.res View 1 chunk +3 lines, -3 lines 0 comments Download
M tests/bitfield.strict.res View 1 chunk +12 lines, -12 lines 0 comments Download
M tests/registers.res View 3 chunks +20 lines, -20 lines 0 comments Download
M tests/registers.blacklist.res View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/registers.pattern.res View 1 chunk +2 lines, -2 lines 0 comments Download
M umbra/CMakeLists.txt View 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 2
bruening
7 years, 3 months ago (2017-01-10 02:47:50 UTC) #1
bruening
7 years, 3 months ago (2017-01-10 02:47:52 UTC) #2
Committed as
https://github.com/DynamoRIO/drmemory/commit/2ee98e8a48e8927c737b97a3e1480a20...

Final commit log: 
---------------
i#1923, DRi#2127, DRi#1374: eliminate UNIX symlink library versioning

Eliminates libdynamorio.so versioning on UNIX platforms to avoid numerous
problems (DRi#2127: hardcoded DT_NEEDED, DRi#1374: similar issues on Mac,
Android symlink limitations).  These versions were not providing much
benefit, as we weren't using the system loader.  DR's loader and the DRMF
init code provide their own client version compatibility checks.

Updates DR to 549ce61 for the same sorts of changes in the DR code as well
as a fix for DRi#2128.
Updates test asm line numbers for asm define changes.

Review-URL: https://codereview.appspot.com/311500043
---------------
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b