Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(18299)
Issues Repositories Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 311490043: [plaso] Fix for credentials not beeing passed to worker processes on Windows #1112 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 3 months ago by Joachim Metz
Modified:
7 years ago
Reviewers:
jberggren, romaing, onager
CC:
kiddi, log2timeline-dev_googlegroups.com
Visibility:
Public.

Description

[plaso] Fix for credentials not beeing passed to worker processes on Windows #1112

Patch Set 1 : Fix for credentials not beeing passed to worker processes on Windows #1112 #

Total comments: 4

Patch Set 2 : Changes after merge and review #

Total comments: 4

Patch Set 3 : Additional changes to fix psteal issue on AppVeyor #

Patch Set 4 : Additional changes #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -5 lines) Patch
M plaso/cli/extract_analyze_tool.py View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M plaso/cli/storage_media_tool.py View 1 5 chunks +24 lines, -0 lines 0 comments Download
M plaso/engine/configurations.py View 1 2 7 chunks +32 lines, -0 lines 2 comments Download
M plaso/multi_processing/worker_process.py View 2 chunks +7 lines, -0 lines 0 comments Download
M tools/log2timeline.py View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M tools/psteal_test.py View 1 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 16
Joachim Metz
7 years, 3 months ago (2017-01-08 05:46:29 UTC) #1
Joachim Metz
Code updated.
7 years, 3 months ago (2017-01-08 05:49:40 UTC) #2
onager
https://codereview.appspot.com/311490043/diff/20001/plaso/cli/storage_media_tool.py File plaso/cli/storage_media_tool.py (right): https://codereview.appspot.com/311490043/diff/20001/plaso/cli/storage_media_tool.py#newcode73 plaso/cli/storage_media_tool.py:73: def _AddCredentialConfiguation( Configuration https://codereview.appspot.com/311490043/diff/20001/plaso/cli/storage_media_tool.py#newcode75 plaso/cli/storage_media_tool.py:75: """Adds a credential configuation. ...
7 years, 3 months ago (2017-01-16 16:44:51 UTC) #3
Joachim Metz
https://codereview.appspot.com/311490043/diff/20001/plaso/cli/storage_media_tool.py File plaso/cli/storage_media_tool.py (right): https://codereview.appspot.com/311490043/diff/20001/plaso/cli/storage_media_tool.py#newcode73 plaso/cli/storage_media_tool.py:73: def _AddCredentialConfiguation( On 2017/01/16 16:44:50, onager wrote: > Configuration ...
7 years, 3 months ago (2017-01-16 19:07:51 UTC) #4
Joachim Metz
Code updated.
7 years, 3 months ago (2017-01-16 19:10:48 UTC) #5
Joachim Metz
Code updated.
7 years, 3 months ago (2017-01-16 19:19:58 UTC) #6
onager
https://codereview.appspot.com/311490043/diff/60001/plaso/engine/configurations.py File plaso/engine/configurations.py (right): https://codereview.appspot.com/311490043/diff/60001/plaso/engine/configurations.py#newcode15 plaso/engine/configurations.py:15: CONTAINER_TYPE = u'credentials' credential_configuration, to be consistent with other ...
7 years, 3 months ago (2017-01-18 07:18:42 UTC) #7
onager
On 2017/01/18 07:18:42, onager wrote: > https://codereview.appspot.com/311490043/diff/60001/plaso/engine/configurations.py > File plaso/engine/configurations.py (right): > > https://codereview.appspot.com/311490043/diff/60001/plaso/engine/configurations.py#newcode15 > ...
7 years, 3 months ago (2017-01-18 17:23:33 UTC) #8
Joachim Metz
https://codereview.appspot.com/311490043/diff/60001/plaso/engine/configurations.py File plaso/engine/configurations.py (right): https://codereview.appspot.com/311490043/diff/60001/plaso/engine/configurations.py#newcode15 plaso/engine/configurations.py:15: CONTAINER_TYPE = u'credentials' On 2017/01/18 07:18:42, onager wrote: > ...
7 years, 3 months ago (2017-01-19 06:49:04 UTC) #9
Joachim Metz
Code updated.
7 years, 3 months ago (2017-01-19 06:51:56 UTC) #10
Joachim Metz
Code updated.
7 years, 2 months ago (2017-01-23 06:30:42 UTC) #11
Joachim Metz
Code updated.
7 years, 2 months ago (2017-01-23 07:25:07 UTC) #12
onager
One small nit, LGTM https://codereview.appspot.com/311490043/diff/120001/plaso/engine/configurations.py File plaso/engine/configurations.py (right): https://codereview.appspot.com/311490043/diff/120001/plaso/engine/configurations.py#newcode15 plaso/engine/configurations.py:15: CONTAINER_TYPE = u'credentials_configuration' credential, not ...
7 years, 2 months ago (2017-01-26 14:39:50 UTC) #13
Joachim Metz
I'll submit this once I've fixed: https://ci.appveyor.com/project/joachimmetz/plaso/build/2623
7 years, 2 months ago (2017-01-27 05:03:00 UTC) #14
Joachim Metz
https://codereview.appspot.com/311490043/diff/120001/plaso/engine/configurations.py File plaso/engine/configurations.py (right): https://codereview.appspot.com/311490043/diff/120001/plaso/engine/configurations.py#newcode15 plaso/engine/configurations.py:15: CONTAINER_TYPE = u'credentials_configuration' On 2017/01/26 14:39:49, onager wrote: > ...
7 years ago (2017-03-27 05:34:56 UTC) #15
Joachim Metz
7 years ago (2017-03-27 05:54:58 UTC) #16 
Changes have been merged with master branch. To close the review and clean up
the feature branch you can run: python ./utils/review.py close credfix
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b