Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(84)

Issue 311270043: [plaso] Add unabandoning of tasks, #1073 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 4 months ago by onager
Modified:
7 years, 2 months ago
CC:
kiddi, log2timeline-dev_googlegroups.com
Visibility:
Public.

Description

[plaso] Add unabandoning of tasks, #1073

Patch Set 1 #

Patch Set 2 : Remove non-functional limit, revert container limit. #

Total comments: 10

Patch Set 3 : Changes after review #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -32 lines) Patch
M plaso/multi_processing/task_engine.py View 1 2 4 chunks +21 lines, -12 lines 2 comments Download
M plaso/multi_processing/task_manager.py View 1 2 6 chunks +34 lines, -20 lines 2 comments Download
M tests/multi_processing/task_manager.py View 2 chunks +22 lines, -0 lines 0 comments Download

Messages

Total messages: 8
onager
7 years, 4 months ago (2016-11-10 13:40:27 UTC) #1
onager
Code updated.
7 years, 4 months ago (2016-11-10 13:53:45 UTC) #2
Joachim Metz
https://codereview.appspot.com/311270043/diff/20001/plaso/multi_processing/task_engine.py File plaso/multi_processing/task_engine.py (right): https://codereview.appspot.com/311270043/diff/20001/plaso/multi_processing/task_engine.py#newcode424 plaso/multi_processing/task_engine.py:424: logging.debug(u'Scheduled task {0:s} for path spec {1:s}'.format( spec => ...
7 years, 4 months ago (2016-11-24 16:16:59 UTC) #3
onager
Code updated.
7 years, 4 months ago (2016-11-28 13:11:04 UTC) #4
onager
https://codereview.appspot.com/311270043/diff/20001/plaso/multi_processing/task_engine.py File plaso/multi_processing/task_engine.py (right): https://codereview.appspot.com/311270043/diff/20001/plaso/multi_processing/task_engine.py#newcode424 plaso/multi_processing/task_engine.py:424: logging.debug(u'Scheduled task {0:s} for path spec {1:s}'.format( On 2016/11/24 ...
7 years, 4 months ago (2016-11-28 13:11:18 UTC) #5
Joachim Metz
LGTM, a couple of suggestions for "unabandoned" https://codereview.appspot.com/311270043/diff/40001/plaso/multi_processing/task_engine.py File plaso/multi_processing/task_engine.py (right): https://codereview.appspot.com/311270043/diff/40001/plaso/multi_processing/task_engine.py#newcode690 plaso/multi_processing/task_engine.py:690: # Avoid ...
7 years, 2 months ago (2017-01-10 19:58:51 UTC) #6
onager
https://codereview.appspot.com/311270043/diff/40001/plaso/multi_processing/task_engine.py File plaso/multi_processing/task_engine.py (right): https://codereview.appspot.com/311270043/diff/40001/plaso/multi_processing/task_engine.py#newcode690 plaso/multi_processing/task_engine.py:690: # Avoid nesting exception blocks. On 2017/01/10 19:58:51, Joachim ...
7 years, 2 months ago (2017-01-13 11:13:22 UTC) #7
onager
7 years, 2 months ago (2017-01-13 11:18:15 UTC) #8
Changes have been merged with master branch. To close the review and clean up
the feature branch you can run: python ./utils/review.py close storage3
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b