Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(5899)

Issue 310640043: TBR: i#2006 generalize drcachesim: refactor memref_t to use a union

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 6 months ago by bruening
Modified:
7 years, 6 months ago
Reviewers:
zhaoqin
CC:
dynamorio-devs_googlegroups.com
Visibility:
Public.

Description

Commit log for first patchset: --------------- i#2006 generalize drcachesim: refactor memref_t to use a union Refactors memref_t, now that it is no longer a wire format, to use a union to clarify which data is available for which type. ---------------

Patch Set 1 #

Patch Set 2 : Switch to separated structs #

Patch Set 3 : Committed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+125 lines, -97 lines) Patch
M clients/drcachesim/common/memref.h View 1 1 chunk +44 lines, -15 lines 0 comments Download
M clients/drcachesim/reader/reader.cpp View 1 3 chunks +25 lines, -27 lines 0 comments Download
M clients/drcachesim/simulator/cache.cpp View 1 2 chunks +4 lines, -3 lines 0 comments Download
M clients/drcachesim/simulator/cache_simulator.cpp View 1 2 chunks +16 lines, -16 lines 0 comments Download
M clients/drcachesim/simulator/cache_stats.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M clients/drcachesim/simulator/caching_device.cpp View 1 3 chunks +5 lines, -5 lines 0 comments Download
M clients/drcachesim/simulator/tlb.cpp View 1 4 chunks +7 lines, -7 lines 0 comments Download
M clients/drcachesim/simulator/tlb_simulator.cpp View 1 2 chunks +15 lines, -15 lines 0 comments Download
M clients/drcachesim/tools/histogram.cpp View 1 1 chunk +7 lines, -7 lines 0 comments Download

Messages

Total messages: 3
bruening
7 years, 6 months ago (2016-10-27 15:20:13 UTC) #1
bruening
Commit log for latest patchset: --------------- i#2006 generalize drcachesim: refactor memref_t to use a union ...
7 years, 6 months ago (2016-10-27 16:57:36 UTC) #2
bruening
7 years, 6 months ago (2016-10-27 18:03:09 UTC) #3
Committed as
https://github.com/DynamoRIO/dynamorio/commit/96a6614d303ba63ef51416eedb105bf...

Final commit log: 
---------------
i#2006 generalize drcachesim: refactor memref_t to use a union

Refactors memref_t, now that it is no longer a wire format, to use a union
of structs to clarify which data is available for which type.

Review-URL: https://codereview.appspot.com/310640043
---------------
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b