Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1343)

Issue 310620043: [plaso] Generate an event for browser.last_clear_browsing_data_time in Chrome Preferences file (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 5 months ago by romaing
Modified:
7 years, 4 months ago
CC:
kiddi, log2timeline-dev_googlegroups.com
Visibility:
Public.

Description

[plaso] Generate an event for browser.last_clear_browsing_data_time in Chrome Preferences file

Patch Set 1 #

Total comments: 24

Patch Set 2 : Fix things #

Total comments: 2

Patch Set 3 : change msg #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -12 lines) Patch
M plaso/formatters/chrome_preferences.py View 1 2 chunks +18 lines, -2 lines 0 comments Download
M plaso/parsers/chrome_preferences.py View 1 2 3 chunks +28 lines, -2 lines 0 comments Download
M test_data/Preferences View 1 chunk +1 line, -0 lines 0 comments Download
M tests/parsers/chrome_preferences.py View 1 2 2 chunks +18 lines, -8 lines 0 comments Download

Messages

Total messages: 9
romaing
7 years, 5 months ago (2016-10-26 15:20:46 UTC) #1
Joachim Metz
largely style nits, one optimization suggestion https://codereview.appspot.com/310620043/diff/1/plaso/formatters/chrome_preferences.py File plaso/formatters/chrome_preferences.py (right): https://codereview.appspot.com/310620043/diff/1/plaso/formatters/chrome_preferences.py#newcode10 plaso/formatters/chrome_preferences.py:10: """Formatterfor Chrome history ...
7 years, 5 months ago (2016-10-26 18:52:10 UTC) #2
romaing
Code updated.
7 years, 4 months ago (2016-11-01 16:22:34 UTC) #3
romaing
https://codereview.appspot.com/310620043/diff/1/plaso/formatters/chrome_preferences.py File plaso/formatters/chrome_preferences.py (right): https://codereview.appspot.com/310620043/diff/1/plaso/formatters/chrome_preferences.py#newcode10 plaso/formatters/chrome_preferences.py:10: """Formatterfor Chrome history clearing events.""" On 2016/10/26 18:52:09, Joachim ...
7 years, 4 months ago (2016-11-01 16:22:45 UTC) #4
onager
One minor textual change, then this is good to go. https://codereview.appspot.com/310620043/diff/20001/plaso/parsers/chrome_preferences.py File plaso/parsers/chrome_preferences.py (right): https://codereview.appspot.com/310620043/diff/20001/plaso/parsers/chrome_preferences.py#newcode30 ...
7 years, 4 months ago (2016-11-07 15:21:09 UTC) #5
romaing
Code updated.
7 years, 4 months ago (2016-11-07 17:23:01 UTC) #6
romaing
https://codereview.appspot.com/310620043/diff/20001/plaso/parsers/chrome_preferences.py File plaso/parsers/chrome_preferences.py (right): https://codereview.appspot.com/310620043/diff/20001/plaso/parsers/chrome_preferences.py#newcode30 plaso/parsers/chrome_preferences.py:30: self.message = u'Chrome history is deleted by user' On ...
7 years, 4 months ago (2016-11-07 17:23:31 UTC) #7
onager
On 2016/11/07 17:23:31, romaing wrote: > https://codereview.appspot.com/310620043/diff/20001/plaso/parsers/chrome_preferences.py > File plaso/parsers/chrome_preferences.py (right): > > https://codereview.appspot.com/310620043/diff/20001/plaso/parsers/chrome_preferences.py#newcode30 > ...
7 years, 4 months ago (2016-11-08 12:51:19 UTC) #8
onager
7 years, 4 months ago (2016-11-08 12:54:46 UTC) #9
Changes have been merged with master branch. To close the review and clean up
the feature branch you can run: python ./utils/review.py close
chrome-preferences-clear-hist
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b