Issue 310610043: <#11781292 Add support for non-incremental groups push

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 310610043: <#11781292 Add support for non-incremental groups push

Can't Edit
Can't Publish+Mail
Start Review

Created:
7 years, 5 months ago by imysak

Modified:
7 years, 5 months ago

Reviewers:
ondrejnovak

CC:
connector-cr_google.com, sfruhwald, pjo

Visibility:
Public.

More Reviews

Description

<#11781292 Add support for non-incremental groups push

Patch Set 1 #

Total comments: 1

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+20 lines, -10 lines)			Patch
M	src/com/google/enterprise/adaptor/ad/AdAdaptor.java	View	4 chunks	+4 lines, -3 lines	0 comments	Download
M	src/com/google/enterprise/adaptor/ad/AdServer.java	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	test/com/google/enterprise/adaptor/ad/AccumulatingDocIdPusher.java	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/com/google/enterprise/adaptor/ad/AdAdaptorTest.java	View	1 chunk	+3 lines, -2 lines	1 comment	Download
M	test/com/google/enterprise/adaptor/ad/DelegatingDocIdPusher.java	View	1 chunk	+9 lines, -4 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

ondrejnovak

7 years, 5 months ago (2016-10-27 09:53:25 UTC) #2

Can you explain what the change does? You're toggling the deleted flag, but
doing nothing else.

https://codereview.appspot.com/310610043/diff/1/test/com/google/enterprise/ad...
File test/com/google/enterprise/adaptor/ad/AdAdaptorTest.java (right):

https://codereview.appspot.com/310610043/diff/1/test/com/google/enterprise/ad...
test/com/google/enterprise/adaptor/ad/AdAdaptorTest.java:1173: new
UserPrincipal("sam2", "example.com")
Why are you doing this change?

Expand All Messages | Collapse All Messages