Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(4700)

Issue 309760043: Change http symbol server links to https (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 9 months ago by bruce dawson
Modified:
7 years, 9 months ago
Base URL:
https://github.com/google/syzygy.wiki.git@master
Visibility:
Public.

Description

Change http symbol server links to https Downloading symbols over http is a security risk. At the same time this changes all other eligible http links in this file to https. There are ~37 other http links in other files that should probably be updated. Later. https://github.com/google/syzygy/issues/48 R=sebmarchand@chromium.org Committed: 58b3a54f48956ae7ce0f821cea0dba08da4cfc22

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M SyzyASanBug.md View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 5
bruce dawson
PTAL. If this works then I can update the other http links as well.
7 years, 9 months ago (2016-07-23 20:15:34 UTC) #1
Sébastien Marchand
LGTM, thanks !
7 years, 9 months ago (2016-07-25 22:44:05 UTC) #2
bruce dawson
On 2016/07/25 22:44:05, Sébastien Marchand wrote: > LGTM, thanks ! Can you land? I don't ...
7 years, 9 months ago (2016-07-26 04:43:00 UTC) #3
sebmarchand - Google Account
I just gave you permissions ! Let me know if it worked. On Tue, Jul ...
7 years, 9 months ago (2016-07-26 17:06:00 UTC) #4
bruce dawson
7 years, 9 months ago (2016-07-28 01:30:55 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
58b3a54f48956ae7ce0f821cea0dba08da4cfc22 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b