Issue 309730043: Further separated API plugins from IR.

Issue 309730043: Further separated API plugins from IR. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
7 years, 9 months ago by scudette

Modified:
7 years, 9 months ago

Reviewers:
the80srobot, amoser

CC:
rekall-dev_googlegroups.com

Base URL:
https://github.com/google/rekall.git@master

Visibility:
Public.

More Reviews

Description

Further separated API plugins from IR. IR plugins like glob and find are also active when analyzing raw memory. API plugins are only active when specifying --live API. R=adam.sindelar@gmail.com Committed: bcb651e0be85394064f95e02259f371a82e9aea4

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 4

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+178 lines, -68 lines)			Patch
M	rekall-core/rekall/plugin.py	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	rekall-core/rekall/plugins/response/common.py	View		3 chunks	+23 lines, -7 lines	0 comments	Download
M	rekall-core/rekall/plugins/response/files.py	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	rekall-core/rekall/plugins/response/forensic_artifacts.py	View	1 2	21 chunks	+124 lines, -29 lines	4 comments	Download
M	rekall-core/rekall/plugins/response/linux.py	View		4 chunks	+9 lines, -9 lines	0 comments	Download
M	rekall-core/rekall/plugins/response/processes.py	View		6 chunks	+8 lines, -8 lines	0 comments	Download
M	rekall-core/rekall/plugins/response/windows.py	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	rekall-core/rekall/plugins/response/windows_processes.py	View		5 chunks	+7 lines, -7 lines	0 comments	Download
M	rekall-core/rekall/ui/json_renderer.py	View		1 chunk	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

the80srobot

lgtm https://codereview.appspot.com/309730043/diff/40001/rekall-core/rekall/plugins/response/forensic_artifacts.py File rekall-core/rekall/plugins/response/forensic_artifacts.py (right): https://codereview.appspot.com/309730043/diff/40001/rekall-core/rekall/plugins/response/forensic_artifacts.py#newcode195 rekall-core/rekall/plugins/response/forensic_artifacts.py:195: result.artifact_name, Should we worry about escaping this? https://codereview.appspot.com/309730043/diff/40001/rekall-core/rekall/plugins/response/forensic_artifacts.py#newcode844 ...

7 years, 9 months ago (2016-07-25 08:54:51 UTC) #2

scudette

https://codereview.appspot.com/309730043/diff/40001/rekall-core/rekall/plugins/response/forensic_artifacts.py File rekall-core/rekall/plugins/response/forensic_artifacts.py (right): https://codereview.appspot.com/309730043/diff/40001/rekall-core/rekall/plugins/response/forensic_artifacts.py#newcode195 rekall-core/rekall/plugins/response/forensic_artifacts.py:195: result.artifact_name, On 2016/07/25 08:54:51, the80srobot wrote: > Should we ...

7 years, 9 months ago (2016-07-25 17:23:38 UTC) #3

scudette

7 years, 9 months ago (2016-07-25 17:34:58 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as
bcb651e0be85394064f95e02259f371a82e9aea4 (presubmit successful).

Expand All Messages | Collapse All Messages