Issue 309540043: TBR: Revert "i#1569 AArch64: Reimplement ELF import/export iterators."

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 309540043: TBR: Revert "i#1569 AArch64: Reimplement ELF import/export iterators." (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
7 years, 7 months ago by zhaoqin

Modified:
7 years, 6 months ago

Reviewers:
edmund.grimley.evans, Edmund.Grimley.Evans

CC:
dynamorio-devs_googlegroups.com

Visibility:
Public.

More Reviews

Description

Commit log for first patchset: --------------- Revert "i#1569 AArch64: Reimplement ELF import/export iterators." This reverts commit b92660f476eeed0bb7591cdde8c06bf9163757c5, which breaks DynamoRIO on Android. ---------------

Patch Set 1 #

Patch Set 2 : Committed #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+218 lines, -174 lines)			Patch
	M	core/unix/module_elf.c	View		3 chunks	+210 lines, -168 lines	0 comments	Download
	M	suite/tests/CMakeLists.txt	View		1 chunk	+8 lines, -6 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

zhaoqin

Committed as https://github.com/DynamoRIO/dynamorio/commit/0eb7ed61bc35eb003122084e019d6fbd98edd86b Final commit log: --------------- Revert "i#1569 AArch64: Reimplement ELF import/export iterators." This ...

7 years, 7 months ago (2016-09-23 20:56:30 UTC) #2

Edmund.Grimley.Evans

LGTM. Presumably I should create an issue on github for this...

7 years, 7 months ago (2016-09-26 08:11:57 UTC) #3

You can close this now!

Expand All Messages | Collapse All Messages