Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(714)

Issue 308970043: [plaso] Made tests conditional for sdist size (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 7 months ago by Joachim Metz
Modified:
7 years, 5 months ago
Reviewers:
onager
CC:
kiddi, log2timeline-dev_googlegroups.com
Visibility:
Public.

Description

[plaso] Made tests conditional for sdist size

Patch Set 1 : Made tests conditional for sdist size #

Total comments: 12

Patch Set 2 : Changes after review. #

Total comments: 2

Patch Set 3 : Changes after merge. #

Total comments: 2

Patch Set 4 : Added fail unless has test file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+388 lines, -321 lines) Patch
M run_tests.py View 1 2 3 1 chunk +7 lines, -0 lines 0 comments Download
M tests/analysis/browser_search.py View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/analysis/chrome_extension.py View 1 2 4 chunks +16 lines, -5 lines 0 comments Download
M tests/analysis/manager.py View 2 chunks +13 lines, -11 lines 0 comments Download
M tests/analysis/test_lib.py View 2 chunks +1 line, -9 lines 0 comments Download
M tests/analysis/windows_services.py View 1 2 3 chunks +3 lines, -0 lines 0 comments Download
M tests/analyzers/hashers/manager.py View 2 chunks +3 lines, -1 line 0 comments Download
M tests/analyzers/hashers/md5.py View 1 chunk +17 lines, -10 lines 0 comments Download
M tests/analyzers/hashers/sha1.py View 1 chunk +17 lines, -9 lines 0 comments Download
M tests/analyzers/hashers/sha256.py View 1 chunk +17 lines, -8 lines 0 comments Download
M tests/analyzers/hashers/test_lib.py View 6 chunks +25 lines, -35 lines 0 comments Download
M tests/analyzers/hashing_analyzer.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/analyzers/manager.py View 4 chunks +4 lines, -3 lines 0 comments Download
D tests/analyzers/test_lib.py View 1 chunk +0 lines, -27 lines 0 comments Download
M tests/analyzers/yara_analyzer.py View 1 2 1 chunk +14 lines, -3 lines 0 comments Download
M tests/cli/extraction_tool.py View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download
M tests/cli/hexdump.py View 1 chunk +3 lines, -5 lines 0 comments Download
M tests/cli/storage_media_tool.py View 1 2 10 chunks +36 lines, -8 lines 0 comments Download
M tests/cli/views.py View 4 chunks +4 lines, -11 lines 0 comments Download
M tests/containers/artifacts.py View 4 chunks +5 lines, -5 lines 0 comments Download
M tests/containers/events.py View 3 chunks +3 lines, -2 lines 0 comments Download
M tests/containers/manager.py View 1 chunk +2 lines, -1 line 0 comments Download
M tests/containers/reports.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/containers/sessions.py View 3 chunks +4 lines, -4 lines 0 comments Download
M tests/containers/tasks.py View 3 chunks +4 lines, -4 lines 0 comments Download
M tests/containers/test_lib.py View 1 2 2 chunks +1 line, -11 lines 0 comments Download
M tests/engine/engine.py View 1 2 3 chunks +17 lines, -34 lines 0 comments Download
M tests/engine/extractors.py View 1 2 6 chunks +23 lines, -11 lines 0 comments Download
M tests/engine/knowledge_base.py View 1 chunk +3 lines, -1 line 0 comments Download
M tests/engine/single_process.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/engine/utils.py View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M tests/engine/worker.py View 1 2 3 8 chunks +32 lines, -37 lines 0 comments Download
M tests/multi_processing/task_engine.py View 1 chunk +4 lines, -1 line 0 comments Download
M tests/parsers/esedb_plugins/test_lib.py View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tests/parsers/olecf_plugins/test_lib.py View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tests/parsers/plist_plugins/test_lib.py View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tests/parsers/sqlite_plugins/test_lib.py View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tests/parsers/syslog_plugins/test_lib.py View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tests/parsers/test_lib.py View 1 2 1 chunk +3 lines, -19 lines 0 comments Download
M tests/parsers/winreg_plugins/appcompatcache.py View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tests/parsers/winreg_plugins/bagmru.py View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tests/parsers/winreg_plugins/ccleaner.py View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tests/parsers/winreg_plugins/mountpoints.py View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tests/parsers/winreg_plugins/mrulistex.py View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M tests/parsers/winreg_plugins/msie_zones.py View 1 2 4 chunks +4 lines, -4 lines 0 comments Download
M tests/parsers/winreg_plugins/officemru.py View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tests/parsers/winreg_plugins/programscache.py View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M tests/parsers/winreg_plugins/run.py View 1 2 4 chunks +4 lines, -4 lines 0 comments Download
M tests/parsers/winreg_plugins/sam_users.py View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tests/parsers/winreg_plugins/services.py View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tests/parsers/winreg_plugins/shutdown.py View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tests/parsers/winreg_plugins/task_scheduler.py View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tests/parsers/winreg_plugins/timezone.py View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tests/parsers/winreg_plugins/typedurls.py View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M tests/parsers/winreg_plugins/usb.py View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tests/parsers/winreg_plugins/usbstor.py View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tests/parsers/winreg_plugins/userassist.py View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M tests/parsers/winreg_plugins/winver.py View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tests/test_lib.py View 1 2 3 4 chunks +55 lines, -2 lines 0 comments Download
M tools/preg_test.py View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M utils/review.py View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 18
Joachim Metz
7 years, 7 months ago (2016-08-05 06:39:26 UTC) #1
Joachim Metz
Code updated.
7 years, 7 months ago (2016-08-05 06:49:51 UTC) #2
onager
https://codereview.appspot.com/308970043/diff/20001/tests/analysis/chrome_extension.py File tests/analysis/chrome_extension.py (right): https://codereview.appspot.com/308970043/diff/20001/tests/analysis/chrome_extension.py#newcode36 tests/analysis/chrome_extension.py:36: chrome_web_store_file = os.path.join( Please use _GetTestFilePath https://codereview.appspot.com/308970043/diff/20001/tests/analysis/chrome_extension.py#newcode87 tests/analysis/chrome_extension.py:87: test_file ...
7 years, 7 months ago (2016-08-05 14:29:57 UTC) #3
Joachim Metz
https://codereview.appspot.com/308970043/diff/20001/tests/analysis/chrome_extension.py File tests/analysis/chrome_extension.py (right): https://codereview.appspot.com/308970043/diff/20001/tests/analysis/chrome_extension.py#newcode36 tests/analysis/chrome_extension.py:36: chrome_web_store_file = os.path.join( Ack https://codereview.appspot.com/308970043/diff/20001/tests/analysis/chrome_extension.py#newcode87 tests/analysis/chrome_extension.py:87: test_file = self._GetTestFilePath([]) ...
7 years, 7 months ago (2016-08-05 15:44:59 UTC) #4
Joachim Metz
Code updated.
7 years, 7 months ago (2016-08-05 15:47:58 UTC) #5
onager
I don't see a reasonable situation where someone would have some of the test files ...
7 years, 7 months ago (2016-08-06 08:37:53 UTC) #6
Joachim Metz
Code updated.
7 years, 7 months ago (2016-08-06 08:52:01 UTC) #7
Joachim Metz
https://codereview.appspot.com/308970043/diff/40001/tests/analysis/chrome_extension.py File tests/analysis/chrome_extension.py (right): https://codereview.appspot.com/308970043/diff/40001/tests/analysis/chrome_extension.py#newcode18 tests/analysis/chrome_extension.py:18: _TEST_DATA_PATH = os.path.join(os.getcwd(), u'test_data') On 2016/08/06 08:37:53, onager wrote: ...
7 years, 7 months ago (2016-08-09 06:39:08 UTC) #8
Joachim Metz
Code updated.
7 years, 7 months ago (2016-08-27 07:37:42 UTC) #9
Joachim Metz
Code updated.
7 years, 6 months ago (2016-09-24 14:52:38 UTC) #10
Joachim Metz
Code updated.
7 years, 5 months ago (2016-10-23 18:49:20 UTC) #11
onager
LGTM, one comment https://codereview.appspot.com/308970043/diff/120001/tests/test_lib.py File tests/test_lib.py (right): https://codereview.appspot.com/308970043/diff/120001/tests/test_lib.py#newcode15 tests/test_lib.py:15: def skipUnlessHasTestFile(path_segments): Do we count the ...
7 years, 5 months ago (2016-10-25 18:48:33 UTC) #12
Joachim Metz
https://codereview.appspot.com/308970043/diff/120001/tests/test_lib.py File tests/test_lib.py (right): https://codereview.appspot.com/308970043/diff/120001/tests/test_lib.py#newcode15 tests/test_lib.py:15: def skipUnlessHasTestFile(path_segments): Ack I'll see if I can find ...
7 years, 5 months ago (2016-10-25 19:08:20 UTC) #13
Joachim Metz
Code updated.
7 years, 5 months ago (2016-10-25 19:51:45 UTC) #14
Joachim Metz
Code updated.
7 years, 5 months ago (2016-10-25 19:59:54 UTC) #15
Joachim Metz
PTAL, added a solution which is bit hackish but seems to work
7 years, 5 months ago (2016-10-25 20:00:38 UTC) #16
onager
On 2016/10/25 20:00:38, Joachim Metz wrote: > PTAL, added a solution which is bit hackish ...
7 years, 5 months ago (2016-10-25 20:37:09 UTC) #17
Joachim Metz
7 years, 5 months ago (2016-10-26 06:10:59 UTC) #18
Changes have been merged with master branch. To close the review and clean up
the feature branch you can run: python ./utils/review.py close datasplit1
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b