[plaso] Fixes for psort failing on for end-to-end tests #366

[plaso] Fixes for psort failing on for end-to-end tests #366

[onager, 2016-07-29 10:25:21]

https://codereview.appspot.com/308850043/diff/1/plaso/multi_processing/psort.py
File plaso/multi_processing/psort.py (right):

https://codereview.appspot.com/308850043/diff/1/plaso/multi_processing/psort....
plaso/multi_processing/psort.py:244: for event_queue in self._event_queues:
Why not remove this close instead, to better align the behaviour between the
analysis and extraction phases?

[Joachim Metz, 2016-07-30 07:17:30]

https://codereview.appspot.com/308850043/diff/1/plaso/multi_processing/psort.py
File plaso/multi_processing/psort.py (right):

https://codereview.appspot.com/308850043/diff/1/plaso/multi_processing/psort....
plaso/multi_processing/psort.py:244: for event_queue in self._event_queues:
On 2016/07/29 10:25:21, onager wrote:
> Why not remove this close instead, to better align the behaviour between the
> analysis and extraction phases?

Acknowledged.

[Joachim Metz, 2016-07-30 07:20:28]

Code updated.

[Joachim Metz, 2016-07-30 08:06:52]

this needs more work, since the test are still failing

[Joachim Metz, 2016-07-30 09:15:14]

Code updated.

[onager, 2016-08-01 07:26:15]

https://codereview.appspot.com/308850043/diff/40001/plaso/output/interface.py
File plaso/output/interface.py (right):

https://codereview.appspot.com/308850043/diff/40001/plaso/output/interface.py...
plaso/output/interface.py:66: """Retrieves the names of arguments that are
required by the module.
This makes things more ambiguous here. As the returns section says, these are
args that are both required and not specified.

Please fix.

https://codereview.appspot.com/308850043/diff/40001/plaso/output/json_line.py
File plaso/output/json_line.py (right):

https://codereview.appspot.com/308850043/diff/40001/plaso/output/json_line.py...
plaso/output/json_line.py:26: inode = getattr(event, u'inode', None)
event.inode =  getattr(event, u'inode', 0)?

https://codereview.appspot.com/308850043/diff/40001/plaso/output/l2t_csv.py
File plaso/output/l2t_csv.py (right):

https://codereview.appspot.com/308850043/diff/40001/plaso/output/l2t_csv.py#n...
plaso/output/l2t_csv.py:47: str: fomatted hostname field.
formatted, and elsewhere in this file

https://codereview.appspot.com/308850043/diff/40001/plaso/output/tln.py
File plaso/output/tln.py (right):

https://codereview.appspot.com/308850043/diff/40001/plaso/output/tln.py#newco...
plaso/output/tln.py:30: Returns:
-1 space, to align properly

https://codereview.appspot.com/308850043/diff/40001/plaso/output/tln.py#newco...
plaso/output/tln.py:31: str: formatted description field.
-1 space

https://codereview.appspot.com/308850043/diff/40001/tests/end-to-end.py
File tests/end-to-end.py (right):

https://codereview.appspot.com/308850043/diff/40001/tests/end-to-end.py#newco...
tests/end-to-end.py:596: def _RunPsortWithOutputOptions(
Is there are runpsortwithoutoptions? I think this is fine as just runpsort

[Joachim Metz, 2016-08-01 08:08:24]

https://codereview.appspot.com/308850043/diff/40001/plaso/output/interface.py
File plaso/output/interface.py (right):

https://codereview.appspot.com/308850043/diff/40001/plaso/output/interface.py...
plaso/output/interface.py:66: """Retrieves the names of arguments that are
required by the module.
On 2016/08/01 07:26:14, onager wrote:
> This makes things more ambiguous here. As the returns section says, these are
> args that are both required and not specified.
> 
> Please fix.

Done.

https://codereview.appspot.com/308850043/diff/40001/plaso/output/json_line.py
File plaso/output/json_line.py (right):

https://codereview.appspot.com/308850043/diff/40001/plaso/output/json_line.py...
plaso/output/json_line.py:26: inode = getattr(event, u'inode', None)
does not really matter since this also handles if event.inode = None

https://codereview.appspot.com/308850043/diff/40001/plaso/output/l2t_csv.py
File plaso/output/l2t_csv.py (right):

https://codereview.appspot.com/308850043/diff/40001/plaso/output/l2t_csv.py#n...
plaso/output/l2t_csv.py:47: str: fomatted hostname field.
On 2016/08/01 07:26:14, onager wrote:
> formatted, and elsewhere in this file

Done.

https://codereview.appspot.com/308850043/diff/40001/plaso/output/tln.py
File plaso/output/tln.py (right):

https://codereview.appspot.com/308850043/diff/40001/plaso/output/tln.py#newco...
plaso/output/tln.py:30: Returns:
On 2016/08/01 07:26:14, onager wrote:
> -1 space, to align properly

Done.

https://codereview.appspot.com/308850043/diff/40001/plaso/output/tln.py#newco...
plaso/output/tln.py:31: str: formatted description field.
On 2016/08/01 07:26:14, onager wrote:
> -1 space

Done.

https://codereview.appspot.com/308850043/diff/40001/tests/end-to-end.py
File tests/end-to-end.py (right):

https://codereview.appspot.com/308850043/diff/40001/tests/end-to-end.py#newco...
tests/end-to-end.py:596: def _RunPsortWithOutputOptions(
On 2016/08/01 07:26:14, onager wrote:
> Is there are runpsortwithoutoptions? I think this is fine as just runpsort

Done.

[Joachim Metz, 2016-08-01 09:05:51]

Code updated.

[onager, 2016-08-01 09:07:54]

On 2016/08/01 09:05:51, Joachim Metz wrote:
> Code updated.

LGTM

[Joachim Metz, 2016-08-01 09:17:41]

Changes have been merged with master branch. To close the review and clean up
the feature branch you can run: python ./utils/review.py close eoefix