Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(7000)
Issues Repositories Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 307910043: [plaso] Worked on abort path #338 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 9 months ago by Joachim Metz
Modified:
7 years, 8 months ago
Reviewers:
onager
CC:
kiddi, log2timeline-dev_googlegroups.com
Visibility:
Public.

Description

[plaso] Worked on abort path #338 Depends on: https://codereview.appspot.com/301410043/

Patch Set 1 : Worked on abort path #338 #

Patch Set 2 : Worked on worker processing too long without update #

Total comments: 18

Patch Set 3 : Changes after review. #

Total comments: 6

Patch Set 4 : Changes after review. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+406 lines, -123 lines) Patch
M plaso/containers/artifacts.py View 1 chunk +1 line, -1 line 0 comments Download
M plaso/containers/sessions.py View 1 2 3 6 chunks +7 lines, -0 lines 0 comments Download
M plaso/containers/tasks.py View 1 2 3 5 chunks +5 lines, -0 lines 0 comments Download
M plaso/engine/engine.py View 1 chunk +0 lines, -5 lines 0 comments Download
M plaso/engine/single_process.py View 1 2 3 3 chunks +15 lines, -13 lines 0 comments Download
M plaso/engine/worker.py View 1 2 14 chunks +23 lines, -8 lines 0 comments Download
M plaso/multi_processing/engine.py View 1 2 3 7 chunks +45 lines, -39 lines 0 comments Download
M plaso/multi_processing/multi_process_queue.py View 1 chunk +3 lines, -0 lines 0 comments Download
M plaso/multi_processing/worker_process.py View 1 2 3 5 chunks +18 lines, -17 lines 0 comments Download
M plaso/storage/fake_storage.py View 4 chunks +10 lines, -2 lines 0 comments Download
M plaso/storage/interface.py View 1 chunk +12 lines, -4 lines 0 comments Download
M plaso/storage/zip_file.py View 4 chunks +10 lines, -2 lines 0 comments Download
A tests/containers/artifacts.py View 1 chunk +102 lines, -0 lines 0 comments Download
M tests/containers/events.py View 1 2 3 chunks +10 lines, -10 lines 0 comments Download
M tests/containers/reports.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/containers/sessions.py View 1 2 3 4 chunks +34 lines, -3 lines 0 comments Download
M tests/containers/tasks.py View 1 2 3 4 chunks +29 lines, -3 lines 0 comments Download
M tests/containers/test_lib.py View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M tests/engine/engine.py View 1 chunk +0 lines, -8 lines 0 comments Download
M tests/serializer/json_serializer.py View 1 2 3 4 chunks +72 lines, -0 lines 0 comments Download
M tools/log2timeline.py View 2 chunks +6 lines, -4 lines 0 comments Download

Messages

Total messages: 13
Joachim Metz
7 years, 9 months ago (2016-07-23 10:07:30 UTC) #1
Joachim Metz
Code updated.
7 years, 9 months ago (2016-07-23 10:41:08 UTC) #2
Joachim Metz
Code updated.
7 years, 9 months ago (2016-07-23 12:02:35 UTC) #3
onager
https://codereview.appspot.com/307910043/diff/40001/plaso/containers/sessions.py File plaso/containers/sessions.py (right): https://codereview.appspot.com/307910043/diff/40001/plaso/containers/sessions.py#newcode173 plaso/containers/sessions.py:173: self.aborted = None False? https://codereview.appspot.com/307910043/diff/40001/plaso/containers/tasks.py File plaso/containers/tasks.py (right): https://codereview.appspot.com/307910043/diff/40001/plaso/containers/tasks.py#newcode97 ...
7 years, 9 months ago (2016-07-24 17:07:33 UTC) #4
Joachim Metz
https://codereview.appspot.com/307910043/diff/40001/plaso/containers/sessions.py File plaso/containers/sessions.py (right): https://codereview.appspot.com/307910043/diff/40001/plaso/containers/sessions.py#newcode173 plaso/containers/sessions.py:173: self.aborted = None None indicates here not set, which ...
7 years, 9 months ago (2016-07-24 17:20:53 UTC) #5
Joachim Metz
Code updated.
7 years, 9 months ago (2016-07-24 17:24:34 UTC) #6
Joachim Metz
https://codereview.appspot.com/307910043/diff/60001/plaso/multi_processing/engine.py File plaso/multi_processing/engine.py (right): https://codereview.appspot.com/307910043/diff/60001/plaso/multi_processing/engine.py#newcode48 plaso/multi_processing/engine.py:48: _RPC_SERVER_TIMEOUT = 8.0 TODO move these definitions.
7 years, 9 months ago (2016-07-24 18:33:17 UTC) #7
Joachim Metz
https://codereview.appspot.com/307910043/diff/60001/plaso/multi_processing/engine.py File plaso/multi_processing/engine.py (right): https://codereview.appspot.com/307910043/diff/60001/plaso/multi_processing/engine.py#newcode48 plaso/multi_processing/engine.py:48: _RPC_SERVER_TIMEOUT = 8.0 comment for wrong cl
7 years, 9 months ago (2016-07-24 18:39:09 UTC) #8
onager
https://codereview.appspot.com/307910043/diff/60001/plaso/containers/sessions.py File plaso/containers/sessions.py (right): https://codereview.appspot.com/307910043/diff/60001/plaso/containers/sessions.py#newcode173 plaso/containers/sessions.py:173: self.aborted = None Why is aborted False in Session ...
7 years, 8 months ago (2016-07-25 12:49:54 UTC) #9
Joachim Metz
https://codereview.appspot.com/307910043/diff/60001/plaso/containers/sessions.py File plaso/containers/sessions.py (right): https://codereview.appspot.com/307910043/diff/60001/plaso/containers/sessions.py#newcode173 plaso/containers/sessions.py:173: self.aborted = None On 2016/07/25 12:49:54, onager wrote: > ...
7 years, 8 months ago (2016-07-25 16:47:06 UTC) #10
Joachim Metz
Code updated.
7 years, 8 months ago (2016-07-25 16:51:06 UTC) #11
onager
LGTM
7 years, 8 months ago (2016-07-26 17:28:30 UTC) #12
Joachim Metz
7 years, 8 months ago (2016-07-27 05:31:51 UTC) #13 
Changes have been merged with master branch. To close the review and clean up
the feature branch you can run: python ./utils/review.py close abort1
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b