Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3)

Issue 306990043: i#1959: Separate C++ literals and macros. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 7 months ago by Edmund.Grimley.Evans
Modified:
7 years, 7 months ago
Reviewers:
zhaoqin, bruening
CC:
dynamorio-devs_googlegroups.com
Visibility:
Public.

Description

Commit log for first patchset: --------------- i#1959: Separate C++ literals and macros. Xref i#1958. ---------------

Patch Set 1 #

Patch Set 2 : Committed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -26 lines) Patch
M core/lib/globals_shared.h View 7 chunks +20 lines, -20 lines 0 comments Download
M suite/tests/client-interface/events.dll.c View 3 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 4
Edmund.Grimley.Evans
7 years, 7 months ago (2016-08-10 15:14:14 UTC) #1
Edmund.Grimley.Evans
Have you looked at this one yet? This patch is required for building on Debian ...
7 years, 7 months ago (2016-08-23 10:44:39 UTC) #2
bruening
LGTM
7 years, 7 months ago (2016-08-23 16:05:56 UTC) #3
Edmund.Grimley.Evans
7 years, 7 months ago (2016-08-24 09:08:50 UTC) #4
Committed as
https://github.com/DynamoRIO/dynamorio/commit/fd10d1b98b3d594af3044d0ce5a91ca...

Final commit log: 
---------------
i#1959: Separate C++ literals and macros.

Xref i#1958.

Review-URL: https://codereview.appspot.com/306990043
---------------
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b