[plaso] Removed GetPathAttributes from knowledge base #241

[plaso] Removed GetPathAttributes from knowledge base #241

Depends on:
https://codereview.appspot.com/306070043/

[onager, 2016-08-14 17:27:11]

https://codereview.appspot.com/306940043/diff/1/plaso/engine/path_helper.py
File plaso/engine/path_helper.py (right):

https://codereview.appspot.com/306940043/diff/1/plaso/engine/path_helper.py#n...
plaso/engine/path_helper.py:55: mount_path (Optional[str]): mount path.
please add information about the meaning of this arg to the docstring.

https://codereview.appspot.com/306940043/diff/1/plaso/engine/path_helper.py#n...
plaso/engine/path_helper.py:86: """Retrieves the relative path of a path
specification.
relative to what?

https://codereview.appspot.com/306940043/diff/1/plaso/frontend/preg.py
File plaso/frontend/preg.py (right):

https://codereview.appspot.com/306940043/diff/1/plaso/frontend/preg.py#newcod...
plaso/frontend/preg.py:301: """Create a Windows path resolver and sets the
evironment variables.
-the +it's

And it looks like this only sets one environment variable, systemroot. Why is it
special?

https://codereview.appspot.com/306940043/diff/1/plaso/parsers/mediator.py
File plaso/parsers/mediator.py (right):

https://codereview.appspot.com/306940043/diff/1/plaso/parsers/mediator.py#new...
plaso/parsers/mediator.py:47: """bool: True if the parsing should be aborted."""
-the

https://codereview.appspot.com/306940043/diff/1/plaso/parsers/mediator.py#new...
plaso/parsers/mediator.py:52: """stt: codepage."""
str

https://codereview.appspot.com/306940043/diff/1/plaso/parsers/mediator.py#new...
plaso/parsers/mediator.py:138: int: inode or -1 on error if the inode value
cannot be converted
-on error

https://codereview.appspot.com/306940043/diff/1/plaso/preprocessors/manager.py
File plaso/preprocessors/manager.py (right):

https://codereview.appspot.com/306940043/diff/1/plaso/preprocessors/manager.p...
plaso/preprocessors/manager.py:32: """Create a Windows path resolver and sets
the evironment variables.
-the +it's

Otherwise I'm left wondering where those variables are set.

Also, this method seems to only set environment variables in the resolver if
they're userprofile or systemroot.

[Joachim Metz, 2016-08-14 18:07:33]

https://codereview.appspot.com/306940043/diff/1/plaso/engine/path_helper.py
File plaso/engine/path_helper.py (right):

https://codereview.appspot.com/306940043/diff/1/plaso/engine/path_helper.py#n...
plaso/engine/path_helper.py:55: mount_path (Optional[str]): mount path.
On 2016/08/14 17:27:11, onager wrote:
> please add information about the meaning of this arg to the docstring.

Done.

https://codereview.appspot.com/306940043/diff/1/plaso/engine/path_helper.py#n...
plaso/engine/path_helper.py:86: """Retrieves the relative path of a path
specification.
On 2016/08/14 17:27:11, onager wrote:
> relative to what?

Done.

https://codereview.appspot.com/306940043/diff/1/plaso/frontend/preg.py
File plaso/frontend/preg.py (right):

https://codereview.appspot.com/306940043/diff/1/plaso/frontend/preg.py#newcod...
plaso/frontend/preg.py:301: """Create a Windows path resolver and sets the
evironment variables.
Only 1 at the moment, because it is currently the only one we need this, will
change when we use artifacts.

https://codereview.appspot.com/306940043/diff/1/plaso/parsers/mediator.py
File plaso/parsers/mediator.py (right):

https://codereview.appspot.com/306940043/diff/1/plaso/parsers/mediator.py#new...
plaso/parsers/mediator.py:47: """bool: True if the parsing should be aborted."""
On 2016/08/14 17:27:11, onager wrote:
> -the

Done.

https://codereview.appspot.com/306940043/diff/1/plaso/parsers/mediator.py#new...
plaso/parsers/mediator.py:52: """stt: codepage."""
On 2016/08/14 17:27:11, onager wrote:
> str

Done.

https://codereview.appspot.com/306940043/diff/1/plaso/parsers/mediator.py#new...
plaso/parsers/mediator.py:138: int: inode or -1 on error if the inode value
cannot be converted
On 2016/08/14 17:27:11, onager wrote:
> -on error

Done.

https://codereview.appspot.com/306940043/diff/1/plaso/preprocessors/manager.py
File plaso/preprocessors/manager.py (right):

https://codereview.appspot.com/306940043/diff/1/plaso/preprocessors/manager.p...
plaso/preprocessors/manager.py:32: """Create a Windows path resolver and sets
the evironment variables.
yes because more are currently not needed, I opt to keep the docstring as-is.

[Joachim Metz, 2016-08-14 18:11:17]

Code updated.

[Joachim Metz, 2016-08-14 18:13:56]

Code updated.

[Joachim Metz, 2016-08-27 05:57:51]

Code updated.

[Joachim Metz, 2016-09-24 10:29:46]

Code updated.

[Joachim Metz, 2016-10-16 16:01:05]

Code updated.

[Joachim Metz, 2016-10-24 19:17:18]

Code updated.

[Joachim Metz, 2016-10-26 06:36:36]

Code updated.

[Joachim Metz, 2016-11-01 19:44:16]

Code updated.

[onager, 2016-11-07 15:17:51]

LGTM

[Joachim Metz, 2016-11-07 15:49:53]

Changes have been merged with master branch. To close the review and clean up
the feature branch you can run: python ./utils/review.py close preprocess2