Issue 306280043: <#26352925 Using column aliases instead of pure column name

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 306280043: <#26352925 Using column aliases instead of pure column name (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
7 years, 8 months ago by imysak

Modified:
7 years, 7 months ago

Reviewers:
pjo

CC:
connector-cr_google.com

Visibility:
Public.

More Reviews

Description

<#26352925 Using column aliases instead of pure column name

Patch Set 1 #

Patch Set 2 : <#26352925 Using column aliases instead of pure column name #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -7 lines)			Patch
M	src/com/google/enterprise/adaptor/database/DatabaseAdaptor.java	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	src/com/google/enterprise/adaptor/database/ResponseGenerator.java	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/com/google/enterprise/adaptor/database/TupleReader.java	View		1 chunk	+1 line, -1 line	0 comments	Download
M	test/com/google/enterprise/adaptor/database/DatabaseAdaptorTest.java	View	1	1 chunk	+3 lines, -1 line	0 comments	Download
M	test/com/google/enterprise/adaptor/database/TupleReaderTest.java	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

pjo

Is there anywhere in the src where we are still using getColumnName? (other than the ...

7 years, 8 months ago (2016-08-24 00:41:37 UTC) #3

imysak

On 2016/08/24 00:41:37, pjo wrote: > Is there anywhere in the src where we are ...

7 years, 8 months ago (2016-08-24 00:58:55 UTC) #4

pjo

7 years, 8 months ago (2016-08-24 01:00:46 UTC) #5

LGTM.  Thank you

-
- technology's compounding interest

On Tue, Aug 23, 2016 at 5:58 PM, <imysak@google.com> wrote:

> On 2016/08/24 00:41:37, pjo wrote:
>
>> Is there anywhere in the src where we are still using getColumnName?
>>
> (other
>
>> than the test that throws ISE)
>>
>
> Thank you
>>
>
> no. I replace all using getColumnName in "database" repository
> also I replace one line in "library" also
> https://codereview.appspot.com/303380043/
>
> https://codereview.appspot.com/306280043/
>

Expand All Messages | Collapse All Messages